Revert "[Settings] Remove mobile network v1"
This reverts commit daf6c9e85b
.
Reason for revert: Broken build 6513883 on aosp-master on errorprone
Change-Id: I5e473863c2669a3c89014e12cc952c5c72a12cb7
bug:157138919
This commit is contained in:
50
res/layout/mobile_network_settings_container.xml
Normal file
50
res/layout/mobile_network_settings_container.xml
Normal file
@@ -0,0 +1,50 @@
|
|||||||
|
<?xml version="1.0" encoding="utf-8"?>
|
||||||
|
<!--
|
||||||
|
Copyright (C) 2018 The Android Open Source Project
|
||||||
|
|
||||||
|
Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
you may not use this file except in compliance with the License.
|
||||||
|
You may obtain a copy of the License at
|
||||||
|
|
||||||
|
http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
|
||||||
|
Unless required by applicable law or agreed to in writing, software
|
||||||
|
distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
See the License for the specific language governing permissions and
|
||||||
|
limitations under the License.
|
||||||
|
-->
|
||||||
|
|
||||||
|
<LinearLayout
|
||||||
|
xmlns:android="http://schemas.android.com/apk/res/android"
|
||||||
|
xmlns:app="http://schemas.android.com/apk/res-auto"
|
||||||
|
android:layout_width="match_parent"
|
||||||
|
android:layout_height="match_parent"
|
||||||
|
android:orientation="vertical">
|
||||||
|
|
||||||
|
<Toolbar
|
||||||
|
android:id="@+id/mobile_action_bar"
|
||||||
|
style="?android:attr/actionBarStyle"
|
||||||
|
android:layout_width="match_parent"
|
||||||
|
android:layout_height="wrap_content"
|
||||||
|
android:navigationContentDescription="@*android:string/action_bar_up_description"
|
||||||
|
android:theme="?android:attr/actionBarTheme"/>
|
||||||
|
|
||||||
|
<FrameLayout
|
||||||
|
android:id="@+id/main_content"
|
||||||
|
android:layout_width="match_parent"
|
||||||
|
android:layout_height="wrap_content"
|
||||||
|
android:layout_weight="1"/>
|
||||||
|
|
||||||
|
<com.google.android.material.bottomnavigation.BottomNavigationView
|
||||||
|
android:id="@+id/bottom_nav"
|
||||||
|
android:layout_width="match_parent"
|
||||||
|
android:layout_height="wrap_content"
|
||||||
|
android:layout_alignParentBottom="true"
|
||||||
|
android:layout_marginEnd="0dp"
|
||||||
|
android:layout_marginStart="0dp"
|
||||||
|
android:background="?android:attr/windowBackground"
|
||||||
|
app:itemIconTint="@color/bottom_navigation_colors"
|
||||||
|
app:itemTextColor="@color/bottom_navigation_colors"
|
||||||
|
app:menu="@menu/home_bottom_navigation"/>
|
||||||
|
</LinearLayout>
|
@@ -27,7 +27,9 @@ import androidx.appcompat.app.AlertDialog;
|
|||||||
import androidx.fragment.app.Fragment;
|
import androidx.fragment.app.Fragment;
|
||||||
|
|
||||||
import com.android.settings.R;
|
import com.android.settings.R;
|
||||||
|
import com.android.settings.core.FeatureFlags;
|
||||||
import com.android.settings.dashboard.DashboardFragment;
|
import com.android.settings.dashboard.DashboardFragment;
|
||||||
|
import com.android.settings.development.featureflags.FeatureFlagPersistent;
|
||||||
import com.android.settings.network.MobilePlanPreferenceController.MobilePlanPreferenceHost;
|
import com.android.settings.network.MobilePlanPreferenceController.MobilePlanPreferenceHost;
|
||||||
import com.android.settings.search.BaseSearchIndexProvider;
|
import com.android.settings.search.BaseSearchIndexProvider;
|
||||||
import com.android.settings.wifi.WifiMasterSwitchPreferenceController;
|
import com.android.settings.wifi.WifiMasterSwitchPreferenceController;
|
||||||
@@ -58,14 +60,20 @@ public class NetworkDashboardFragment extends DashboardFragment implements
|
|||||||
|
|
||||||
@Override
|
@Override
|
||||||
protected int getPreferenceScreenResId() {
|
protected int getPreferenceScreenResId() {
|
||||||
return R.xml.network_and_internet_v2;
|
if (FeatureFlagPersistent.isEnabled(getContext(), FeatureFlags.NETWORK_INTERNET_V2)) {
|
||||||
|
return R.xml.network_and_internet_v2;
|
||||||
|
} else {
|
||||||
|
return R.xml.network_and_internet;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void onAttach(Context context) {
|
public void onAttach(Context context) {
|
||||||
super.onAttach(context);
|
super.onAttach(context);
|
||||||
|
|
||||||
use(MultiNetworkHeaderController.class).init(getSettingsLifecycle());
|
if (FeatureFlagPersistent.isEnabled(context, FeatureFlags.NETWORK_INTERNET_V2)) {
|
||||||
|
use(MultiNetworkHeaderController.class).init(getSettingsLifecycle());
|
||||||
|
}
|
||||||
use(AirplaneModePreferenceController.class).setFragment(this);
|
use(AirplaneModePreferenceController.class).setFragment(this);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -87,6 +95,10 @@ public class NetworkDashboardFragment extends DashboardFragment implements
|
|||||||
new MobilePlanPreferenceController(context, mobilePlanHost);
|
new MobilePlanPreferenceController(context, mobilePlanHost);
|
||||||
final WifiMasterSwitchPreferenceController wifiPreferenceController =
|
final WifiMasterSwitchPreferenceController wifiPreferenceController =
|
||||||
new WifiMasterSwitchPreferenceController(context, metricsFeatureProvider);
|
new WifiMasterSwitchPreferenceController(context, metricsFeatureProvider);
|
||||||
|
MobileNetworkPreferenceController mobileNetworkPreferenceController = null;
|
||||||
|
if (!FeatureFlagPersistent.isEnabled(context, FeatureFlags.NETWORK_INTERNET_V2)) {
|
||||||
|
mobileNetworkPreferenceController = new MobileNetworkPreferenceController(context);
|
||||||
|
}
|
||||||
|
|
||||||
final VpnPreferenceController vpnPreferenceController =
|
final VpnPreferenceController vpnPreferenceController =
|
||||||
new VpnPreferenceController(context);
|
new VpnPreferenceController(context);
|
||||||
@@ -96,13 +108,21 @@ public class NetworkDashboardFragment extends DashboardFragment implements
|
|||||||
if (lifecycle != null) {
|
if (lifecycle != null) {
|
||||||
lifecycle.addObserver(mobilePlanPreferenceController);
|
lifecycle.addObserver(mobilePlanPreferenceController);
|
||||||
lifecycle.addObserver(wifiPreferenceController);
|
lifecycle.addObserver(wifiPreferenceController);
|
||||||
|
if (mobileNetworkPreferenceController != null) {
|
||||||
|
lifecycle.addObserver(mobileNetworkPreferenceController);
|
||||||
|
}
|
||||||
lifecycle.addObserver(vpnPreferenceController);
|
lifecycle.addObserver(vpnPreferenceController);
|
||||||
lifecycle.addObserver(privateDnsPreferenceController);
|
lifecycle.addObserver(privateDnsPreferenceController);
|
||||||
}
|
}
|
||||||
|
|
||||||
final List<AbstractPreferenceController> controllers = new ArrayList<>();
|
final List<AbstractPreferenceController> controllers = new ArrayList<>();
|
||||||
|
|
||||||
controllers.add(new MobileNetworkSummaryController(context, lifecycle));
|
if (FeatureFlagPersistent.isEnabled(context, FeatureFlags.NETWORK_INTERNET_V2)) {
|
||||||
|
controllers.add(new MobileNetworkSummaryController(context, lifecycle));
|
||||||
|
}
|
||||||
|
if (mobileNetworkPreferenceController != null) {
|
||||||
|
controllers.add(mobileNetworkPreferenceController);
|
||||||
|
}
|
||||||
controllers.add(new TetherPreferenceController(context, lifecycle));
|
controllers.add(new TetherPreferenceController(context, lifecycle));
|
||||||
controllers.add(vpnPreferenceController);
|
controllers.add(vpnPreferenceController);
|
||||||
controllers.add(new ProxyPreferenceController(context));
|
controllers.add(new ProxyPreferenceController(context));
|
||||||
@@ -148,7 +168,12 @@ public class NetworkDashboardFragment extends DashboardFragment implements
|
|||||||
public List<SearchIndexableResource> getXmlResourcesToIndex(
|
public List<SearchIndexableResource> getXmlResourcesToIndex(
|
||||||
Context context, boolean enabled) {
|
Context context, boolean enabled) {
|
||||||
final SearchIndexableResource sir = new SearchIndexableResource(context);
|
final SearchIndexableResource sir = new SearchIndexableResource(context);
|
||||||
sir.xmlResId = R.xml.network_and_internet_v2;
|
if (FeatureFlagPersistent.isEnabled(context,
|
||||||
|
FeatureFlags.NETWORK_INTERNET_V2)) {
|
||||||
|
sir.xmlResId = R.xml.network_and_internet_v2;
|
||||||
|
} else {
|
||||||
|
sir.xmlResId = R.xml.network_and_internet;
|
||||||
|
}
|
||||||
return Arrays.asList(sir);
|
return Arrays.asList(sir);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@@ -28,6 +28,8 @@ import android.telephony.SubscriptionInfo;
|
|||||||
import android.telephony.SubscriptionManager;
|
import android.telephony.SubscriptionManager;
|
||||||
import android.telephony.ims.ImsRcsManager;
|
import android.telephony.ims.ImsRcsManager;
|
||||||
import android.text.TextUtils;
|
import android.text.TextUtils;
|
||||||
|
import android.view.Menu;
|
||||||
|
import android.view.View;
|
||||||
|
|
||||||
import androidx.annotation.NonNull;
|
import androidx.annotation.NonNull;
|
||||||
import androidx.annotation.VisibleForTesting;
|
import androidx.annotation.VisibleForTesting;
|
||||||
@@ -38,9 +40,13 @@ import androidx.fragment.app.FragmentTransaction;
|
|||||||
import com.android.internal.telephony.TelephonyIntents;
|
import com.android.internal.telephony.TelephonyIntents;
|
||||||
import com.android.internal.util.CollectionUtils;
|
import com.android.internal.util.CollectionUtils;
|
||||||
import com.android.settings.R;
|
import com.android.settings.R;
|
||||||
|
import com.android.settings.core.FeatureFlags;
|
||||||
import com.android.settings.core.SettingsBaseActivity;
|
import com.android.settings.core.SettingsBaseActivity;
|
||||||
|
import com.android.settings.development.featureflags.FeatureFlagPersistent;
|
||||||
import com.android.settings.network.SubscriptionUtil;
|
import com.android.settings.network.SubscriptionUtil;
|
||||||
|
|
||||||
|
import com.google.android.material.bottomnavigation.BottomNavigationView;
|
||||||
|
|
||||||
import java.util.ArrayList;
|
import java.util.ArrayList;
|
||||||
import java.util.List;
|
import java.util.List;
|
||||||
import java.util.Objects;
|
import java.util.Objects;
|
||||||
@@ -108,7 +114,11 @@ public class MobileNetworkActivity extends SettingsBaseActivity {
|
|||||||
@Override
|
@Override
|
||||||
protected void onCreate(Bundle savedInstanceState) {
|
protected void onCreate(Bundle savedInstanceState) {
|
||||||
super.onCreate(savedInstanceState);
|
super.onCreate(savedInstanceState);
|
||||||
setContentView(R.layout.mobile_network_settings_container_v2);
|
if (FeatureFlagPersistent.isEnabled(this, FeatureFlags.NETWORK_INTERNET_V2)) {
|
||||||
|
setContentView(R.layout.mobile_network_settings_container_v2);
|
||||||
|
} else {
|
||||||
|
setContentView(R.layout.mobile_network_settings_container);
|
||||||
|
}
|
||||||
setActionBar(findViewById(R.id.mobile_action_bar));
|
setActionBar(findViewById(R.id.mobile_action_bar));
|
||||||
mPhoneChangeReceiver = new PhoneChangeReceiver(this, new PhoneChangeReceiver.Client() {
|
mPhoneChangeReceiver = new PhoneChangeReceiver(this, new PhoneChangeReceiver.Client() {
|
||||||
@Override
|
@Override
|
||||||
@@ -176,6 +186,10 @@ public class MobileNetworkActivity extends SettingsBaseActivity {
|
|||||||
|
|
||||||
mSubscriptionInfos = mSubscriptionManager.getActiveSubscriptionInfoList(true);
|
mSubscriptionInfos = mSubscriptionManager.getActiveSubscriptionInfoList(true);
|
||||||
|
|
||||||
|
if (!FeatureFlagPersistent.isEnabled(this, FeatureFlags.NETWORK_INTERNET_V2)) {
|
||||||
|
updateBottomNavigationView();
|
||||||
|
}
|
||||||
|
|
||||||
if (savedInstanceState == null) {
|
if (savedInstanceState == null) {
|
||||||
switchFragment(new MobileNetworkSettings(), getSubscriptionId());
|
switchFragment(new MobileNetworkSettings(), getSubscriptionId());
|
||||||
}
|
}
|
||||||
@@ -229,6 +243,28 @@ public class MobileNetworkActivity extends SettingsBaseActivity {
|
|||||||
return SubscriptionManager.INVALID_SUBSCRIPTION_ID;
|
return SubscriptionManager.INVALID_SUBSCRIPTION_ID;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@VisibleForTesting
|
||||||
|
void updateBottomNavigationView() {
|
||||||
|
final BottomNavigationView navigation = findViewById(R.id.bottom_nav);
|
||||||
|
|
||||||
|
if (CollectionUtils.size(mSubscriptionInfos) <= 1) {
|
||||||
|
navigation.setVisibility(View.GONE);
|
||||||
|
} else {
|
||||||
|
final Menu menu = navigation.getMenu();
|
||||||
|
menu.clear();
|
||||||
|
for (int i = 0, size = mSubscriptionInfos.size(); i < size; i++) {
|
||||||
|
final SubscriptionInfo subscriptionInfo = mSubscriptionInfos.get(i);
|
||||||
|
menu.add(0, subscriptionInfo.getSubscriptionId(), i,
|
||||||
|
subscriptionInfo.getDisplayName())
|
||||||
|
.setIcon(R.drawable.ic_settings_sim);
|
||||||
|
}
|
||||||
|
navigation.setOnNavigationItemSelectedListener(item -> {
|
||||||
|
switchFragment(new MobileNetworkSettings(), item.getItemId());
|
||||||
|
return true;
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
@VisibleForTesting
|
@VisibleForTesting
|
||||||
void switchFragment(Fragment fragment, int subscriptionId) {
|
void switchFragment(Fragment fragment, int subscriptionId) {
|
||||||
switchFragment(fragment, subscriptionId, false /* forceUpdate */);
|
switchFragment(fragment, subscriptionId, false /* forceUpdate */);
|
||||||
|
@@ -22,19 +22,24 @@ import static androidx.lifecycle.Lifecycle.Event.ON_RESUME;
|
|||||||
import android.content.Context;
|
import android.content.Context;
|
||||||
import android.telephony.SubscriptionInfo;
|
import android.telephony.SubscriptionInfo;
|
||||||
import android.telephony.SubscriptionManager;
|
import android.telephony.SubscriptionManager;
|
||||||
|
import android.util.Log;
|
||||||
|
|
||||||
|
import com.android.settings.R;
|
||||||
|
import com.android.settings.core.BasePreferenceController;
|
||||||
|
import com.android.settings.core.FeatureFlags;
|
||||||
|
import com.android.settings.development.featureflags.FeatureFlagPersistent;
|
||||||
|
import com.android.settings.network.SubscriptionUtil;
|
||||||
|
import com.android.settings.network.SubscriptionsChangeListener;
|
||||||
|
import com.android.settings.widget.SwitchBar;
|
||||||
|
import com.android.settingslib.widget.LayoutPreference;
|
||||||
|
|
||||||
|
import java.util.List;
|
||||||
|
|
||||||
import androidx.lifecycle.Lifecycle;
|
import androidx.lifecycle.Lifecycle;
|
||||||
import androidx.lifecycle.LifecycleObserver;
|
import androidx.lifecycle.LifecycleObserver;
|
||||||
import androidx.lifecycle.OnLifecycleEvent;
|
import androidx.lifecycle.OnLifecycleEvent;
|
||||||
import androidx.preference.PreferenceScreen;
|
import androidx.preference.PreferenceScreen;
|
||||||
|
|
||||||
import com.android.settings.R;
|
|
||||||
import com.android.settings.core.BasePreferenceController;
|
|
||||||
import com.android.settings.network.SubscriptionUtil;
|
|
||||||
import com.android.settings.network.SubscriptionsChangeListener;
|
|
||||||
import com.android.settings.widget.SwitchBar;
|
|
||||||
import com.android.settingslib.widget.LayoutPreference;
|
|
||||||
|
|
||||||
/** This controls a switch to allow enabling/disabling a mobile network */
|
/** This controls a switch to allow enabling/disabling a mobile network */
|
||||||
public class MobileNetworkSwitchController extends BasePreferenceController implements
|
public class MobileNetworkSwitchController extends BasePreferenceController implements
|
||||||
SubscriptionsChangeListener.SubscriptionsChangeListenerClient, LifecycleObserver {
|
SubscriptionsChangeListener.SubscriptionsChangeListenerClient, LifecycleObserver {
|
||||||
@@ -113,8 +118,11 @@ public class MobileNetworkSwitchController extends BasePreferenceController impl
|
|||||||
|
|
||||||
@Override
|
@Override
|
||||||
public int getAvailabilityStatus() {
|
public int getAvailabilityStatus() {
|
||||||
return AVAILABLE_UNSEARCHABLE;
|
if (FeatureFlagPersistent.isEnabled(mContext, FeatureFlags.NETWORK_INTERNET_V2)) {
|
||||||
|
return AVAILABLE_UNSEARCHABLE;
|
||||||
|
} else {
|
||||||
|
return CONDITIONALLY_UNAVAILABLE;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
Reference in New Issue
Block a user