PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Settings] Add a metric for time spending in each Settings page

Browse Source 
Add elapsed time in the target page hidden metric

Bug: 146610928
Test: robotest
Change-Id: If045a203e3ca64e36ec5d764b3488d10f26c4408
This commit is contained in:
Jason Chiu
2019-12-24 13:50:16 +08:00
parent 05de72e6d2
commit 9c628ee945
4 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/com/android/settings/core/instrumentation/SettingsEventLogWriter.java
View File

@@ -33,11 +33,11 @@ public class SettingsEventLogWriter extends EventLogWriter {
} }
@Override @Override
public void hidden(Context context, int category) { public void hidden(Context context, int category, int visibleTime) {
if (shouldDisableGenericEventLogging()) { if (shouldDisableGenericEventLogging()) {
return; return;
} }
super.hidden(context, category); super.hidden(context, category, visibleTime);
} }
@Override @Override

4
src/com/android/settings/core/instrumentation/SettingsIntelligenceLogWriter.java
View File

@@ -70,12 +70,12 @@ public class SettingsIntelligenceLogWriter implements LogWriter {
} }
@Override @Override
public void hidden(Context context, int pageId) { public void hidden(Context context, int pageId, int visibleTime) {
action(SettingsEnums.PAGE_UNKNOWN /* attribution */, action(SettingsEnums.PAGE_UNKNOWN /* attribution */,
SettingsEnums.PAGE_HIDE /* action */, SettingsEnums.PAGE_HIDE /* action */,
pageId /* pageId */, pageId /* pageId */,
"" /* changedPreferenceKey */, "" /* changedPreferenceKey */,
0 /* changedPreferenceIntValue */); visibleTime /* changedPreferenceIntValue */);
} }
@Override @Override

4
src/com/android/settings/core/instrumentation/StatsLogWriter.java
View File

@@ -36,13 +36,13 @@ public class StatsLogWriter implements LogWriter {
} }
@Override @Override
public void hidden(Context context, int pageId) { public void hidden(Context context, int pageId, int visibleTime) {
StatsLog.write(StatsLog.SETTINGS_UI_CHANGED /* Atom name */, StatsLog.write(StatsLog.SETTINGS_UI_CHANGED /* Atom name */,
SettingsEnums.PAGE_UNKNOWN /* attribution */, SettingsEnums.PAGE_UNKNOWN /* attribution */,
SettingsEnums.PAGE_HIDE /* action */, SettingsEnums.PAGE_HIDE /* action */,
pageId, pageId,
null /* changedPreferenceKey */, null /* changedPreferenceKey */,
0 /* changedPreferenceIntValue */); visibleTime /* changedPreferenceIntValue */);
} }
@Override @Override

4
tests/robotests/src/com/android/settings/core/instrumentation/SettingsEventLogWriterTest.java
View File

@@ -72,7 +72,7 @@ public class SettingsEventLogWriterTest {
DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SETTINGS_UI, DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SETTINGS_UI,
SettingsUIDeviceConfig.GENERIC_EVENT_LOGGING_ENABLED, "true", true); SettingsUIDeviceConfig.GENERIC_EVENT_LOGGING_ENABLED, "true", true);
mWriter.hidden(RuntimeEnvironment.application, SettingsEnums.SETTINGS_HOMEPAGE); mWriter.hidden(RuntimeEnvironment.application, SettingsEnums.SETTINGS_HOMEPAGE, 0);
assertThat(ShadowMetricsLogger.sActionLoggedCount).isEqualTo(1); assertThat(ShadowMetricsLogger.sActionLoggedCount).isEqualTo(1);
} }
@@ -93,7 +93,7 @@ public class SettingsEventLogWriterTest {
DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SETTINGS_UI, DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SETTINGS_UI,
SettingsUIDeviceConfig.GENERIC_EVENT_LOGGING_ENABLED, "false", true); SettingsUIDeviceConfig.GENERIC_EVENT_LOGGING_ENABLED, "false", true);
mWriter.hidden(RuntimeEnvironment.application, SettingsEnums.SETTINGS_HOMEPAGE); mWriter.hidden(RuntimeEnvironment.application, SettingsEnums.SETTINGS_HOMEPAGE, 0);
assertThat(ShadowMetricsLogger.sActionLoggedCount).isEqualTo(0); assertThat(ShadowMetricsLogger.sActionLoggedCount).isEqualTo(0);
} }