Merge "Use Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY for user visible versions"
This commit is contained in:
@@ -75,7 +75,7 @@ public class FirmwareVersionDetailPreferenceController extends BasePreferenceCon
|
|||||||
|
|
||||||
@Override
|
@Override
|
||||||
public CharSequence getSummary() {
|
public CharSequence getSummary() {
|
||||||
return Build.VERSION.RELEASE_OR_CODENAME;
|
return Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY;
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
@@ -34,6 +34,6 @@ public class FirmwareVersionPreferenceController extends BasePreferenceControlle
|
|||||||
|
|
||||||
@Override
|
@Override
|
||||||
public CharSequence getSummary() {
|
public CharSequence getSummary() {
|
||||||
return Build.VERSION.RELEASE_OR_CODENAME;
|
return Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@@ -219,7 +219,7 @@ public class StorageUtils {
|
|||||||
public Dialog onCreateDialog(Bundle savedInstanceState) {
|
public Dialog onCreateDialog(Bundle savedInstanceState) {
|
||||||
return new AlertDialog.Builder(getActivity())
|
return new AlertDialog.Builder(getActivity())
|
||||||
.setMessage(getContext().getString(R.string.storage_detail_dialog_system,
|
.setMessage(getContext().getString(R.string.storage_detail_dialog_system,
|
||||||
Build.VERSION.RELEASE_OR_CODENAME))
|
Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY))
|
||||||
.setPositiveButton(android.R.string.ok, null)
|
.setPositiveButton(android.R.string.ok, null)
|
||||||
.create();
|
.create();
|
||||||
}
|
}
|
||||||
|
@@ -89,7 +89,7 @@ public class SystemUpdatePreferenceController extends BasePreferenceController {
|
|||||||
@Override
|
@Override
|
||||||
public CharSequence getSummary() {
|
public CharSequence getSummary() {
|
||||||
CharSequence summary = mContext.getString(R.string.android_version_summary,
|
CharSequence summary = mContext.getString(R.string.android_version_summary,
|
||||||
Build.VERSION.RELEASE_OR_CODENAME);
|
Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY);
|
||||||
final FutureTask<Bundle> bundleFutureTask = new FutureTask<>(
|
final FutureTask<Bundle> bundleFutureTask = new FutureTask<>(
|
||||||
// Put the API call in a future to avoid StrictMode violation.
|
// Put the API call in a future to avoid StrictMode violation.
|
||||||
() -> mUpdateManager.retrieveSystemUpdateInfo());
|
() -> mUpdateManager.retrieveSystemUpdateInfo());
|
||||||
|
@@ -63,7 +63,7 @@ public class FirmwareVersionDetailPreferenceControllerTest {
|
|||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void getSummary_shouldGetBuildVersion() {
|
public void getSummary_shouldGetBuildVersion() {
|
||||||
assertThat(mController.getSummary()).isEqualTo(Build.VERSION.RELEASE_OR_CODENAME);
|
assertThat(mController.getSummary()).isEqualTo(Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
|
@@ -65,6 +65,6 @@ public class FirmwareVersionPreferenceControllerTest {
|
|||||||
public void updatePreference_shouldSetSummaryToBuildNumber() {
|
public void updatePreference_shouldSetSummaryToBuildNumber() {
|
||||||
mController.updateState(mPreference);
|
mController.updateState(mPreference);
|
||||||
|
|
||||||
assertThat(mPreference.getSummary()).isEqualTo(Build.VERSION.RELEASE_OR_CODENAME);
|
assertThat(mPreference.getSummary()).isEqualTo(Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@@ -139,7 +139,7 @@ public class SystemUpdatePreferenceControllerTest {
|
|||||||
|
|
||||||
assertThat(mPreference.getSummary())
|
assertThat(mPreference.getSummary())
|
||||||
.isEqualTo(mContext.getString(R.string.android_version_summary,
|
.isEqualTo(mContext.getString(R.string.android_version_summary,
|
||||||
Build.VERSION.RELEASE_OR_CODENAME));
|
Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY));
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
@@ -168,4 +168,4 @@ public class SystemUpdatePreferenceControllerTest {
|
|||||||
assertThat(mPreference.getSummary())
|
assertThat(mPreference.getSummary())
|
||||||
.isEqualTo(mContext.getString(R.string.android_version_pending_update_summary));
|
.isEqualTo(mContext.getString(R.string.android_version_pending_update_summary));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user