diff --git a/res/layout/manage_applications_apps.xml b/res/layout/manage_applications_apps.xml index d814164647a..055e4b453e3 100644 --- a/res/layout/manage_applications_apps.xml +++ b/res/layout/manage_applications_apps.xml @@ -14,7 +14,7 @@ limitations under the License. --> - + android:elevation="2dp" + settings:layout_constraintTop_toTopOf="parent"/> - + android:layout_height="0dp" + android:clipToPadding="false" + android:scrollbars="none" + android:visibility="invisible" + settings:fastScrollEnabled="true" + settings:fastScrollHorizontalThumbDrawable="@drawable/thumb_drawable" + settings:fastScrollHorizontalTrackDrawable="@drawable/line_drawable" + settings:fastScrollVerticalThumbDrawable="@drawable/thumb_drawable" + settings:fastScrollVerticalTrackDrawable="@drawable/line_drawable" + settings:layout_constraintTop_toBottomOf="@id/pinned_header" + settings:layout_constraintBottom_toBottomOf="parent"/> - + - + - - - - - + diff --git a/res/values/dimens.xml b/res/values/dimens.xml index f3030c13580..f3b8a91708f 100755 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -149,8 +149,6 @@ 182dp 32dp 24dp - - 80dp 88dip diff --git a/res/values/strings.xml b/res/values/strings.xml index 7acf9e22013..c19c8dc6711 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -1212,6 +1212,8 @@ Learn more Lift finger, then touch sensor again + + Please recalibrate the fingerprint sensor. You can add up to %d fingerprints diff --git a/res/xml/security_lockscreen_settings.xml b/res/xml/security_lockscreen_settings.xml index 82cb8609114..0e802f665f5 100644 --- a/res/xml/security_lockscreen_settings.xml +++ b/res/xml/security_lockscreen_settings.xml @@ -45,6 +45,12 @@ android:title="@string/owner_info_settings_title" android:summary="@string/owner_info_settings_summary" /> + + appList = new ArrayList<>(); @@ -491,8 +471,6 @@ public class ManageApplicationsTest { mFragment.mFilterAdapter.updateFilterView(true); assertThat(mFragment.mSpinnerHeader.getVisibility()).isEqualTo(View.VISIBLE); - assertThat(mFragment.mRecyclerView.getPaddingTop()).isEqualTo( - mContext.getResources().getDimensionPixelSize(R.dimen.app_bar_height)); } @Test diff --git a/tests/robotests/src/com/android/settings/core/SubSettingLauncherTest.java b/tests/robotests/src/com/android/settings/core/SubSettingLauncherTest.java index 2a0d3df95cc..b68bcec3f18 100644 --- a/tests/robotests/src/com/android/settings/core/SubSettingLauncherTest.java +++ b/tests/robotests/src/com/android/settings/core/SubSettingLauncherTest.java @@ -28,14 +28,12 @@ import static org.mockito.Mockito.when; import android.content.Context; import android.content.Intent; -import android.os.Bundle; import android.os.UserHandle; import androidx.fragment.app.Fragment; import androidx.fragment.app.FragmentActivity; import com.android.settings.SettingsActivity; -import com.android.settings.testutils.shadow.ShadowUtils; import com.android.settingslib.core.instrumentation.MetricsFeatureProvider; import com.android.settingslib.transition.SettingsTransitionHelper; @@ -45,7 +43,6 @@ import org.junit.runner.RunWith; import org.mockito.ArgumentCaptor; import org.mockito.Mock; import org.mockito.MockitoAnnotations; -import org.robolectric.annotation.Config; import org.robolectric.RobolectricTestRunner; import org.robolectric.RuntimeEnvironment; diff --git a/tests/robotests/src/com/android/settings/display/ScreenTimeoutSettingsTest.java b/tests/robotests/src/com/android/settings/display/ScreenTimeoutSettingsTest.java index abb616a5e3e..41e442997cf 100644 --- a/tests/robotests/src/com/android/settings/display/ScreenTimeoutSettingsTest.java +++ b/tests/robotests/src/com/android/settings/display/ScreenTimeoutSettingsTest.java @@ -22,16 +22,24 @@ import static androidx.test.core.app.ApplicationProvider.getApplicationContext; import static com.google.common.truth.Truth.assertThat; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyInt; +import static org.mockito.ArgumentMatchers.isA; import static org.mockito.Mockito.atLeast; import static org.mockito.Mockito.doNothing; import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.never; import static org.mockito.Mockito.spy; import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; import android.app.admin.DevicePolicyManager; import android.content.ContentResolver; import android.content.Context; +import android.content.Intent; +import android.content.pm.PackageManager; +import android.content.pm.ResolveInfo; +import android.content.pm.ServiceInfo; import android.content.res.Resources; import android.provider.SearchIndexableResource; import android.provider.Settings; @@ -80,6 +88,9 @@ public class ScreenTimeoutSettingsTest { @Mock Preference mDisableOptionsPreference; + @Mock + private PackageManager mPackageManager; + @Before public void setup() { MockitoAnnotations.initMocks(this); @@ -90,6 +101,15 @@ public class ScreenTimeoutSettingsTest { mContentResolver = mContext.getContentResolver(); mResources = spy(mContext.getResources()); + doReturn(mPackageManager).when(mContext).getPackageManager(); + when(mPackageManager.getAttentionServicePackageName()).thenReturn("some.package"); + when(mPackageManager.checkPermission(any(), any())).thenReturn( + PackageManager.PERMISSION_GRANTED); + final ResolveInfo attentionServiceResolveInfo = new ResolveInfo(); + attentionServiceResolveInfo.serviceInfo = new ServiceInfo(); + when(mPackageManager.resolveService(isA(Intent.class), anyInt())).thenReturn( + attentionServiceResolveInfo); + doReturn(TIMEOUT_ENTRIES).when(mResources).getStringArray(R.array.screen_timeout_entries); doReturn(TIMEOUT_VALUES).when(mResources).getStringArray(R.array.screen_timeout_entries); doReturn(true).when(mResources).getBoolean( @@ -147,6 +167,13 @@ public class ScreenTimeoutSettingsTest { verify(mSettings.mAdaptiveSleepController, never()).addToScreen(mPreferenceScreen); } + @Test + public void updateCandidates_AttentionServiceNotInstalled_doNoShowAdaptiveSleepPreference() { + when(mPackageManager.resolveService(isA(Intent.class), anyInt())).thenReturn(null); + + verify(mSettings.mAdaptiveSleepController, never()).addToScreen(mPreferenceScreen); + } + @Test public void updateCandidates_enforcedAdmin_showDisabledByAdminPreference() { mSettings.mAdmin = new RestrictedLockUtils.EnforcedAdmin(); diff --git a/tests/robotests/src/com/android/settings/testutils/shadow/ShadowUtils.java b/tests/robotests/src/com/android/settings/testutils/shadow/ShadowUtils.java index 7534edff9b6..40cb25bfb83 100644 --- a/tests/robotests/src/com/android/settings/testutils/shadow/ShadowUtils.java +++ b/tests/robotests/src/com/android/settings/testutils/shadow/ShadowUtils.java @@ -47,7 +47,6 @@ public class ShadowUtils { private static boolean sIsVoiceCapable; private static ArraySet sResultLinks = new ArraySet<>(); private static boolean sIsBatteryPresent; - private static boolean sIsPageTransitionEnabled; private static boolean sIsMultipleBiometricsSupported; @Implementation @@ -71,7 +70,6 @@ public class ShadowUtils { sIsVoiceCapable = false; sResultLinks = new ArraySet<>(); sIsBatteryPresent = true; - sIsPageTransitionEnabled = true; sIsMultipleBiometricsSupported = false; } @@ -171,15 +169,6 @@ public class ShadowUtils { sIsBatteryPresent = isBatteryPresent; } - @Implementation - protected static boolean isPageTransitionEnabled(Context context) { - return sIsPageTransitionEnabled; - } - - public static void setIsPageTransitionEnabled(boolean isPageTransitionEnabled) { - sIsPageTransitionEnabled = isPageTransitionEnabled; - } - @Implementation protected static boolean isMultipleBiometricsSupported(Context context) { return sIsMultipleBiometricsSupported; diff --git a/tests/unit/src/com/android/settings/panel/InternetConnectivityPanelTest.java b/tests/unit/src/com/android/settings/panel/InternetConnectivityPanelTest.java index 837cf7af547..c13d368d2f7 100644 --- a/tests/unit/src/com/android/settings/panel/InternetConnectivityPanelTest.java +++ b/tests/unit/src/com/android/settings/panel/InternetConnectivityPanelTest.java @@ -255,8 +255,8 @@ public class InternetConnectivityPanelTest { } @Test - public void getSeeMoreIntent_shouldBeNull() { - assertThat(mPanel.getSeeMoreIntent()).isNull(); + public void getSeeMoreIntent_shouldNotNull() { + assertThat(mPanel.getSeeMoreIntent()).isNotNull(); } @Test