[Settings] Code refactor

Minor code refactor

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: I060e7c880d91a0e5059610c5ceae319d47c19c7a
This commit is contained in:
Bonian Chen
2020-04-20 20:11:51 +08:00
parent 12a838d1f6
commit 9bc2f7f8bc

View File

@@ -44,25 +44,25 @@ public class DataUsagePreferenceController extends TelephonyBasePreferenceContro
@Override
public int getAvailabilityStatus(int subId) {
return subId != SubscriptionManager.INVALID_SUBSCRIPTION_ID
return (SubscriptionManager.isValidSubscriptionId(subId))
? AVAILABLE
: AVAILABLE_UNSEARCHABLE;
}
@Override
public boolean handlePreferenceTreeClick(Preference preference) {
if (TextUtils.equals(preference.getKey(), getPreferenceKey())) {
mContext.startActivity(mIntent);
return true;
if (!TextUtils.equals(preference.getKey(), getPreferenceKey())) {
return false;
}
return false;
mContext.startActivity(mIntent);
return true;
}
@Override
public void updateState(Preference preference) {
super.updateState(preference);
if (mSubId == SubscriptionManager.INVALID_SUBSCRIPTION_ID) {
if (!SubscriptionManager.isValidSubscriptionId(mSubId)) {
preference.setEnabled(false);
return;
}