Remove no-op handlePerferenceTreeClick from PrefControllers

Bug: 33429853
Test: RunSettingsRoboTests
Change-Id: I5633953e3d7b07f9006e541b96a24a2a769e2686

src/com/android/settings/accounts/AccountPreferenceController.java

@@ -146,11 +146,6 @@ public class AccountPreferenceController extends PreferenceController
         return !mUm.isManagedProfile();
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public String getPreferenceKey() {
         return null;

src/com/android/settings/accounts/AddUserWhenLockedPreferenceController.java

@@ -70,11 +70,6 @@ public class AddUserWhenLockedPreferenceController extends PreferenceController
         }
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public boolean isAvailable() {
         return mUserCaps.isAdmin() &&

src/com/android/settings/connecteddevice/UsbModePreferenceController.java

@@ -57,11 +57,6 @@ public class UsbModePreferenceController extends PreferenceController
         updataSummary(preference);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public boolean isAvailable() {
         return true;

src/com/android/settings/core/PreferenceController.java

@@ -18,6 +18,7 @@ package com.android.settings.core;
 import android.content.Context;
 import android.support.v7.preference.Preference;
 import android.support.v7.preference.PreferenceScreen;
+
 import com.android.settings.search.SearchIndexableRaw;
 
 import java.util.List;
@@ -27,7 +28,7 @@ import java.util.List;
  */
 public abstract class PreferenceController {
 
-    protected Context mContext;
+    protected final Context mContext;
 
     public PreferenceController(Context context) {
         mContext = context;
@@ -85,7 +86,9 @@ public abstract class PreferenceController {
      * @param preference the preference being clicked
      * @return true if click is handled
      */
-    public abstract boolean handlePreferenceTreeClick(Preference preference);
+    public boolean handlePreferenceTreeClick(Preference preference) {
+        return false;
+    }
 
     /**
      * Returns the key for this preference.

src/com/android/settings/dashboard/DashboardTilePlaceholderPreferenceController.java

@@ -52,11 +52,6 @@ class DashboardTilePlaceholderPreferenceController extends PreferenceController
         return false;
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public String getPreferenceKey() {
         return KEY_PLACEHOLDER;

src/com/android/settings/datetime/AutoTimePreferenceController.java

@@ -40,11 +40,6 @@ public class AutoTimePreferenceController extends PreferenceController
         return true;
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public void updateState(Preference preference) {
         if (!(preference instanceof RestrictedSwitchPreference)) {

src/com/android/settings/datetime/AutoTimeZonePreferenceController.java

@@ -44,11 +44,6 @@ public class AutoTimeZonePreferenceController extends PreferenceController
         return !(Utils.isWifiOnly(mContext) || mIsFromSUW);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public String getPreferenceKey() {
         return KEY_AUTO_TIME_ZONE;

src/com/android/settings/datetime/TimeZonePreferenceController.java

@@ -48,11 +48,6 @@ public class TimeZonePreferenceController extends PreferenceController {
         return true;
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public String getPreferenceKey() {
         return KEY_TIMEZONE;

src/com/android/settings/deviceinfo/AdditionalSystemUpdatePreferenceController.java

@@ -28,11 +28,6 @@ public class AdditionalSystemUpdatePreferenceController extends PreferenceContro
         super(context);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public boolean isAvailable() {
         return mContext.getResources().getBoolean(

src/com/android/settings/deviceinfo/ManageStoragePreferenceController.java

@@ -34,11 +34,6 @@ public class ManageStoragePreferenceController extends PreferenceController {
         return KEY_MANAGE_STORAGE;
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public boolean isAvailable() {
         return mContext.getResources().getBoolean(R.bool.config_storage_manager_settings_enabled);

src/com/android/settings/deviceinfo/SerialNumberPreferenceController.java

@@ -55,11 +55,6 @@ public class SerialNumberPreferenceController extends PreferenceController {
         }
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public String getPreferenceKey() {
         return KEY_SERIAL_NUMBER;

src/com/android/settings/display/AutoBrightnessPreferenceController.java

@@ -45,11 +45,6 @@ public class AutoBrightnessPreferenceController extends PreferenceController imp
         return KEY_AUTO_BRIGHTNESS;
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public void updateState(Preference preference) {
         int brightnessMode = Settings.System.getInt(mContext.getContentResolver(),

src/com/android/settings/display/AutoRotatePreferenceController.java

@@ -67,11 +67,6 @@ public class AutoRotatePreferenceController extends PreferenceController impleme
                 1 : 0);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public boolean isAvailable() {
         return RotationPolicy.isRotationLockToggleVisible(mContext);

src/com/android/settings/display/CameraGesturePreferenceController.java

@@ -37,11 +37,6 @@ public class CameraGesturePreferenceController extends PreferenceController impl
         return KEY_CAMERA_GESTURE;
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public void updateState(Preference preference) {
         int value = Settings.Secure.getInt(mContext.getContentResolver(),

src/com/android/settings/display/FontSizePreferenceController.java

@@ -51,9 +51,4 @@ public class FontSizePreferenceController extends PreferenceController {
                 strEntryValues);
         preference.setSummary(entries[index]);
     }
-
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
 }

src/com/android/settings/display/LiftToWakePreferenceController.java

@@ -44,11 +44,6 @@ public class LiftToWakePreferenceController extends PreferenceController impleme
         return KEY_LIFT_TO_WAKE;
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public boolean onPreferenceChange(Preference preference, Object newValue) {
         boolean value = (Boolean) newValue;

src/com/android/settings/display/NightDisplayPreferenceController.java

@@ -27,11 +27,6 @@ public class NightDisplayPreferenceController extends PreferenceController {
         super(context);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public boolean isAvailable() {
         return NightDisplayController.isAvailable(mContext);

src/com/android/settings/display/NightModePreferenceController.java

@@ -61,11 +61,6 @@ public class NightModePreferenceController extends PreferenceController
         }
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public boolean onPreferenceChange(Preference preference, Object newValue) {
         try {

src/com/android/settings/display/ScreenSaverPreferenceController.java

@@ -38,11 +38,6 @@ public class ScreenSaverPreferenceController extends PreferenceController {
         return KEY_SCREEN_SAVER;
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public void updateState(Preference preference) {
         preference.setSummary(DreamSettings.getSummaryTextWithDreamName(mContext));

src/com/android/settings/display/TapToWakePreferenceController.java

@@ -40,11 +40,6 @@ public class TapToWakePreferenceController extends PreferenceController implemen
                 com.android.internal.R.bool.config_supportDoubleTapWake);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public void updateState(Preference preference) {
         int value = Settings.Secure.getInt(

src/com/android/settings/display/TimeoutPreferenceController.java

@@ -51,11 +51,6 @@ public class TimeoutPreferenceController extends PreferenceController implements
         return KEY_SCREEN_TIMEOUT;
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public void updateState(Preference preference) {
         final TimeoutListPreference timeoutListPreference = (TimeoutListPreference) preference;

src/com/android/settings/display/VrDisplayPreferenceController.java

@@ -74,9 +74,4 @@ public class VrDisplayPreferenceController extends PreferenceController implemen
         }
         return true;
     }
-
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
 }

src/com/android/settings/display/WallpaperPreferenceController.java

@@ -46,11 +46,6 @@ public class WallpaperPreferenceController extends PreferenceController {
         disablePreferenceIfManaged((RestrictedPreference) preference);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     private void disablePreferenceIfManaged(RestrictedPreference pref) {
         final String restriction = DISALLOW_SET_WALLPAPER;
         if (pref != null) {

src/com/android/settings/enterprise/AdminActionPreferenceControllerBase.java

@@ -50,9 +50,4 @@ public abstract class AdminActionPreferenceControllerBase extends PreferenceCont
     public boolean isAvailable() {
         return true;
     }
-
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
 }

src/com/android/settings/enterprise/InstalledPackagesPreferenceController.java

@@ -50,11 +50,6 @@ public class InstalledPackagesPreferenceController extends PreferenceController
         return true;
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public String getPreferenceKey() {
         return KEY_NUMBER_INSTALLED_PACKAGES;

src/com/android/settings/gestures/GesturePreferenceController.java

@@ -64,11 +64,6 @@ public abstract class GesturePreferenceController extends PreferenceController
         }
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public void onStop() {
         if (mVideoPreference != null) {

src/com/android/settings/gestures/SwipeToNotificationPreferenceController.java

@@ -31,11 +31,6 @@ public class SwipeToNotificationPreferenceController extends GesturePreferenceCo
         super(context, lifecycle);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public String getPreferenceKey() {
         return PREF_KEY_SWIPE_DOWN_FINGERPRINT;

src/com/android/settings/inputmethod/SpellCheckerPreferenceController.java

@@ -51,11 +51,6 @@ public class SpellCheckerPreferenceController extends PreferenceController {
         return true;
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public String getPreferenceKey() {
         return KEY_SPELL_CHECKERS;

src/com/android/settings/language/PhoneLanguagePreferenceController.java

@@ -35,11 +35,6 @@ public class PhoneLanguagePreferenceController extends PreferenceController {
         return mContext.getAssets().getLocales().length > 1;
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public void updateState(Preference preference) {
         if (preference == null) {

src/com/android/settings/language/TtsPreferenceController.java

@@ -48,11 +48,6 @@ public class TtsPreferenceController extends PreferenceController {
         }
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public String getPreferenceKey() {
         return KEY_TTS_SETTINGS;

src/com/android/settings/language/UserDictionaryPreferenceController.java

@@ -43,11 +43,6 @@ public class UserDictionaryPreferenceController extends PreferenceController {
         return localeSet != null;
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public String getPreferenceKey() {
         return KEY_USER_DICTIONARY_SETTINGS;

src/com/android/settings/network/MobileNetworkPreferenceController.java

@@ -39,11 +39,6 @@ public class MobileNetworkPreferenceController extends PreferenceController {
         mIsSecondaryUser = !mUserManager.isAdminUser();
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public boolean isAvailable() {
         return !mIsSecondaryUser

src/com/android/settings/network/NetworkResetPreferenceController.java

@@ -31,11 +31,6 @@ public class NetworkResetPreferenceController extends PreferenceController {
         super(context);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public boolean isAvailable() {
         return !RestrictedLockUtils.hasBaseUserRestriction(mContext,

src/com/android/settings/network/ProxyPreferenceController.java

@@ -30,11 +30,6 @@ public class ProxyPreferenceController extends PreferenceController {
         super(context);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public boolean isAvailable() {
         // proxy UI disabled until we have better app support

src/com/android/settings/network/TetherPreferenceController.java

@@ -48,11 +48,6 @@ public class TetherPreferenceController extends PreferenceController {
         mUserManager = (UserManager) context.getSystemService(Context.USER_SERVICE);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public void displayPreference(PreferenceScreen screen) {
         super.displayPreference(screen);

src/com/android/settings/network/VpnPreferenceController.java

@@ -40,11 +40,6 @@ public class VpnPreferenceController extends PreferenceController {
         mIsSecondaryUser = !UserManager.get(context).isAdminUser();
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public void displayPreference(PreferenceScreen screen) {
         super.displayPreference(screen);

src/com/android/settings/network/WifiCallingPreferenceController.java

@@ -34,11 +34,6 @@ public class WifiCallingPreferenceController extends PreferenceController {
         mTm = (TelephonyManager) context.getSystemService(Context.TELEPHONY_SERVICE);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public void displayPreference(PreferenceScreen screen) {
         super.displayPreference(screen);

src/com/android/settings/nfc/NfcPreferenceController.java

@@ -95,11 +95,6 @@ public class NfcPreferenceController extends PreferenceController
         }
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public boolean isAvailable() {
         return mNfcAdapter != null;

src/com/android/settings/notification/CastPreferenceController.java

@@ -31,11 +31,6 @@ public class CastPreferenceController extends PreferenceController {
         super(context);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public String getPreferenceKey() {
         return KEY_WIFI_DISPLAY;

src/com/android/settings/notification/LockScreenNotificationPreferenceController.java

@@ -75,11 +75,6 @@ public class LockScreenNotificationPreferenceController extends PreferenceContro
                 && (utils.isSecure(mProfileChallengeUserId) || (isUnified && mSecure));
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public void displayPreference(PreferenceScreen screen) {
         super.displayPreference(screen);

src/com/android/settings/notification/PulseNotificationPreferenceController.java

@@ -68,11 +68,6 @@ public class PulseNotificationPreferenceController extends PreferenceController
         }
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public String getPreferenceKey() {
         return KEY_NOTIFICATION_PULSE;

src/com/android/settings/notification/VolumeSeekBarPreferenceController.java

@@ -17,8 +17,6 @@
 package com.android.settings.notification;
 
 import android.content.Context;
-
-import android.support.v7.preference.Preference;
 import android.support.v7.preference.PreferenceScreen;
 
 import com.android.settings.core.lifecycle.Lifecycle;
@@ -70,11 +68,6 @@ public abstract class VolumeSeekBarPreferenceController extends
         }
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     protected abstract int getAudioStream();
 
     protected abstract int getMuteIcon();

src/com/android/settings/notification/ZenModePreferenceController.java

@@ -17,7 +17,6 @@
 package com.android.settings.notification;
 
 import android.content.Context;
-import android.support.v7.preference.Preference;
 
 public class ZenModePreferenceController extends AdjustVolumeRestrictedPreferenceController {
 
@@ -27,11 +26,6 @@ public class ZenModePreferenceController extends AdjustVolumeRestrictedPreferenc
         super(context);
     }
 
-    @Override
-    public boolean handlePreferenceTreeClick(Preference preference) {
-        return false;
-    }
-
     @Override
     public String getPreferenceKey() {
         return KEY_ZEN_MODE;