From a93b1b6175bfa940be50832c3c8b6109e1f4d3b6 Mon Sep 17 00:00:00 2001 From: Rajeev Kumar Date: Thu, 6 Jul 2017 16:01:06 -0700 Subject: [PATCH] Recycle TypedArray in DividerPreference.java 1. Make sure 'TypedArray' is recycled after use with '#recycle()' in DividerPreference.java class 2. Get rid of an unused import from DividerPreference.java class Test: make RunSettingsRoboTests -j40 Change-Id: I3baf7d51b5112583b9605fc6ec0c81f40ba76ee9 --- src/com/android/settings/DividerPreference.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/DividerPreference.java b/src/com/android/settings/DividerPreference.java index a9710915984..aec7d44829f 100644 --- a/src/com/android/settings/DividerPreference.java +++ b/src/com/android/settings/DividerPreference.java @@ -19,8 +19,8 @@ import android.content.res.TypedArray; import android.support.v7.preference.Preference; import android.support.v7.preference.PreferenceViewHolder; import android.util.AttributeSet; -import android.widget.TextView; +@Deprecated public class DividerPreference extends Preference { private Boolean mAllowAbove; @@ -35,10 +35,11 @@ public class DividerPreference extends Preference { if (a.hasValue(R.styleable.DividerPreference_allowDividerBelow)) { mAllowBelow = a.getBoolean(R.styleable.DividerPreference_allowDividerBelow, false); } + a.recycle(); } public DividerPreference(Context context) { - this(context, null); + this(context, null /* attrs */); } public void setDividerAllowedAbove(boolean allowed) {