Provide icon for catalyst screens

Bug: 335132588
Flag: EXEMPT N/A
Test: Manual
Change-Id: I520529c3bf4a7db01889d08683f55b0efb21eae4
This commit is contained in:
Jacky Wang
2024-10-16 23:00:43 +08:00
parent 2f80653aab
commit 9b62ec9616
3 changed files with 24 additions and 5 deletions

View File

@@ -20,18 +20,26 @@ import com.android.settings.DisplaySettings
import com.android.settings.R import com.android.settings.R
import com.android.settings.flags.Flags import com.android.settings.flags.Flags
import com.android.settingslib.metadata.PreferenceAvailabilityProvider import com.android.settingslib.metadata.PreferenceAvailabilityProvider
import com.android.settingslib.metadata.PreferenceIconProvider
import com.android.settingslib.metadata.ProvidePreferenceScreen import com.android.settingslib.metadata.ProvidePreferenceScreen
import com.android.settingslib.metadata.preferenceHierarchy import com.android.settingslib.metadata.preferenceHierarchy
import com.android.settingslib.preference.PreferenceScreenCreator import com.android.settingslib.preference.PreferenceScreenCreator
@ProvidePreferenceScreen @ProvidePreferenceScreen
class DisplayScreen : PreferenceScreenCreator, PreferenceAvailabilityProvider { class DisplayScreen :
PreferenceScreenCreator, PreferenceAvailabilityProvider, PreferenceIconProvider {
override val key: String override val key: String
get() = KEY get() = KEY
override val title: Int override val title: Int
get() = R.string.display_settings get() = R.string.display_settings
override fun getIcon(context: Context) =
when {
Flags.homepageRevamp() -> R.drawable.ic_settings_display_filled
else -> R.drawable.ic_settings_display_white
}
override fun isFlagEnabled(context: Context) = Flags.catalystDisplaySettingsScreen() override fun isFlagEnabled(context: Context) = Flags.catalystDisplaySettingsScreen()
override fun hasCompleteHierarchy() = false override fun hasCompleteHierarchy() = false

View File

@@ -18,20 +18,24 @@ package com.android.settings.network
import android.content.Context import android.content.Context
import com.android.settings.R import com.android.settings.R
import com.android.settings.flags.Flags import com.android.settings.flags.Flags
import com.android.settingslib.metadata.PreferenceIconProvider
import com.android.settingslib.metadata.ProvidePreferenceScreen import com.android.settingslib.metadata.ProvidePreferenceScreen
import com.android.settingslib.metadata.preferenceHierarchy import com.android.settingslib.metadata.preferenceHierarchy
import com.android.settingslib.preference.PreferenceScreenCreator import com.android.settingslib.preference.PreferenceScreenCreator
@ProvidePreferenceScreen @ProvidePreferenceScreen
class NetworkDashboardScreen : PreferenceScreenCreator { class NetworkDashboardScreen : PreferenceScreenCreator, PreferenceIconProvider {
override val key: String override val key: String
get() = KEY get() = KEY
override val title: Int override val title: Int
get() = R.string.network_dashboard_title get() = R.string.network_dashboard_title
override val icon: Int override fun getIcon(context: Context) =
get() = R.drawable.ic_settings_wireless_filled when {
Flags.homepageRevamp() -> R.drawable.ic_settings_wireless_filled
else -> R.drawable.ic_settings_wireless
}
override fun isFlagEnabled(context: Context) = Flags.catalystNetworkProviderAndInternetScreen() override fun isFlagEnabled(context: Context) = Flags.catalystNetworkProviderAndInternetScreen()

View File

@@ -19,12 +19,13 @@ import android.content.Context
import androidx.fragment.app.Fragment import androidx.fragment.app.Fragment
import com.android.settings.R import com.android.settings.R
import com.android.settings.flags.Flags import com.android.settings.flags.Flags
import com.android.settingslib.metadata.PreferenceIconProvider
import com.android.settingslib.metadata.ProvidePreferenceScreen import com.android.settingslib.metadata.ProvidePreferenceScreen
import com.android.settingslib.metadata.preferenceHierarchy import com.android.settingslib.metadata.preferenceHierarchy
import com.android.settingslib.preference.PreferenceScreenCreator import com.android.settingslib.preference.PreferenceScreenCreator
@ProvidePreferenceScreen @ProvidePreferenceScreen
class SoundScreen : PreferenceScreenCreator { class SoundScreen : PreferenceScreenCreator, PreferenceIconProvider {
override val key: String override val key: String
get() = KEY get() = KEY
@@ -34,6 +35,12 @@ class SoundScreen : PreferenceScreenCreator {
override val keywords: Int override val keywords: Int
get() = R.string.keywords_sounds get() = R.string.keywords_sounds
override fun getIcon(context: Context) =
when {
Flags.homepageRevamp() -> R.drawable.ic_volume_up_filled
else -> R.drawable.ic_volume_up_24dp
}
override fun isFlagEnabled(context: Context): Boolean = Flags.catalystSoundScreen() override fun isFlagEnabled(context: Context): Boolean = Flags.catalystSoundScreen()
override fun hasCompleteHierarchy() = false override fun hasCompleteHierarchy() = false