Fix unresponsive UI during scan and display of "No Bluetooth devices"
- When there are no available Bluetooth devices, we show "No Bluetooth devices were found nearby" as a preference item after the scan completes. Update the layout for this Preference item so that the text is centered and doesn't highlight when touched. - Fix slow responsiveness on scanning caused by repeated removal of "No Bluetooth devices were found" preference item on every call to onBindView(). - If no devices are paired, don't restart the scan on every rotation. Bug: 5173935 Bug: 5055460 Change-Id: I52fb2d52f315c5e793f08499146842d54c5c3ead
This commit is contained in:
@@ -26,12 +26,13 @@ public class ProgressCategory extends ProgressCategoryBase {
|
||||
|
||||
private boolean mProgress = false;
|
||||
private Preference mNoDeviceFoundPreference;
|
||||
private boolean mNoDeviceFoundAdded;
|
||||
|
||||
public ProgressCategory(Context context, AttributeSet attrs) {
|
||||
super(context, attrs);
|
||||
setLayoutResource(R.layout.preference_progress_category);
|
||||
}
|
||||
|
||||
|
||||
@Override
|
||||
public void onBindView(View view) {
|
||||
super.onBindView(view);
|
||||
@@ -39,21 +40,26 @@ public class ProgressCategory extends ProgressCategoryBase {
|
||||
final View progressBar = view.findViewById(R.id.scanning_progress);
|
||||
|
||||
textView.setText(mProgress ? R.string.progress_scanning : R.string.progress_tap_to_pair);
|
||||
boolean noDeviceFound = getPreferenceCount() == 0;
|
||||
boolean noDeviceFound = (getPreferenceCount() == 0 ||
|
||||
(getPreferenceCount() == 1 && getPreference(0) == mNoDeviceFoundPreference));
|
||||
textView.setVisibility(noDeviceFound ? View.INVISIBLE : View.VISIBLE);
|
||||
progressBar.setVisibility(mProgress ? View.VISIBLE : View.INVISIBLE);
|
||||
|
||||
if (mProgress) {
|
||||
if (mNoDeviceFoundPreference != null) {
|
||||
if (mNoDeviceFoundAdded) {
|
||||
removePreference(mNoDeviceFoundPreference);
|
||||
mNoDeviceFoundAdded = false;
|
||||
}
|
||||
} else {
|
||||
if (noDeviceFound) {
|
||||
if (noDeviceFound && !mNoDeviceFoundAdded) {
|
||||
if (mNoDeviceFoundPreference == null) {
|
||||
mNoDeviceFoundPreference = new Preference(getContext());
|
||||
mNoDeviceFoundPreference.setSummary(R.string.bluetooth_no_devices_found);
|
||||
mNoDeviceFoundPreference.setLayoutResource(R.layout.preference_empty_list);
|
||||
mNoDeviceFoundPreference.setTitle(R.string.bluetooth_no_devices_found);
|
||||
mNoDeviceFoundPreference.setSelectable(false);
|
||||
}
|
||||
addPreference(mNoDeviceFoundPreference);
|
||||
mNoDeviceFoundAdded = true;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user