From 998933a44d9f48bd09748e9973ec86c225444a84 Mon Sep 17 00:00:00 2001
From: Allen Su <allenwtsu@google.com>
Date: Thu, 18 May 2023 10:27:52 +0000
Subject: [PATCH] Fix dialog disappear when screen off and on

Bug: 248514263
Test: by manual
Change-Id: Ieac71f57b8672204dd2bc6c1c39e473d0ffa25cf
---
 .../localepicker/LocaleListEditor.java        | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/com/android/settings/localepicker/LocaleListEditor.java b/src/com/android/settings/localepicker/LocaleListEditor.java
index 1b311ea2b4f..b2c64babd20 100644
--- a/src/com/android/settings/localepicker/LocaleListEditor.java
+++ b/src/com/android/settings/localepicker/LocaleListEditor.java
@@ -149,14 +149,6 @@ public class LocaleListEditor extends RestrictedSettingsFragment implements View
         }
     }
 
-    @Override
-    public void onStop() {
-        super.onStop();
-        if (mSuggestionDialog != null) {
-            mSuggestionDialog.dismiss();
-        }
-    }
-
     @Override
     public void onViewStateRestored(Bundle savedInstanceState) {
         super.onViewStateRestored(savedInstanceState);
@@ -246,6 +238,14 @@ public class LocaleListEditor extends RestrictedSettingsFragment implements View
         super.onActivityResult(requestCode, resultCode, data);
     }
 
+    @Override
+    public void onDestroy() {
+        super.onDestroy();
+        if (mSuggestionDialog != null) {
+            mSuggestionDialog.dismiss();
+        }
+    }
+
     @VisibleForTesting
     static LocaleStore.LocaleInfo mayAppendUnicodeTags(
             LocaleStore.LocaleInfo localeInfo, String recordTags) {
@@ -290,8 +290,8 @@ public class LocaleListEditor extends RestrictedSettingsFragment implements View
     private boolean isAllowedPackage() {
         List<String> allowList = Arrays.asList(getContext().getResources().getStringArray(
                 R.array.allowed_packages_for_locale_confirmation_diallog));
-        String callingPckage = getActivity().getCallingPackage();
-        return !isNullOrEmpty(callingPckage) && allowList.contains(callingPckage);
+        String callingPackage = getActivity().getCallingPackage();
+        return !isNullOrEmpty(callingPackage) && allowList.contains(callingPackage);
     }
 
     private static boolean isNullOrEmpty(String str) {