From 9938dc8337f12d3db0ce5829ce95ffa62477b1b7 Mon Sep 17 00:00:00 2001 From: Fan Zhang Date: Wed, 17 May 2017 17:01:44 -0700 Subject: [PATCH] Log preference change as count (in addition to action) Bug: 38258793 Test: rerun robotests, and inspected log Change-Id: I23fabddc1336709af424bbcb7250535833a8ada6 --- .../settings/core/instrumentation/SharedPreferencesLogger.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/com/android/settings/core/instrumentation/SharedPreferencesLogger.java b/src/com/android/settings/core/instrumentation/SharedPreferencesLogger.java index 69f174b2a27..d1c7c7a33d1 100644 --- a/src/com/android/settings/core/instrumentation/SharedPreferencesLogger.java +++ b/src/com/android/settings/core/instrumentation/SharedPreferencesLogger.java @@ -111,6 +111,9 @@ public class SharedPreferencesLogger implements SharedPreferences { mPreferenceKeySet.add(prefKey); return; } + // TODO: Remove count logging to save some resource. + mMetricsFeature.count(mContext, prefKey + "|" + value, 1); + // Pref key exists in set, log it's change in metrics. mMetricsFeature.action(mContext, MetricsEvent.ACTION_SETTINGS_PREFERENCE_CHANGE, Pair.create(MetricsEvent.FIELD_SETTINGS_PREFERENCE_CHANGE_NAME, prefKey),