Use ThreadUtils instead of AsyncTask to get app title/icon

Change-Id: I44459d9e4a11329a3bd3bfda5057e05eb7e04d6a Fixes: 63620905 Test: robotest
2017-08-09 16:18:15 -07:00
parent e3ca685321
commit 97e535b603
2 changed files with 112 additions and 60 deletions
--- a/tests/robotests/src/com/android/settings/datausage/AppDataUsagePreferenceTest.java
+++ b/tests/robotests/src/com/android/settings/datausage/AppDataUsagePreferenceTest.java
@@ -0,0 +1,86 @@
+/*
+ * Copyright (C) 2017 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.android.settings.datausage;
+
+
+import static com.google.common.truth.Truth.assertThat;
+import static org.mockito.Mockito.when;
+
+import android.graphics.Color;
+import android.graphics.drawable.ColorDrawable;
+
+import com.android.settings.TestConfig;
+import com.android.settings.testutils.SettingsRobolectricTestRunner;
+import com.android.settings.testutils.shadow.ShadowThreadUtils;
+import com.android.settingslib.AppItem;
+import com.android.settingslib.net.UidDetail;
+import com.android.settingslib.net.UidDetailProvider;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.robolectric.RuntimeEnvironment;
+import org.robolectric.annotation.Config;
+
+@RunWith(SettingsRobolectricTestRunner.class)
+@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION,
+        shadows = ShadowThreadUtils.class)
+public class AppDataUsagePreferenceTest {
+
+    @Mock
+    private UidDetailProvider mUidDetailProvider;
+    private AppItem mAppItem;
+    private UidDetail mUidDetail;
+
+    private AppDataUsagePreference mPreference;
+
+    @Before
+    public void setUp() {
+        MockitoAnnotations.initMocks(this);
+        mAppItem = new AppItem(123);
+        mUidDetail = new UidDetail();
+        mUidDetail.icon = new ColorDrawable(Color.BLUE);
+        mUidDetail.label = "title";
+    }
+
+    @Test
+    public void createPref_hasCachedUidDetail_shouldSetAppInfo() {
+        when(mUidDetailProvider.getUidDetail(mAppItem.key, false /* blocking */))
+                .thenReturn(mUidDetail);
+
+        mPreference = new AppDataUsagePreference(RuntimeEnvironment.application, mAppItem,
+                50 /* percent */, mUidDetailProvider);
+
+        assertThat(mPreference.getTitle()).isEqualTo(mUidDetail.label);
+        assertThat(mPreference.getIcon()).isEqualTo(mUidDetail.icon);
+    }
+
+
+    @Test
+    public void createPref_noCachedUidDetail_shouldSetAppInfo() {
+        when(mUidDetailProvider.getUidDetail(mAppItem.key, true /* blocking */))
+                .thenReturn(mUidDetail);
+
+        mPreference = new AppDataUsagePreference(RuntimeEnvironment.application, mAppItem,
+                50 /* percent */, mUidDetailProvider);
+
+        assertThat(mPreference.getTitle()).isEqualTo(mUidDetail.label);
+        assertThat(mPreference.getIcon()).isEqualTo(mUidDetail.icon);
+    }
+}