From 9775dc9515e3e4bc2626544395041c3346d1fdc9 Mon Sep 17 00:00:00 2001
From: Irfan Sheriff <isheriff@google.com>
Date: Mon, 22 Mar 2010 12:23:30 -0700
Subject: [PATCH] Add password hint and fix settings crash

Bug: 2534348
Bug: 2533980
Change-Id: I2f220ac9c710869d3f93a56557afb33478c3b323
---
 res/layout/wifi_ap_dialog.xml                 |  7 +++++
 .../android/settings/wifi/WifiApSettings.java | 26 ++++++++++---------
 2 files changed, 21 insertions(+), 12 deletions(-)

diff --git a/res/layout/wifi_ap_dialog.xml b/res/layout/wifi_ap_dialog.xml
index f9c35b12a50..6d9691b0207 100644
--- a/res/layout/wifi_ap_dialog.xml
+++ b/res/layout/wifi_ap_dialog.xml
@@ -81,6 +81,13 @@
                     android:singleLine="true"
                     android:password="true" />
 
+            <TextView android:id="@+id/hint"
+                    android:layout_width="match_parent"
+                    android:layout_height="wrap_content"
+                    android:textSize="12sp"
+                    android:text="@string/credentials_password_too_short"
+                    android:layout_marginBottom="10sp"/>
+
             <CheckBox android:id="@+id/show_password"
                     style="?android:attr/textAppearanceSmallInverse"
                     android:layout_width="match_parent"
diff --git a/src/com/android/settings/wifi/WifiApSettings.java b/src/com/android/settings/wifi/WifiApSettings.java
index ec1016e9073..bca48351982 100644
--- a/src/com/android/settings/wifi/WifiApSettings.java
+++ b/src/com/android/settings/wifi/WifiApSettings.java
@@ -114,19 +114,21 @@ public class WifiApSettings extends PreferenceActivity
 
     public void onClick(DialogInterface dialogInterface, int button) {
 
-        mWifiConfig = mDialog.getConfig();
+        if (button == DialogInterface.BUTTON_POSITIVE) {
+            mWifiConfig = mDialog.getConfig();
+            if(mWifiConfig != null) {
+                mWifiManager.setWifiApEnabled(mWifiConfig, true);
+                mCreateNetwork.setSummary(String.format(getString(CONFIG_SUBTEXT),
+                            mWifiConfig.SSID,
+                            mWifiConfig.allowedKeyManagement.get(KeyMgmt.WPA_PSK) ?
+                            mSecurityType[WPA_INDEX] : mSecurityType[OPEN_INDEX]));
+                /**
+                 * There is no tether notification on changing AP
+                 * configuration. Update status with new config.
+                 */
+                mWifiApEnabler.updateConfigSummary(mWifiConfig);
 
-        if (button == DialogInterface.BUTTON_POSITIVE && mWifiConfig != null) {
-            mWifiManager.setWifiApEnabled(mWifiConfig, true);
-            mCreateNetwork.setSummary(String.format(getString(CONFIG_SUBTEXT),
-                                      mWifiConfig.SSID,
-                                      mWifiConfig.allowedKeyManagement.get(KeyMgmt.WPA_PSK) ?
-                                      mSecurityType[WPA_INDEX] : mSecurityType[OPEN_INDEX]));
-            /**
-             * There is no tether notification on changing AP
-             * configuration. Update status with new config.
-             */
-            mWifiApEnabler.updateConfigSummary(mWifiConfig);
+            }
         }
     }
 }