diff --git a/src/com/android/settings/DreamSettings.java b/src/com/android/settings/DreamSettings.java index 32328d9a7c9..23285c02874 100644 --- a/src/com/android/settings/DreamSettings.java +++ b/src/com/android/settings/DreamSettings.java @@ -316,7 +316,7 @@ public class DreamSettings extends SettingsPreferenceFragment { ImageView settingsButton = (ImageView) row.findViewById(android.R.id.button2); settingsButton.setVisibility(showSettings ? View.VISIBLE : View.INVISIBLE); - settingsButton.setAlpha(dreamInfo.isActive ? 1f : 0.33f); + settingsButton.setAlpha(dreamInfo.isActive ? 1f : Utils.DISABLED_ALPHA); settingsButton.setEnabled(dreamInfo.isActive); settingsButton.setOnClickListener(new OnClickListener(){ @Override diff --git a/src/com/android/settings/Utils.java b/src/com/android/settings/Utils.java index 6d76bede591..4b0a75381d1 100644 --- a/src/com/android/settings/Utils.java +++ b/src/com/android/settings/Utils.java @@ -79,6 +79,11 @@ public class Utils { */ public static final int UPDATE_PREFERENCE_FLAG_SET_TITLE_TO_MATCHING_ACTIVITY = 1; + /** + * The opacity level of a disabled icon. + */ + public static final float DISABLED_ALPHA = 0.4f; + /** * Name of the meta-data item that should be set in the AndroidManifest.xml * to specify the icon that should be displayed for the preference. diff --git a/src/com/android/settings/inputmethod/CheckBoxAndSettingsPreference.java b/src/com/android/settings/inputmethod/CheckBoxAndSettingsPreference.java index 28b8616ab19..f440bc842c0 100644 --- a/src/com/android/settings/inputmethod/CheckBoxAndSettingsPreference.java +++ b/src/com/android/settings/inputmethod/CheckBoxAndSettingsPreference.java @@ -18,6 +18,7 @@ package com.android.settings.inputmethod; import com.android.settings.R; import com.android.settings.SettingsPreferenceFragment; +import com.android.settings.Utils; import android.content.Context; import android.content.Intent; @@ -29,7 +30,6 @@ import android.widget.ImageView; import android.widget.TextView; public class CheckBoxAndSettingsPreference extends CheckBoxPreference { - private static final float DISABLED_ALPHA = 0.4f; private SettingsPreferenceFragment mFragment; private TextView mTitleText; @@ -103,7 +103,7 @@ public class CheckBoxAndSettingsPreference extends CheckBoxPreference { mSettingsButton.setClickable(checked); mSettingsButton.setFocusable(checked); if (!checked) { - mSettingsButton.setAlpha(DISABLED_ALPHA); + mSettingsButton.setAlpha(Utils.DISABLED_ALPHA); } } } diff --git a/src/com/android/settings/inputmethod/InputMethodPreference.java b/src/com/android/settings/inputmethod/InputMethodPreference.java index 103481e51c4..f064c08a2a3 100644 --- a/src/com/android/settings/inputmethod/InputMethodPreference.java +++ b/src/com/android/settings/inputmethod/InputMethodPreference.java @@ -18,6 +18,7 @@ package com.android.settings.inputmethod; import com.android.settings.R; import com.android.settings.SettingsPreferenceFragment; +import com.android.settings.Utils; import android.app.AlertDialog; import android.app.Fragment; @@ -47,7 +48,6 @@ import java.util.List; public class InputMethodPreference extends CheckBoxPreference implements Comparator { private static final String TAG = InputMethodPreference.class.getSimpleName(); - private static final float DISABLED_ALPHA = 0.4f; private final SettingsPreferenceFragment mFragment; private final InputMethodInfo mImi; private final InputMethodManager mImm; @@ -172,7 +172,7 @@ public class InputMethodPreference extends CheckBoxPreference mInputMethodSettingsButton.setClickable(checked); mInputMethodSettingsButton.setFocusable(checked); if (!checked) { - mInputMethodSettingsButton.setAlpha(DISABLED_ALPHA); + mInputMethodSettingsButton.setAlpha(Utils.DISABLED_ALPHA); } } if (mTitleText != null) { diff --git a/src/com/android/settings/inputmethod/SingleSpellCheckerPreference.java b/src/com/android/settings/inputmethod/SingleSpellCheckerPreference.java index 5b28142e3f1..5ea8bd74d92 100644 --- a/src/com/android/settings/inputmethod/SingleSpellCheckerPreference.java +++ b/src/com/android/settings/inputmethod/SingleSpellCheckerPreference.java @@ -17,6 +17,7 @@ package com.android.settings.inputmethod; import com.android.settings.R; +import com.android.settings.Utils; import android.app.AlertDialog; import android.content.ActivityNotFoundException; @@ -37,7 +38,6 @@ import android.widget.TextView; import android.widget.Toast; public class SingleSpellCheckerPreference extends Preference { - private static final float DISABLED_ALPHA = 0.4f; private static final String TAG = SingleSpellCheckerPreference.class.getSimpleName(); private static final boolean DBG = false; @@ -198,7 +198,7 @@ public class SingleSpellCheckerPreference extends Preference { mSettingsButton.setClickable(enabled); mSettingsButton.setFocusable(enabled); if (!enabled) { - mSettingsButton.setAlpha(DISABLED_ALPHA); + mSettingsButton.setAlpha(Utils.DISABLED_ALPHA); } } } @@ -210,7 +210,7 @@ public class SingleSpellCheckerPreference extends Preference { mSubtypeButton.setClickable(enabled); mSubtypeButton.setFocusable(enabled); if (!enabled) { - mSubtypeButton.setAlpha(DISABLED_ALPHA); + mSubtypeButton.setAlpha(Utils.DISABLED_ALPHA); } } } diff --git a/src/com/android/settings/tts/TtsEnginePreference.java b/src/com/android/settings/tts/TtsEnginePreference.java index 3d612f0644c..21ef81df865 100644 --- a/src/com/android/settings/tts/TtsEnginePreference.java +++ b/src/com/android/settings/tts/TtsEnginePreference.java @@ -30,6 +30,7 @@ import android.widget.RadioButton; import com.android.settings.R; +import com.android.settings.Utils; public class TtsEnginePreference extends Preference { @@ -136,6 +137,9 @@ public class TtsEnginePreference extends Preference { // Will be enabled only the engine has passed the voice check, and // is currently enabled. mSettingsIcon.setEnabled(isChecked && mVoiceCheckData != null); + if (!isChecked) { + mSettingsIcon.setAlpha(Utils.DISABLED_ALPHA); + } mSettingsIcon.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { @@ -169,7 +173,12 @@ public class TtsEnginePreference extends Preference { // case mSettingsIcon && mRadioButton will be null. In this case // getView will set the right values. if (mSettingsIcon != null && mRadioButton != null) { - mSettingsIcon.setEnabled(mRadioButton.isChecked()); + if (mRadioButton.isChecked()) { + mSettingsIcon.setEnabled(true); + } else { + mSettingsIcon.setEnabled(false); + mSettingsIcon.setAlpha(Utils.DISABLED_ALPHA); + } } }