From 9540e60083ff77ddc8a010247c9839021ebdbb7b Mon Sep 17 00:00:00 2001 From: Charlotte Lu Date: Thu, 17 Aug 2023 14:43:25 +0800 Subject: [PATCH] Java crash - AID_SYSTEM_USER - SimListDialogFragment.updateDialog - java.lang.NullPointerException. This error may be because onCreateDialog did not initialize mSubscriptions correctly, causing it to be null. java.lang.RuntimeException: java.lang.NullPointerException at com.android.settings.sim.SimListDialogFragment.updateDialog. Fix: 194175217 Test: Manual Test Change-Id: I761fed847441c6061ea4690658f06b9c2021bcee --- src/com/android/settings/sim/SimListDialogFragment.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/com/android/settings/sim/SimListDialogFragment.java b/src/com/android/settings/sim/SimListDialogFragment.java index 5b84d7b67c0..276321120f5 100644 --- a/src/com/android/settings/sim/SimListDialogFragment.java +++ b/src/com/android/settings/sim/SimListDialogFragment.java @@ -56,7 +56,8 @@ public class SimListDialogFragment extends SimDialogFragment { protected SelectSubscriptionAdapter mAdapter; @VisibleForTesting - List mSubscriptions; + @NonNull + List mSubscriptions = new ArrayList<>(); public static SimListDialogFragment newInstance(int dialogType, int titleResId, boolean includeAskEveryTime, boolean isCancelItemShowed) { @@ -71,8 +72,6 @@ public class SimListDialogFragment extends SimDialogFragment { @NonNull @Override public Dialog onCreateDialog(@Nullable Bundle savedInstanceState) { - mSubscriptions = new ArrayList<>(); - final AlertDialog.Builder builder = new AlertDialog.Builder(getContext()); View titleView = LayoutInflater.from(getContext()).inflate( R.layout.sim_confirm_dialog_title_multiple_enabled_profiles_supported, null);