From 546dd8724d1f84391aac7c59976a43996a4770ca Mon Sep 17 00:00:00 2001 From: Mill Chen Date: Tue, 22 Jun 2021 04:42:11 +0800 Subject: [PATCH] Suppress the action bar in SetupChooseLockGeneric The collapsing toolbar is introduced on S, which caused the Choose a screen lock page has two different header. This CL is to supress the collapsing toolbar from this page and also apply color extraction to the page. Bug: 190499041 Test: manual test Make sure there's no collapsing toolbar in the page. Change-Id: I8b7ea089bd9e9e7acdf0236099b1eb6270f0a816 --- res/drawable/ic_lock_pin.xml | 2 +- .../password/SetupChooseLockGeneric.java | 16 +++++++++------- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/res/drawable/ic_lock_pin.xml b/res/drawable/ic_lock_pin.xml index e1821f6ec8b..587f49cab5b 100644 --- a/res/drawable/ic_lock_pin.xml +++ b/res/drawable/ic_lock_pin.xml @@ -21,5 +21,5 @@ android:viewportHeight="24"> + android:fillColor="?android:attr/colorAccent"/> diff --git a/src/com/android/settings/password/SetupChooseLockGeneric.java b/src/com/android/settings/password/SetupChooseLockGeneric.java index 15a90e3fdbf..3261b81083b 100644 --- a/src/com/android/settings/password/SetupChooseLockGeneric.java +++ b/src/com/android/settings/password/SetupChooseLockGeneric.java @@ -23,7 +23,6 @@ import static com.android.settings.password.ChooseLockSettingsHelper.EXTRA_KEY_R import android.content.Context; import android.content.Intent; -import android.content.res.Resources; import android.os.Bundle; import android.os.IBinder; import android.os.UserHandle; @@ -43,6 +42,7 @@ import com.android.settings.SetupWizardUtils; import com.android.settings.utils.SettingsDividerItemDecoration; import com.google.android.setupdesign.GlifPreferenceLayout; +import com.google.android.setupdesign.util.ThemeHelper; /** * Setup Wizard's version of ChooseLockGeneric screen. It inherits the logic and basic structure @@ -66,14 +66,10 @@ public class SetupChooseLockGeneric extends ChooseLockGeneric { return SetupChooseLockGenericFragment.class; } - @Override - protected void onApplyThemeResource(Resources.Theme theme, int resid, boolean first) { - final int new_resid = SetupWizardUtils.getTheme(this, getIntent()); - super.onApplyThemeResource(theme, new_resid, first); - } - @Override protected void onCreate(Bundle savedInstance) { + setTheme(SetupWizardUtils.getTheme(this, getIntent())); + ThemeHelper.trySetDynamicColor(this); super.onCreate(savedInstance); if(getIntent().hasExtra(EXTRA_KEY_REQUESTED_MIN_COMPLEXITY)) { @@ -92,6 +88,12 @@ public class SetupChooseLockGeneric extends ChooseLockGeneric { findViewById(R.id.content_parent).setFitsSystemWindows(false); } + @Override + protected boolean isToolbarEnabled() { + // Hide the action bar from this page. + return false; + } + public static class SetupChooseLockGenericFragment extends ChooseLockGenericFragment { public static final String EXTRA_PASSWORD_QUALITY = ":settings:password_quality";