Micro cleanup and refactoring
- organize import - remove unused code in ContextualCardLoaderTest - refactor CardDatabaseHelper Test: robotest Change-Id: I1a5a49bee1c4edb34f1c59f3dbe37cb22f01b0d4
This commit is contained in:
@@ -20,7 +20,6 @@ import android.app.Activity;
|
|||||||
import android.app.Dialog;
|
import android.app.Dialog;
|
||||||
import android.content.Context;
|
import android.content.Context;
|
||||||
import android.content.Intent;
|
import android.content.Intent;
|
||||||
import android.os.UserManager;
|
|
||||||
import android.provider.SearchIndexableResource;
|
import android.provider.SearchIndexableResource;
|
||||||
|
|
||||||
import com.android.internal.logging.nano.MetricsProto.MetricsEvent;
|
import com.android.internal.logging.nano.MetricsProto.MetricsEvent;
|
||||||
|
@@ -197,12 +197,11 @@ public class CardDatabaseHelper extends SQLiteOpenHelper {
|
|||||||
}
|
}
|
||||||
|
|
||||||
Cursor getContextualCards() {
|
Cursor getContextualCards() {
|
||||||
final SQLiteDatabase db = this.getReadableDatabase();
|
final SQLiteDatabase db = getReadableDatabase();
|
||||||
final String selection = CardColumns.CARD_DISMISSED + "=0";
|
final String selection = CardColumns.CARD_DISMISSED + "=0";
|
||||||
Cursor cursor = db.query(CARD_TABLE, null /* columns */, selection,
|
return db.query(CARD_TABLE, null /* columns */, selection,
|
||||||
null /* selectionArgs */, null /* groupBy */, null /* having */,
|
null /* selectionArgs */, null /* groupBy */, null /* having */,
|
||||||
CardColumns.SCORE + " DESC" /* orderBy */);
|
CardColumns.SCORE + " DESC" /* orderBy */);
|
||||||
return cursor;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@@ -28,33 +28,27 @@ import android.content.Context;
|
|||||||
import android.net.Uri;
|
import android.net.Uri;
|
||||||
|
|
||||||
import com.android.settings.slices.CustomSliceRegistry;
|
import com.android.settings.slices.CustomSliceRegistry;
|
||||||
import com.android.settings.slices.SettingsSliceProvider;
|
|
||||||
|
import java.util.ArrayList;
|
||||||
|
import java.util.List;
|
||||||
|
import java.util.stream.Collectors;
|
||||||
|
|
||||||
import org.junit.Before;
|
import org.junit.Before;
|
||||||
import org.junit.Test;
|
import org.junit.Test;
|
||||||
import org.junit.runner.RunWith;
|
import org.junit.runner.RunWith;
|
||||||
import org.robolectric.RobolectricTestRunner;
|
import org.robolectric.RobolectricTestRunner;
|
||||||
import org.robolectric.RuntimeEnvironment;
|
import org.robolectric.RuntimeEnvironment;
|
||||||
import org.robolectric.shadows.ShadowContentResolver;
|
|
||||||
|
|
||||||
import java.util.ArrayList;
|
|
||||||
import java.util.List;
|
|
||||||
import java.util.stream.Collectors;
|
|
||||||
|
|
||||||
@RunWith(RobolectricTestRunner.class)
|
@RunWith(RobolectricTestRunner.class)
|
||||||
public class ContextualCardLoaderTest {
|
public class ContextualCardLoaderTest {
|
||||||
|
|
||||||
private Context mContext;
|
private Context mContext;
|
||||||
private ContextualCardLoader mContextualCardLoader;
|
private ContextualCardLoader mContextualCardLoader;
|
||||||
private SettingsSliceProvider mProvider;
|
|
||||||
|
|
||||||
@Before
|
@Before
|
||||||
public void setUp() {
|
public void setUp() {
|
||||||
mContext = RuntimeEnvironment.application;
|
mContext = RuntimeEnvironment.application;
|
||||||
mContextualCardLoader = spy(new ContextualCardLoader(mContext));
|
mContextualCardLoader = spy(new ContextualCardLoader(mContext));
|
||||||
mProvider = new SettingsSliceProvider();
|
|
||||||
ShadowContentResolver.registerProviderInternal(SettingsSliceProvider.SLICE_AUTHORITY,
|
|
||||||
mProvider);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
|
Reference in New Issue
Block a user