From 92dbda2af0f0959c08a588da71bf9403a9f9bfcf Mon Sep 17 00:00:00 2001 From: Sunny Shao Date: Mon, 9 Sep 2019 03:10:12 +0000 Subject: [PATCH] Revert "Refreshes preference text when updateStates" This reverts commit ff6cc9be3c84a23d5f8caa623fa1c5d48051a4b5. Reason for revert: This cl caused some toggle preference just show on/off in the subtext. Fixes: 138988285 Fixes: 140475264 Fixes: 140536268 Change-Id: I6cc5136205c50ae373fdfb32f2252a1f7a7c51aa --- src/com/android/settings/core/TogglePreferenceController.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/core/TogglePreferenceController.java b/src/com/android/settings/core/TogglePreferenceController.java index 66837d6b950..165d7eb1305 100644 --- a/src/com/android/settings/core/TogglePreferenceController.java +++ b/src/com/android/settings/core/TogglePreferenceController.java @@ -54,8 +54,9 @@ public abstract class TogglePreferenceController extends BasePreferenceControlle ((TwoStatePreference) preference).setChecked(isChecked()); } else if (preference instanceof MasterSwitchPreference) { ((MasterSwitchPreference) preference).setChecked(isChecked()); + } else { + refreshSummary(preference); } - refreshSummary(preference); } @Override