Listen wifi entry change to make sure UI correct.

Bug: 319905522
Test: make pass.
Test: atest pass.
Change-Id: I0900caf6521bd9a250e85863f48e39668734f1be
This commit is contained in:
tomhsu
2024-04-08 07:35:24 +00:00
committed by Tom Hsu
parent f5d8f4afa9
commit 91bcc2b594
4 changed files with 24 additions and 16 deletions

View File

@@ -24,7 +24,6 @@ import androidx.preference.PreferenceCategory;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settings.core.BasePreferenceController; import com.android.settings.core.BasePreferenceController;
import com.android.settings.wifi.WifiPickerTrackerHelper;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
/** /**
@@ -117,12 +116,6 @@ public class NetworkMobileProviderController extends BasePreferenceController im
mPreferenceCategory.setVisible(available); mPreferenceCategory.setVisible(available);
} }
public void setWifiPickerTrackerHelper(WifiPickerTrackerHelper helper) {
if (mSubscriptionsController != null) {
mSubscriptionsController.setWifiPickerTrackerHelper(helper);
}
}
/** /**
* Hides the preference. * Hides the preference.
*/ */

View File

@@ -477,10 +477,6 @@ public class NetworkProviderSettings extends RestrictedSettingsFragment
mOpenSsid = intent.getStringExtra(EXTRA_START_CONNECT_SSID); mOpenSsid = intent.getStringExtra(EXTRA_START_CONNECT_SSID);
} }
if (mNetworkMobileProviderController != null) {
mNetworkMobileProviderController.setWifiPickerTrackerHelper(mWifiPickerTrackerHelper);
}
requireActivity().addMenuProvider(mMenuProvider); requireActivity().addMenuProvider(mMenuProvider);
} }

View File

@@ -68,6 +68,7 @@ import com.android.settingslib.mobile.MobileMappings.Config;
import com.android.settingslib.mobile.TelephonyIcons; import com.android.settingslib.mobile.TelephonyIcons;
import com.android.settingslib.net.SignalStrengthUtil; import com.android.settingslib.net.SignalStrengthUtil;
import com.android.wifitrackerlib.WifiEntry; import com.android.wifitrackerlib.WifiEntry;
import com.android.wifitrackerlib.WifiPickerTracker;
import java.util.Collections; import java.util.Collections;
import java.util.List; import java.util.List;
@@ -82,7 +83,7 @@ public class SubscriptionsPreferenceController extends AbstractPreferenceControl
LifecycleObserver, SubscriptionsChangeListener.SubscriptionsChangeListenerClient, LifecycleObserver, SubscriptionsChangeListener.SubscriptionsChangeListenerClient,
MobileDataEnabledListener.Client, DataConnectivityListener.Client, MobileDataEnabledListener.Client, DataConnectivityListener.Client,
SignalStrengthListener.Callback, TelephonyDisplayInfoListener.Callback, SignalStrengthListener.Callback, TelephonyDisplayInfoListener.Callback,
TelephonyCallback.CarrierNetworkListener { TelephonyCallback.CarrierNetworkListener, WifiPickerTracker.WifiPickerTrackerCallback {
private static final String TAG = "SubscriptionsPrefCntrlr"; private static final String TAG = "SubscriptionsPrefCntrlr";
private UpdateListener mUpdateListener; private UpdateListener mUpdateListener;
@@ -95,7 +96,8 @@ public class SubscriptionsPreferenceController extends AbstractPreferenceControl
private DataConnectivityListener mConnectivityListener; private DataConnectivityListener mConnectivityListener;
private SignalStrengthListener mSignalStrengthListener; private SignalStrengthListener mSignalStrengthListener;
private TelephonyDisplayInfoListener mTelephonyDisplayInfoListener; private TelephonyDisplayInfoListener mTelephonyDisplayInfoListener;
private WifiPickerTrackerHelper mWifiPickerTrackerHelper; @VisibleForTesting
WifiPickerTrackerHelper mWifiPickerTrackerHelper;
private final WifiManager mWifiManager; private final WifiManager mWifiManager;
private boolean mCarrierNetworkChangeMode; private boolean mCarrierNetworkChangeMode;
@@ -163,6 +165,7 @@ public class SubscriptionsPreferenceController extends AbstractPreferenceControl
mSignalStrengthListener = new SignalStrengthListener(context, this); mSignalStrengthListener = new SignalStrengthListener(context, this);
mTelephonyDisplayInfoListener = new TelephonyDisplayInfoListener(context, this); mTelephonyDisplayInfoListener = new TelephonyDisplayInfoListener(context, this);
lifecycle.addObserver(this); lifecycle.addObserver(this);
mWifiPickerTrackerHelper = new WifiPickerTrackerHelper(lifecycle, context, this);
mSubsPrefCtrlInjector = createSubsPrefCtrlInjector(); mSubsPrefCtrlInjector = createSubsPrefCtrlInjector();
mConfig = mSubsPrefCtrlInjector.getConfig(mContext); mConfig = mSubsPrefCtrlInjector.getConfig(mContext);
} }
@@ -485,8 +488,24 @@ public class SubscriptionsPreferenceController extends AbstractPreferenceControl
update(); update();
} }
public void setWifiPickerTrackerHelper(WifiPickerTrackerHelper helper) { @Override
mWifiPickerTrackerHelper = helper; public void onNumSavedNetworksChanged() {
//Do nothing
}
@Override
public void onNumSavedSubscriptionsChanged() {
//Do nothing
}
@Override
public void onWifiStateChanged() {
update();
}
@Override
public void onWifiEntriesChanged() {
update();
} }
@VisibleForTesting @VisibleForTesting

View File

@@ -165,7 +165,7 @@ public class SubscriptionsPreferenceControllerTest {
mController = new FakeSubscriptionsPreferenceController(mContext, mLifecycle, mController = new FakeSubscriptionsPreferenceController(mContext, mLifecycle,
mUpdateListener, KEY, 5); mUpdateListener, KEY, 5);
Settings.Global.putInt(mContext.getContentResolver(), Settings.Global.AIRPLANE_MODE_ON, 0); Settings.Global.putInt(mContext.getContentResolver(), Settings.Global.AIRPLANE_MODE_ON, 0);
mController.setWifiPickerTrackerHelper(mWifiPickerTrackerHelper); mController.mWifiPickerTrackerHelper = mWifiPickerTrackerHelper;
} }
@After @After