From 70470586a6accf7af2a165fc59008bc54774026e Mon Sep 17 00:00:00 2001 From: Chaohui Wang Date: Tue, 29 Mar 2022 14:37:53 +0800 Subject: [PATCH] Fix XML preference controller with androidx LifecycleObserver Controller can implements LifecycleObserver to observe the lifecycle. Before this fix, preference controller which defined in the XML file must implement com.android.settingslib.core.lifecycle.LifecycleObserver (which is deprecated, and is a subclass of androidx.lifecycle.LifecycleObserver). After this fix, preference controller which defined in the XML file and implemented androidx.lifecycle.LifecycleObserver will successful observe the lifecycle. Fix: 149338098 Test: robotest & manual Change-Id: If9e48e44267de8e89a5e8f45d256719130936320 --- src/com/android/settings/dashboard/DashboardFragment.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/com/android/settings/dashboard/DashboardFragment.java b/src/com/android/settings/dashboard/DashboardFragment.java index bff8226910e..256a6201cb7 100644 --- a/src/com/android/settings/dashboard/DashboardFragment.java +++ b/src/com/android/settings/dashboard/DashboardFragment.java @@ -27,6 +27,7 @@ import android.util.Log; import androidx.annotation.CallSuper; import androidx.annotation.VisibleForTesting; +import androidx.lifecycle.LifecycleObserver; import androidx.preference.Preference; import androidx.preference.PreferenceGroup; import androidx.preference.PreferenceManager; @@ -43,7 +44,6 @@ import com.android.settings.overlay.FeatureFactory; import com.android.settingslib.PrimarySwitchPreference; import com.android.settingslib.core.AbstractPreferenceController; import com.android.settingslib.core.lifecycle.Lifecycle; -import com.android.settingslib.core.lifecycle.LifecycleObserver; import com.android.settingslib.drawer.DashboardCategory; import com.android.settingslib.drawer.ProviderTile; import com.android.settingslib.drawer.Tile;