Merge "Fix NPE of AppVersionPreferenceController" into sc-dev

2021-03-18 04:48:54 +00:00
parent 6da9386097 e4b3b969db
commit 8f414f2e0f
2 changed files with 19 additions and 1 deletions
--- a/tests/robotests/src/com/android/settings/applications/appinfo/AppVersionPreferenceControllerTest.java
+++ b/tests/robotests/src/com/android/settings/applications/appinfo/AppVersionPreferenceControllerTest.java
@@ -16,6 +16,8 @@

 package com.android.settings.applications.appinfo;

+import static com.google.common.truth.Truth.assertThat;
+
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
@@ -62,4 +64,13 @@ public class AppVersionPreferenceControllerTest {

        verify(mPreference).setSummary("version test1234");
    }
+
+    @Test
+    public void updateState_packageInfoNull_shouldNotCrash() {
+        when(mFragment.getPackageInfo()).thenReturn(null);
+
+        mController.updateState(mPreference);
+
+        assertThat(mController.getSummary()).isNull();
+    }
 }