Update airplane mode key to match framework constant
Change pref key for airplane mode to "airplane_mode" to match the constant declared in SettingsSlicesContract. Bug: 80106671 Test: robotests Change-Id: I898befffbdafc3004fc127414edd04f60ff2554e
This commit is contained in:
@@ -68,12 +68,13 @@
|
|||||||
settings:useAdminDisabledSummary="true" />
|
settings:useAdminDisabledSummary="true" />
|
||||||
|
|
||||||
<com.android.settingslib.RestrictedSwitchPreference
|
<com.android.settingslib.RestrictedSwitchPreference
|
||||||
android:key="toggle_airplane"
|
android:key="airplane_mode"
|
||||||
android:title="@string/airplane_mode"
|
android:title="@string/airplane_mode"
|
||||||
android:icon="@drawable/ic_airplanemode_active"
|
android:icon="@drawable/ic_airplanemode_active"
|
||||||
android:disableDependentsState="true"
|
android:disableDependentsState="true"
|
||||||
android:order="5"
|
android:order="5"
|
||||||
settings:controller="com.android.settings.network.AirplaneModePreferenceController"
|
settings:controller="com.android.settings.network.AirplaneModePreferenceController"
|
||||||
|
settings:platform_slice="true"
|
||||||
settings:userRestriction="no_airplane_mode"/>
|
settings:userRestriction="no_airplane_mode"/>
|
||||||
|
|
||||||
<Preference
|
<Preference
|
||||||
|
@@ -15,14 +15,13 @@
|
|||||||
*/
|
*/
|
||||||
package com.android.settings.network;
|
package com.android.settings.network;
|
||||||
|
|
||||||
|
import static android.provider.SettingsSlicesContract.KEY_AIRPLANE_MODE;
|
||||||
|
|
||||||
import android.app.Fragment;
|
import android.app.Fragment;
|
||||||
import android.content.Context;
|
import android.content.Context;
|
||||||
import android.content.Intent;
|
import android.content.Intent;
|
||||||
import android.content.pm.PackageManager;
|
import android.content.pm.PackageManager;
|
||||||
import android.os.SystemProperties;
|
import android.os.SystemProperties;
|
||||||
import androidx.preference.SwitchPreference;
|
|
||||||
import androidx.preference.Preference;
|
|
||||||
import androidx.preference.PreferenceScreen;
|
|
||||||
import android.text.TextUtils;
|
import android.text.TextUtils;
|
||||||
|
|
||||||
import com.android.internal.telephony.TelephonyIntents;
|
import com.android.internal.telephony.TelephonyIntents;
|
||||||
@@ -36,14 +35,16 @@ import com.android.settingslib.core.lifecycle.LifecycleObserver;
|
|||||||
import com.android.settingslib.core.lifecycle.events.OnPause;
|
import com.android.settingslib.core.lifecycle.events.OnPause;
|
||||||
import com.android.settingslib.core.lifecycle.events.OnResume;
|
import com.android.settingslib.core.lifecycle.events.OnResume;
|
||||||
|
|
||||||
|
import androidx.preference.SwitchPreference;
|
||||||
|
import androidx.preference.Preference;
|
||||||
|
import androidx.preference.PreferenceScreen;
|
||||||
|
|
||||||
public class AirplaneModePreferenceController extends TogglePreferenceController
|
public class AirplaneModePreferenceController extends TogglePreferenceController
|
||||||
implements LifecycleObserver, OnResume, OnPause,
|
implements LifecycleObserver, OnResume, OnPause,
|
||||||
AirplaneModeEnabler.OnAirplaneModeChangedListener {
|
AirplaneModeEnabler.OnAirplaneModeChangedListener {
|
||||||
|
|
||||||
public static final int REQUEST_CODE_EXIT_ECM = 1;
|
public static final int REQUEST_CODE_EXIT_ECM = 1;
|
||||||
|
|
||||||
public static final String KEY_TOGGLE_AIRPLANE = "toggle_airplane";
|
|
||||||
|
|
||||||
private static final String EXIT_ECM_RESULT = "exit_ecm_result";
|
private static final String EXIT_ECM_RESULT = "exit_ecm_result";
|
||||||
|
|
||||||
private Fragment mFragment;
|
private Fragment mFragment;
|
||||||
@@ -51,7 +52,6 @@ public class AirplaneModePreferenceController extends TogglePreferenceController
|
|||||||
private AirplaneModeEnabler mAirplaneModeEnabler;
|
private AirplaneModeEnabler mAirplaneModeEnabler;
|
||||||
private SwitchPreference mAirplaneModePreference;
|
private SwitchPreference mAirplaneModePreference;
|
||||||
|
|
||||||
|
|
||||||
public AirplaneModePreferenceController(Context context, String key) {
|
public AirplaneModePreferenceController(Context context, String key) {
|
||||||
super(context, key);
|
super(context, key);
|
||||||
mMetricsFeatureProvider = FeatureFactory.getFactory(context).getMetricsFeatureProvider();
|
mMetricsFeatureProvider = FeatureFactory.getFactory(context).getMetricsFeatureProvider();
|
||||||
@@ -64,7 +64,7 @@ public class AirplaneModePreferenceController extends TogglePreferenceController
|
|||||||
|
|
||||||
@Override
|
@Override
|
||||||
public boolean handlePreferenceTreeClick(Preference preference) {
|
public boolean handlePreferenceTreeClick(Preference preference) {
|
||||||
if (KEY_TOGGLE_AIRPLANE.equals(preference.getKey()) && Boolean.parseBoolean(
|
if (KEY_AIRPLANE_MODE.equals(preference.getKey()) && Boolean.parseBoolean(
|
||||||
SystemProperties.get(TelephonyProperties.PROPERTY_INECM_MODE))) {
|
SystemProperties.get(TelephonyProperties.PROPERTY_INECM_MODE))) {
|
||||||
// In ECM mode launch ECM app dialog
|
// In ECM mode launch ECM app dialog
|
||||||
if (mFragment != null) {
|
if (mFragment != null) {
|
||||||
|
@@ -28,9 +28,7 @@ import android.os.ServiceManager;
|
|||||||
import android.os.UserHandle;
|
import android.os.UserHandle;
|
||||||
import android.os.UserManager;
|
import android.os.UserManager;
|
||||||
import android.provider.Settings;
|
import android.provider.Settings;
|
||||||
import androidx.annotation.VisibleForTesting;
|
import android.provider.SettingsSlicesContract;
|
||||||
import androidx.preference.Preference;
|
|
||||||
import androidx.preference.PreferenceScreen;
|
|
||||||
import android.util.Log;
|
import android.util.Log;
|
||||||
import android.util.SparseArray;
|
import android.util.SparseArray;
|
||||||
|
|
||||||
@@ -47,6 +45,10 @@ import com.android.settingslib.utils.ThreadUtils;
|
|||||||
|
|
||||||
import java.util.List;
|
import java.util.List;
|
||||||
|
|
||||||
|
import androidx.annotation.VisibleForTesting;
|
||||||
|
import androidx.preference.Preference;
|
||||||
|
import androidx.preference.PreferenceScreen;
|
||||||
|
|
||||||
|
|
||||||
public class VpnPreferenceController extends AbstractPreferenceController
|
public class VpnPreferenceController extends AbstractPreferenceController
|
||||||
implements PreferenceControllerMixin, LifecycleObserver, OnResume, OnPause {
|
implements PreferenceControllerMixin, LifecycleObserver, OnResume, OnPause {
|
||||||
@@ -83,7 +85,7 @@ public class VpnPreferenceController extends AbstractPreferenceController
|
|||||||
// Manually set dependencies for Wifi when not toggleable.
|
// Manually set dependencies for Wifi when not toggleable.
|
||||||
if (mToggleable == null || !mToggleable.contains(Settings.Global.RADIO_WIFI)) {
|
if (mToggleable == null || !mToggleable.contains(Settings.Global.RADIO_WIFI)) {
|
||||||
if (mPreference != null) {
|
if (mPreference != null) {
|
||||||
mPreference.setDependency(AirplaneModePreferenceController.KEY_TOGGLE_AIRPLANE);
|
mPreference.setDependency(SettingsSlicesContract.KEY_AIRPLANE_MODE);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@@ -21,13 +21,11 @@ import static org.mockito.Mockito.doReturn;
|
|||||||
import static org.mockito.Mockito.spy;
|
import static org.mockito.Mockito.spy;
|
||||||
import static org.mockito.Mockito.when;
|
import static org.mockito.Mockito.when;
|
||||||
|
|
||||||
import androidx.lifecycle.LifecycleOwner;
|
|
||||||
import android.content.ContentResolver;
|
import android.content.ContentResolver;
|
||||||
import android.content.Context;
|
import android.content.Context;
|
||||||
import android.content.pm.PackageManager;
|
import android.content.pm.PackageManager;
|
||||||
import android.provider.Settings;
|
import android.provider.Settings;
|
||||||
import androidx.preference.PreferenceManager;
|
import android.provider.SettingsSlicesContract;
|
||||||
import androidx.preference.PreferenceScreen;
|
|
||||||
|
|
||||||
import com.android.settings.core.BasePreferenceController;
|
import com.android.settings.core.BasePreferenceController;
|
||||||
import com.android.settings.testutils.FakeFeatureFactory;
|
import com.android.settings.testutils.FakeFeatureFactory;
|
||||||
@@ -43,6 +41,10 @@ import org.mockito.MockitoAnnotations;
|
|||||||
import org.robolectric.RuntimeEnvironment;
|
import org.robolectric.RuntimeEnvironment;
|
||||||
import org.robolectric.annotation.Config;
|
import org.robolectric.annotation.Config;
|
||||||
|
|
||||||
|
import androidx.lifecycle.LifecycleOwner;
|
||||||
|
import androidx.preference.PreferenceManager;
|
||||||
|
import androidx.preference.PreferenceScreen;
|
||||||
|
|
||||||
@RunWith(SettingsRobolectricTestRunner.class)
|
@RunWith(SettingsRobolectricTestRunner.class)
|
||||||
public class AirplaneModePreferenceControllerTest {
|
public class AirplaneModePreferenceControllerTest {
|
||||||
|
|
||||||
@@ -69,12 +71,12 @@ public class AirplaneModePreferenceControllerTest {
|
|||||||
mResolver = RuntimeEnvironment.application.getContentResolver();
|
mResolver = RuntimeEnvironment.application.getContentResolver();
|
||||||
doReturn(mPackageManager).when(mContext).getPackageManager();
|
doReturn(mPackageManager).when(mContext).getPackageManager();
|
||||||
mController = new AirplaneModePreferenceController(mContext,
|
mController = new AirplaneModePreferenceController(mContext,
|
||||||
AirplaneModePreferenceController.KEY_TOGGLE_AIRPLANE);
|
SettingsSlicesContract.KEY_AIRPLANE_MODE);
|
||||||
|
|
||||||
mPreferenceManager = new PreferenceManager(mContext);
|
mPreferenceManager = new PreferenceManager(mContext);
|
||||||
mScreen = mPreferenceManager.createPreferenceScreen(mContext);
|
mScreen = mPreferenceManager.createPreferenceScreen(mContext);
|
||||||
mPreference = new RestrictedSwitchPreference(mContext);
|
mPreference = new RestrictedSwitchPreference(mContext);
|
||||||
mPreference.setKey("toggle_airplane");
|
mPreference.setKey(SettingsSlicesContract.KEY_AIRPLANE_MODE);
|
||||||
mScreen.addPreference(mPreference);
|
mScreen.addPreference(mPreference);
|
||||||
mController.setFragment(null);
|
mController.setFragment(null);
|
||||||
mLifecycleOwner = () -> mLifecycle;
|
mLifecycleOwner = () -> mLifecycle;
|
||||||
|
@@ -33,13 +33,15 @@ import android.net.IConnectivityManager;
|
|||||||
import android.net.NetworkRequest;
|
import android.net.NetworkRequest;
|
||||||
import android.os.IBinder;
|
import android.os.IBinder;
|
||||||
import android.os.UserHandle;
|
import android.os.UserHandle;
|
||||||
import androidx.preference.Preference;
|
import android.provider.SettingsSlicesContract;
|
||||||
import androidx.preference.PreferenceScreen;
|
|
||||||
|
|
||||||
import com.android.internal.net.VpnConfig;
|
import com.android.internal.net.VpnConfig;
|
||||||
import com.android.settings.testutils.SettingsRobolectricTestRunner;
|
import com.android.settings.testutils.SettingsRobolectricTestRunner;
|
||||||
import com.android.settingslib.core.lifecycle.Lifecycle;
|
import com.android.settingslib.core.lifecycle.Lifecycle;
|
||||||
|
|
||||||
|
import androidx.preference.Preference;
|
||||||
|
import androidx.preference.PreferenceScreen;
|
||||||
|
|
||||||
import org.junit.Before;
|
import org.junit.Before;
|
||||||
import org.junit.Test;
|
import org.junit.Test;
|
||||||
import org.junit.runner.RunWith;
|
import org.junit.runner.RunWith;
|
||||||
@@ -88,7 +90,7 @@ public class VpnPreferenceControllerTest {
|
|||||||
doReturn(true).when(mController).isAvailable();
|
doReturn(true).when(mController).isAvailable();
|
||||||
mController.displayPreference(mScreen);
|
mController.displayPreference(mScreen);
|
||||||
|
|
||||||
verify(mPreference).setDependency(AirplaneModePreferenceController.KEY_TOGGLE_AIRPLANE);
|
verify(mPreference).setDependency(SettingsSlicesContract.KEY_AIRPLANE_MODE);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
|
Reference in New Issue
Block a user