From ec996be27b90f7bade344fef95f96460621e53ec Mon Sep 17 00:00:00 2001 From: Yorke Lee Date: Tue, 28 Apr 2015 11:35:22 -0700 Subject: [PATCH] Simplify DefaultDialerManager The previous code worked with ComponentNames because it was based off existing code for the default SMS application. We only really need the package name however, so simplify the code by storing and retrieving the package name directly. Bug: 20304458 Change-Id: Icabd3a9f0f8166c105360494b601160d13767fad --- .../applications/DefaultDialerPreference.java | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/com/android/settings/applications/DefaultDialerPreference.java b/src/com/android/settings/applications/DefaultDialerPreference.java index ce169664815..252b02eee58 100644 --- a/src/com/android/settings/applications/DefaultDialerPreference.java +++ b/src/com/android/settings/applications/DefaultDialerPreference.java @@ -16,7 +16,6 @@ package com.android.settings.applications; -import android.content.ComponentName; import android.content.Context; import android.os.UserManager; import android.telecom.DefaultDialerManager; @@ -49,22 +48,18 @@ public class DefaultDialerPreference extends AppListPreference { } private void loadDialerApps() { - List dialerComponents = + List dialerPackages = DefaultDialerManager.getInstalledDialerApplications(getContext()); - final String[] dialers = new String[dialerComponents.size()]; - for (int i = 0; i < dialerComponents.size(); i++) { - dialers[i] = dialerComponents.get(i).getPackageName(); + final String[] dialers = new String[dialerPackages.size()]; + for (int i = 0; i < dialerPackages.size(); i++) { + dialers[i] = dialerPackages.get(i); } setPackageNames(dialers, getDefaultPackage()); } private String getDefaultPackage() { - ComponentName appName = DefaultDialerManager.getDefaultDialerApplication(getContext()); - if (appName != null) { - return appName.getPackageName(); - } - return null; + return DefaultDialerManager.getDefaultDialerApplication(getContext()); } public static boolean isAvailable(Context context) {