PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Catalyst] Avoid PreferenceMetadata.getPreferenceSummary call

Browse Source 
PreferenceMetadata.getPreferenceSummary is implementation detail.

Bug: 388167106
Flag: EXEMPT refactor
Test: atest
Change-Id: I4ec429723f0275c540b4e91e46dfc19fd592c524
This commit is contained in:
Jacky Wang
2025-03-10 10:20:14 +08:00
parent a7a7482118
commit 8db6c33b46
3 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/robotests/src/com/android/settings/accessibility/ColorInversionPreferenceTest.kt
View File

@@ -97,7 +97,7 @@ class ColorInversionPreferenceTest {
fun getSummary_colorInversionOn_verifySummary() { fun getSummary_colorInversionOn_verifySummary() {
SettingsSecureStore.get(appContext).setInt(SETTING_KEY, AccessibilityUtil.State.ON) SettingsSecureStore.get(appContext).setInt(SETTING_KEY, AccessibilityUtil.State.ON)
assertThat(colorInversionPreference.getPreferenceSummary(appContext)).isEqualTo( assertThat(colorInversionPreference.getSummary(appContext)).isEqualTo(
appContext.getText( appContext.getText(
R.string.color_inversion_state_on R.string.color_inversion_state_on
) )
@@ -108,7 +108,7 @@ class ColorInversionPreferenceTest {
fun getSummary_colorInversionOff_verifySummary() { fun getSummary_colorInversionOff_verifySummary() {
SettingsSecureStore.get(appContext).setInt(SETTING_KEY, AccessibilityUtil.State.OFF) SettingsSecureStore.get(appContext).setInt(SETTING_KEY, AccessibilityUtil.State.OFF)
assertThat(colorInversionPreference.getPreferenceSummary(appContext)).isEqualTo( assertThat(colorInversionPreference.getSummary(appContext)).isEqualTo(
appContext.getText( appContext.getText(
R.string.color_inversion_state_off R.string.color_inversion_state_off
) )

4
tests/robotests/src/com/android/settings/accessibility/DaltonizerPreferenceTest.kt
View File

@@ -97,7 +97,7 @@ class DaltonizerPreferenceTest {
fun getSummary_daltonizerOn_verifySummary() { fun getSummary_daltonizerOn_verifySummary() {
SettingsSecureStore.get(appContext).setInt(SETTING_KEY, AccessibilityUtil.State.ON) SettingsSecureStore.get(appContext).setInt(SETTING_KEY, AccessibilityUtil.State.ON)
assertThat(daltonizerPreference.getPreferenceSummary(appContext)).isEqualTo( assertThat(daltonizerPreference.getSummary(appContext)).isEqualTo(
appContext.getText( appContext.getText(
R.string.daltonizer_state_on R.string.daltonizer_state_on
) )
@@ -108,7 +108,7 @@ class DaltonizerPreferenceTest {
fun getSummary_daltonizerOff_verifySummary() { fun getSummary_daltonizerOff_verifySummary() {
SettingsSecureStore.get(appContext).setInt(SETTING_KEY, AccessibilityUtil.State.OFF) SettingsSecureStore.get(appContext).setInt(SETTING_KEY, AccessibilityUtil.State.OFF)
assertThat(daltonizerPreference.getPreferenceSummary(appContext)).isEqualTo( assertThat(daltonizerPreference.getSummary(appContext)).isEqualTo(
appContext.getText( appContext.getText(
R.string.daltonizer_state_off R.string.daltonizer_state_off
) )

5
tests/robotests/src/com/android/settings/supervision/SupervisionPinManagementScreenTest.kt
View File

@@ -18,6 +18,7 @@ package com.android.settings.supervision
import android.content.Context import android.content.Context
import androidx.test.core.app.ApplicationProvider import androidx.test.core.app.ApplicationProvider
import androidx.test.ext.junit.runners.AndroidJUnit4 import androidx.test.ext.junit.runners.AndroidJUnit4
import com.android.settings.R
import com.google.common.truth.Truth.assertThat import com.google.common.truth.Truth.assertThat
import org.junit.Test import org.junit.Test
import org.junit.runner.RunWith import org.junit.runner.RunWith
@@ -41,7 +42,7 @@ class SupervisionPinManagementScreenTest {
@Test @Test
fun getSummary_addPin() { fun getSummary_addPin() {
assertThat(supervisionPinManagementScreen.getPreferenceSummary(context)) assertThat(supervisionPinManagementScreen.summary)
.isEqualTo("Add a PIN recovery method") .isEqualTo(R.string.supervision_pin_management_preference_summary_add)
} }
} }