Prioritize dynamic summaries

If both Xml and a controller provide a summary,
the controller's should be prioritized.

Change-Id: I030746b0f253ce4884a7868e385069b208f63082
Fixes: 77602860
Test: robotests
This commit is contained in:
Matthew Fritze
2018-04-04 16:58:56 -07:00
parent 66e6e637a4
commit 8db4358f76
2 changed files with 25 additions and 13 deletions

View File

@@ -253,11 +253,7 @@ public class SliceBuilderUtils {
@VisibleForTesting
static CharSequence getSubtitleText(Context context, AbstractPreferenceController controller,
SliceData sliceData) {
CharSequence summaryText = sliceData.getSummary();
if (isValidSummary(context, summaryText)) {
return summaryText;
}
CharSequence summaryText;
if (controller != null) {
summaryText = controller.getSummary();
@@ -266,7 +262,12 @@ public class SliceBuilderUtils {
}
}
return sliceData.getScreenTitle();
summaryText = sliceData.getSummary();
if (isValidSummary(context, summaryText)) {
return summaryText;
}
return "";
}
private static boolean isValidSummary(Context context, CharSequence summary) {