PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed One-Handed preference item’s second line should show on/off

Browse Source 
status in Settings > System > Gesture > One-Handed.

To override getSummary() method to display on/off status in
One-Handed preference item’s second line.

Bug: 154600203

Test: manual
Change-Id: Ic9a5b74fbca041a08e712d5529b66e672f0c74ab
This commit is contained in:
Jason Chang
2020-04-21 23:17:45 +08:00
parent 26684c0500
commit 8c42720803
2 changed files with 25 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/com/android/settings/gestures/OneHandedEnablePreferenceController.java
View File

@@ -18,6 +18,7 @@ package com.android.settings.gestures;
import android.content.Context; import android.content.Context;
import com.android.settings.R;
import com.android.settings.core.BasePreferenceController; import com.android.settings.core.BasePreferenceController;
import com.android.settings.core.TogglePreferenceController; import com.android.settings.core.TogglePreferenceController;
@@ -46,4 +47,11 @@ public class OneHandedEnablePreferenceController extends TogglePreferenceControl
public boolean isChecked() { public boolean isChecked() {
return OneHandedSettingsUtils.isOneHandedModeEnabled(mContext); return OneHandedSettingsUtils.isOneHandedModeEnabled(mContext);
} }
@Override
public CharSequence getSummary() {
return OneHandedSettingsUtils.isOneHandedModeEnabled(mContext)
? mContext.getText(R.string.switch_on_text)
: mContext.getText(R.string.switch_off_text);
}
} }

17
tests/robotests/src/com/android/settings/gestures/OneHandedEnablePreferenceControllerTest.java
View File

@@ -20,6 +20,7 @@ import static com.google.common.truth.Truth.assertThat;
import android.content.Context; import android.content.Context;
import com.android.settings.R;
import com.android.settings.core.BasePreferenceController; import com.android.settings.core.BasePreferenceController;
import org.junit.Before; import org.junit.Before;
@@ -60,4 +61,20 @@ public class OneHandedEnablePreferenceControllerTest {
assertThat(mController.getAvailabilityStatus()) assertThat(mController.getAvailabilityStatus())
.isEqualTo(BasePreferenceController.AVAILABLE); .isEqualTo(BasePreferenceController.AVAILABLE);
} }
@Test
public void getSummary_enabledOneHanded_shouldDisplayOnSummary() {
OneHandedSettingsUtils.setSettingsOneHandedModeEnabled(mContext, true);
assertThat(mController.getSummary())
.isEqualTo(mContext.getText(R.string.switch_on_text));
}
@Test
public void getSummary_disabledOneHanded_shouldDisplayOffSummary() {
OneHandedSettingsUtils.setSettingsOneHandedModeEnabled(mContext, false);
assertThat(mController.getSummary())
.isEqualTo(mContext.getText(R.string.switch_off_text));
}
} }