diff --git a/res/values/strings.xml b/res/values/strings.xml index 2a2072780f7..16c7e188a21 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -11814,9 +11814,9 @@ used - %1$s %2$s + %1$s %2$s used - %1$s used of %2$s %3$s + %1$s %2$s total Clear app diff --git a/src/com/android/settings/deviceinfo/storage/StorageUsageProgressBarPreferenceController.java b/src/com/android/settings/deviceinfo/storage/StorageUsageProgressBarPreferenceController.java index ec51db6e541..6b06dafb71b 100644 --- a/src/com/android/settings/deviceinfo/storage/StorageUsageProgressBarPreferenceController.java +++ b/src/com/android/settings/deviceinfo/storage/StorageUsageProgressBarPreferenceController.java @@ -26,7 +26,6 @@ import androidx.preference.Preference; import androidx.preference.PreferenceScreen; import com.android.settings.R; -import com.android.settings.Utils; import com.android.settings.core.BasePreferenceController; import com.android.settingslib.utils.ThreadUtils; import com.android.settingslib.widget.UsageProgressBarPreference; @@ -108,23 +107,16 @@ public class StorageUsageProgressBarPreferenceController extends BasePreferenceC @Override public void updateState(Preference preference) { - final Formatter.BytesResult usedResult = getBytesResult(mUsedBytes); mUsageProgressBarPreference.setUsageSummary( - mContext.getString(R.string.storage_usage_summary, - usedResult.value, usedResult.units)); - - final String percentageString = mTotalBytes == 0L - ? Utils.formatPercentage(0) - : Utils.formatPercentage((mUsedBytes * 100) / mTotalBytes, true /* round */); - final Formatter.BytesResult totalResult = getBytesResult(mTotalBytes); + getStorageSummary(R.string.storage_usage_summary, mUsedBytes)); mUsageProgressBarPreference.setTotalSummary( - mContext.getString(R.string.storage_total_summary, percentageString, - totalResult.value, totalResult.units)); - + getStorageSummary(R.string.storage_total_summary, mTotalBytes)); mUsageProgressBarPreference.setPercent(mUsedBytes, mTotalBytes); } - private Formatter.BytesResult getBytesResult(long bytes) { - return Formatter.formatBytes(mContext.getResources(), bytes, Formatter.FLAG_SHORTER); + private String getStorageSummary(int resId, long bytes) { + final Formatter.BytesResult result = Formatter.formatBytes(mContext.getResources(), + bytes, Formatter.FLAG_SHORTER); + return mContext.getString(resId, result.value, result.units); } }