From 89f5e2e49786b69088e790773a5ddee67b24ebb6 Mon Sep 17 00:00:00 2001 From: Steven Ng Date: Fri, 4 Feb 2022 15:48:15 +0000 Subject: [PATCH] Show "Turns on at bedtime" in Dark theme setting based on feature flag Test: atest SettingsRoboTests:com.android.settings.display.darkmode.* Bug: 217866453 Change-Id: Ic40975d4506f812790768339e48441a048529df3 --- .../android/settings/display/darkmode/BedtimeSettings.java | 6 ++++++ .../android/settings/testutils/BedtimeSettingsUtils.java | 4 ++++ 2 files changed, 10 insertions(+) diff --git a/src/com/android/settings/display/darkmode/BedtimeSettings.java b/src/com/android/settings/display/darkmode/BedtimeSettings.java index d9a458c8798..28121b22cfc 100644 --- a/src/com/android/settings/display/darkmode/BedtimeSettings.java +++ b/src/com/android/settings/display/darkmode/BedtimeSettings.java @@ -17,11 +17,13 @@ package com.android.settings.display.darkmode; import static android.provider.Settings.ACTION_BEDTIME_SETTINGS; +import static android.util.FeatureFlagUtils.SETTINGS_APP_ALLOW_DARK_THEME_ACTIVATION_AT_BEDTIME; import android.content.Context; import android.content.Intent; import android.content.pm.PackageManager; import android.content.pm.ResolveInfo; +import android.util.FeatureFlagUtils; import androidx.annotation.Nullable; @@ -44,6 +46,10 @@ public final class BedtimeSettings { */ @Nullable public Intent getBedtimeSettingsIntent() { + if (!FeatureFlagUtils.isEnabled(mContext, + SETTINGS_APP_ALLOW_DARK_THEME_ACTIVATION_AT_BEDTIME)) { + return null; + } Intent bedtimeSettingsIntent = new Intent(ACTION_BEDTIME_SETTINGS).setPackage( mWellbeingPackage); ResolveInfo bedtimeSettingInfo = mPackageManager.resolveActivity(bedtimeSettingsIntent, diff --git a/tests/robotests/src/com/android/settings/testutils/BedtimeSettingsUtils.java b/tests/robotests/src/com/android/settings/testutils/BedtimeSettingsUtils.java index 59c501b3e36..ac55334b102 100644 --- a/tests/robotests/src/com/android/settings/testutils/BedtimeSettingsUtils.java +++ b/tests/robotests/src/com/android/settings/testutils/BedtimeSettingsUtils.java @@ -17,6 +17,7 @@ package com.android.settings.testutils; import static android.provider.Settings.ACTION_BEDTIME_SETTINGS; +import static android.util.FeatureFlagUtils.SETTINGS_APP_ALLOW_DARK_THEME_ACTIVATION_AT_BEDTIME; import static org.robolectric.Shadows.shadowOf; @@ -25,6 +26,7 @@ import android.content.Intent; import android.content.pm.ActivityInfo; import android.content.pm.ApplicationInfo; import android.content.pm.ResolveInfo; +import android.util.FeatureFlagUtils; /** A helper class for installing bedtime settings activity. */ public final class BedtimeSettingsUtils { @@ -35,6 +37,8 @@ public final class BedtimeSettingsUtils { } public void installBedtimeSettings(String wellbeingPackage, boolean enabled) { + FeatureFlagUtils.setEnabled(mContext, SETTINGS_APP_ALLOW_DARK_THEME_ACTIVATION_AT_BEDTIME, + true /* enabled */); Intent bedtimeSettingsIntent = new Intent(ACTION_BEDTIME_SETTINGS) .setPackage(wellbeingPackage); ResolveInfo bedtimeResolveInfo = new ResolveInfo();