Revert "Migrate to CompoundButton.OnCheckedChangeListener"

Revert submission 25147565-onSwitchChanged-CompoundButton

Reason for revert: breaking builds 

Bug:309601476

Reverted changes: /q/submissionid:25147565-onSwitchChanged-CompoundButton

Change-Id: Ie746db87d9c642599593aa3d5e5baf6b7ba89c0e
This commit is contained in:
Sebastian Pickl
2023-11-07 13:26:36 +00:00
committed by Android (Google) Code Review
parent 71d1f021af
commit 8979681a8d
49 changed files with 188 additions and 174 deletions

View File

@@ -17,18 +17,18 @@
package com.android.settings.accessibility; package com.android.settings.accessibility;
import android.content.Context; import android.content.Context;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.TogglePreferenceController; import com.android.settings.core.TogglePreferenceController;
import com.android.settings.widget.SettingsMainSwitchPreference; import com.android.settings.widget.SettingsMainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
/** Preference controller for captioning more options. */ /** Preference controller for captioning more options. */
public class CaptioningTogglePreferenceController extends TogglePreferenceController public class CaptioningTogglePreferenceController extends TogglePreferenceController
implements OnCheckedChangeListener { implements OnMainSwitchChangeListener {
private final CaptionHelper mCaptionHelper; private final CaptionHelper mCaptionHelper;
@@ -63,7 +63,7 @@ public class CaptioningTogglePreferenceController extends TogglePreferenceContro
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
if (isChecked != isChecked()) { if (isChecked != isChecked()) {
setChecked(isChecked); setChecked(isChecked);
} }

View File

@@ -41,7 +41,7 @@ import android.view.Menu;
import android.view.MenuInflater; import android.view.MenuInflater;
import android.view.View; import android.view.View;
import android.view.accessibility.AccessibilityManager; import android.view.accessibility.AccessibilityManager;
import android.widget.CompoundButton; import android.widget.Switch;
import androidx.annotation.Nullable; import androidx.annotation.Nullable;
@@ -294,7 +294,7 @@ public class ToggleAccessibilityServicePreferenceFragment extends
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
if (isChecked != isAccessibilityServiceEnabled()) { if (isChecked != isAccessibilityServiceEnabled()) {
onPreferenceClick(isChecked); onPreferenceClick(isChecked);
} }

View File

@@ -44,9 +44,8 @@ import android.view.ViewGroup;
import android.view.accessibility.AccessibilityManager; import android.view.accessibility.AccessibilityManager;
import android.view.accessibility.AccessibilityManager.TouchExplorationStateChangeListener; import android.view.accessibility.AccessibilityManager.TouchExplorationStateChangeListener;
import android.widget.CheckBox; import android.widget.CheckBox;
import android.widget.CompoundButton;
import android.widget.CompoundButton.OnCheckedChangeListener;
import android.widget.ImageView; import android.widget.ImageView;
import android.widget.Switch;
import androidx.annotation.Nullable; import androidx.annotation.Nullable;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
@@ -65,6 +64,7 @@ import com.android.settings.utils.LocaleUtils;
import com.android.settings.widget.SettingsMainSwitchBar; import com.android.settings.widget.SettingsMainSwitchBar;
import com.android.settings.widget.SettingsMainSwitchPreference; import com.android.settings.widget.SettingsMainSwitchPreference;
import com.android.settingslib.widget.IllustrationPreference; import com.android.settingslib.widget.IllustrationPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import com.android.settingslib.widget.TopIntroPreference; import com.android.settingslib.widget.TopIntroPreference;
import com.google.android.setupcompat.util.WizardManagerHelper; import com.google.android.setupcompat.util.WizardManagerHelper;
@@ -78,7 +78,7 @@ import java.util.Locale;
* and dialog management. * and dialog management.
*/ */
public abstract class ToggleFeaturePreferenceFragment extends DashboardFragment public abstract class ToggleFeaturePreferenceFragment extends DashboardFragment
implements ShortcutPreference.OnClickCallback, OnCheckedChangeListener { implements ShortcutPreference.OnClickCallback, OnMainSwitchChangeListener {
public static final String KEY_GENERAL_CATEGORY = "general_categories"; public static final String KEY_GENERAL_CATEGORY = "general_categories";
public static final String KEY_SHORTCUT_PREFERENCE = "shortcut_preference"; public static final String KEY_SHORTCUT_PREFERENCE = "shortcut_preference";
@@ -328,7 +328,7 @@ public abstract class ToggleFeaturePreferenceFragment extends DashboardFragment
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
onPreferenceToggled(mPreferenceKey, isChecked); onPreferenceToggled(mPreferenceKey, isChecked);
} }

View File

@@ -16,8 +16,7 @@
package com.android.settings.accounts; package com.android.settings.accounts;
import android.content.Context; import android.content.Context;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.lifecycle.DefaultLifecycleObserver; import androidx.lifecycle.DefaultLifecycleObserver;
import androidx.lifecycle.LifecycleOwner; import androidx.lifecycle.LifecycleOwner;
@@ -28,13 +27,14 @@ import com.android.settings.R;
import com.android.settings.core.BasePreferenceController; import com.android.settings.core.BasePreferenceController;
import com.android.settings.slices.SliceData; import com.android.settings.slices.SliceData;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.NotNull;
/** Controller for "Work apps" toggle that allows the user to enable/disable quiet mode. */ /** Controller for "Work apps" toggle that allows the user to enable/disable quiet mode. */
public class WorkModePreferenceController extends BasePreferenceController public class WorkModePreferenceController extends BasePreferenceController
implements OnCheckedChangeListener, DefaultLifecycleObserver, implements OnMainSwitchChangeListener, DefaultLifecycleObserver,
ManagedProfileQuietModeEnabler.QuietModeChangeListener { ManagedProfileQuietModeEnabler.QuietModeChangeListener {
private final ManagedProfileQuietModeEnabler mQuietModeEnabler; private final ManagedProfileQuietModeEnabler mQuietModeEnabler;
@@ -68,7 +68,7 @@ public class WorkModePreferenceController extends BasePreferenceController
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
mQuietModeEnabler.setQuietModeEnabled(!isChecked); mQuietModeEnabler.setQuietModeEnabled(!isChecked);
} }

View File

@@ -35,8 +35,7 @@ import android.util.ArraySet;
import android.util.Log; import android.util.Log;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import android.widget.TextView; import android.widget.TextView;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
@@ -52,6 +51,7 @@ import com.android.settings.widget.EntityHeaderController;
import com.android.settingslib.applications.AppUtils; import com.android.settingslib.applications.AppUtils;
import com.android.settingslib.widget.FooterPreference; import com.android.settingslib.widget.FooterPreference;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import java.util.HashMap; import java.util.HashMap;
import java.util.List; import java.util.List;
@@ -62,7 +62,7 @@ import java.util.UUID;
/** The page of the Open by default */ /** The page of the Open by default */
public class AppLaunchSettings extends AppInfoBase implements public class AppLaunchSettings extends AppInfoBase implements
Preference.OnPreferenceChangeListener, OnCheckedChangeListener { Preference.OnPreferenceChangeListener, OnMainSwitchChangeListener {
private static final String TAG = "AppLaunchSettings"; private static final String TAG = "AppLaunchSettings";
// Preference keys // Preference keys
private static final String MAIN_SWITCH_PREF_KEY = "open_by_default_supported_links"; private static final String MAIN_SWITCH_PREF_KEY = "open_by_default_supported_links";
@@ -168,7 +168,7 @@ public class AppLaunchSettings extends AppInfoBase implements
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
IntentPickerUtils.logd("onSwitchChanged: isChecked=" + isChecked); IntentPickerUtils.logd("onSwitchChanged: isChecked=" + isChecked);
if (mMainSwitchPreference != null) { //mMainSwitchPreference synced with Switch if (mMainSwitchPreference != null) { //mMainSwitchPreference synced with Switch
mMainSwitchPreference.setChecked(isChecked); mMainSwitchPreference.setChecked(isChecked);

View File

@@ -25,7 +25,7 @@ import android.provider.Settings;
import android.util.Log; import android.util.Log;
import androidx.preference.Preference; import androidx.preference.Preference;
import androidx.preference.TwoStatePreference; import androidx.preference.SwitchPreference;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.TogglePreferenceController; import com.android.settings.core.TogglePreferenceController;
@@ -79,7 +79,7 @@ public class AutoRestorePreferenceController extends TogglePreferenceController
backupManager.setAutoRestore(nextValue); backupManager.setAutoRestore(nextValue);
result = true; result = true;
} catch (RemoteException e) { } catch (RemoteException e) {
((TwoStatePreference) mPreference).setChecked(!nextValue); ((SwitchPreference) mPreference).setChecked(!nextValue);
Log.e(TAG, "Error can't set setAutoRestore", e); Log.e(TAG, "Error can't set setAutoRestore", e);
} }

View File

@@ -11,6 +11,7 @@ import android.os.ServiceManager;
import android.provider.Settings; import android.provider.Settings;
import android.util.Log; import android.util.Log;
import android.view.View; import android.view.View;
import android.widget.Switch;
import android.widget.TextView; import android.widget.TextView;
import androidx.appcompat.app.AlertDialog; import androidx.appcompat.app.AlertDialog;
@@ -115,7 +116,8 @@ public class ToggleBackupSettingFragment extends SettingsPreferenceFragment
mSwitchBar.setOnBeforeCheckedChangeListener( mSwitchBar.setOnBeforeCheckedChangeListener(
new SettingsMainSwitchBar.OnBeforeCheckedChangeListener() { new SettingsMainSwitchBar.OnBeforeCheckedChangeListener() {
@Override @Override
public boolean onBeforeCheckedChanged(boolean checked) { public boolean onBeforeCheckedChanged(
Switch toggleSwitch, boolean checked) {
if (!checked) { if (!checked) {
// Don't change Switch status until user makes choice in dialog // Don't change Switch status until user makes choice in dialog
// so return true here. // so return true here.

View File

@@ -25,8 +25,7 @@ import android.bluetooth.BluetoothLeBroadcastReceiveState;
import android.bluetooth.BluetoothProfile; import android.bluetooth.BluetoothProfile;
import android.content.Context; import android.content.Context;
import android.util.Log; import android.util.Log;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
import androidx.lifecycle.DefaultLifecycleObserver; import androidx.lifecycle.DefaultLifecycleObserver;
@@ -43,6 +42,7 @@ import com.android.settingslib.bluetooth.LocalBluetoothLeBroadcast;
import com.android.settingslib.bluetooth.LocalBluetoothLeBroadcastAssistant; import com.android.settingslib.bluetooth.LocalBluetoothLeBroadcastAssistant;
import com.android.settingslib.bluetooth.LocalBluetoothManager; import com.android.settingslib.bluetooth.LocalBluetoothManager;
import com.android.settingslib.utils.ThreadUtils; import com.android.settingslib.utils.ThreadUtils;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableList;
@@ -55,7 +55,7 @@ import java.util.concurrent.Executor;
import java.util.concurrent.Executors; import java.util.concurrent.Executors;
public class AudioSharingSwitchBarController extends BasePreferenceController public class AudioSharingSwitchBarController extends BasePreferenceController
implements DefaultLifecycleObserver, OnCheckedChangeListener { implements DefaultLifecycleObserver, OnMainSwitchChangeListener {
private static final String TAG = "AudioSharingSwitchBarCtl"; private static final String TAG = "AudioSharingSwitchBarCtl";
private static final String PREF_KEY = "audio_sharing_main_switch"; private static final String PREF_KEY = "audio_sharing_main_switch";
private final SettingsMainSwitchBar mSwitchBar; private final SettingsMainSwitchBar mSwitchBar;
@@ -229,9 +229,9 @@ public class AudioSharingSwitchBarController extends BasePreferenceController
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
// Filter out unnecessary callbacks when switch is disabled. // Filter out unnecessary callbacks when switch is disabled.
if (!buttonView.isEnabled()) return; if (!switchView.isEnabled()) return;
if (isChecked) { if (isChecked) {
startAudioSharing(); startAudioSharing();
} else { } else {

View File

@@ -19,6 +19,7 @@ import android.app.settings.SettingsEnums
import android.content.Context import android.content.Context
import android.os.Bundle import android.os.Bundle
import android.telephony.SubscriptionManager import android.telephony.SubscriptionManager
import android.widget.Switch
import com.android.settings.R import com.android.settings.R
import com.android.settings.SettingsActivity import com.android.settings.SettingsActivity
import com.android.settings.dashboard.DashboardFragment import com.android.settings.dashboard.DashboardFragment
@@ -50,7 +51,9 @@ class DataSaverSummary : DashboardFragment() {
switchBar = (activity as SettingsActivity).switchBar.apply { switchBar = (activity as SettingsActivity).switchBar.apply {
setTitle(getString(R.string.data_saver_switch_title)) setTitle(getString(R.string.data_saver_switch_title))
show() show()
addOnSwitchChangeListener { _, isChecked -> onSwitchChanged(isChecked) } addOnSwitchChangeListener { _: Switch, isChecked: Boolean ->
onSwitchChanged(isChecked)
}
} }
} }
@@ -102,4 +105,4 @@ class DataSaverSummary : DashboardFragment() {
SubscriptionManager.INVALID_SUBSCRIPTION_ID) SubscriptionManager.INVALID_SUBSCRIPTION_ID)
} }
} }
} }

View File

@@ -20,8 +20,7 @@ import android.app.settings.SettingsEnums;
import android.content.Context; import android.content.Context;
import android.os.SystemProperties; import android.os.SystemProperties;
import android.provider.Settings; import android.provider.Settings;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.fragment.app.FragmentManager; import androidx.fragment.app.FragmentManager;
import androidx.preference.Preference; import androidx.preference.Preference;
@@ -30,10 +29,11 @@ import com.android.internal.util.Preconditions;
import com.android.settings.widget.SettingsMainSwitchBar; import com.android.settings.widget.SettingsMainSwitchBar;
import com.android.settingslib.Utils; import com.android.settingslib.Utils;
import com.android.settingslib.core.instrumentation.MetricsFeatureProvider; import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
/** Handles the logic for flipping the storage management toggle on a {@link SwitchBar}. */ /** Handles the logic for flipping the storage management toggle on a {@link SwitchBar}. */
public class AutomaticStorageManagerSwitchBarController public class AutomaticStorageManagerSwitchBarController
implements OnCheckedChangeListener { implements OnMainSwitchChangeListener {
private static final String STORAGE_MANAGER_ENABLED_BY_DEFAULT_PROPERTY = private static final String STORAGE_MANAGER_ENABLED_BY_DEFAULT_PROPERTY =
"ro.storage_manager.enabled"; "ro.storage_manager.enabled";
@@ -64,7 +64,7 @@ public class AutomaticStorageManagerSwitchBarController
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
mMetrics.action(mContext, SettingsEnums.ACTION_TOGGLE_STORAGE_MANAGER, isChecked); mMetrics.action(mContext, SettingsEnums.ACTION_TOGGLE_STORAGE_MANAGER, isChecked);
mDaysToRetainPreference.setEnabled(isChecked); mDaysToRetainPreference.setEnabled(isChecked);
Settings.Secure.putInt( Settings.Secure.putInt(

View File

@@ -45,8 +45,7 @@ import android.util.Log;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
import androidx.localbroadcastmanager.content.LocalBroadcastManager; import androidx.localbroadcastmanager.content.LocalBroadcastManager;
@@ -81,6 +80,7 @@ import com.android.settingslib.development.DeveloperOptionsPreferenceController;
import com.android.settingslib.development.DevelopmentSettingsEnabler; import com.android.settingslib.development.DevelopmentSettingsEnabler;
import com.android.settingslib.development.SystemPropPoker; import com.android.settingslib.development.SystemPropPoker;
import com.android.settingslib.search.SearchIndexable; import com.android.settingslib.search.SearchIndexable;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import com.google.android.setupcompat.util.WizardManagerHelper; import com.google.android.setupcompat.util.WizardManagerHelper;
@@ -89,7 +89,7 @@ import java.util.List;
@SearchIndexable(forTarget = SearchIndexable.ALL & ~SearchIndexable.ARC) @SearchIndexable(forTarget = SearchIndexable.ALL & ~SearchIndexable.ARC)
public class DevelopmentSettingsDashboardFragment extends RestrictedDashboardFragment public class DevelopmentSettingsDashboardFragment extends RestrictedDashboardFragment
implements OnCheckedChangeListener, OemUnlockDialogHost, AdbDialogHost, implements OnMainSwitchChangeListener, OemUnlockDialogHost, AdbDialogHost,
AdbClearKeysDialogHost, LogPersistDialogHost, AdbClearKeysDialogHost, LogPersistDialogHost,
BluetoothRebootDialog.OnRebootDialogListener, BluetoothRebootDialog.OnRebootDialogListener,
AbstractBluetoothPreferenceController.Callback, AbstractBluetoothPreferenceController.Callback,
@@ -333,7 +333,7 @@ public class DevelopmentSettingsDashboardFragment extends RestrictedDashboardFra
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
final boolean developmentEnabledState = final boolean developmentEnabledState =
DevelopmentSettingsEnabler.isDevelopmentSettingsEnabled(getContext()); DevelopmentSettingsEnabler.isDevelopmentSettingsEnabled(getContext());
if (isChecked != developmentEnabledState) { if (isChecked != developmentEnabledState) {

View File

@@ -17,18 +17,18 @@
package com.android.settings.display; package com.android.settings.display;
import android.content.Context; import android.content.Context;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settings.widget.SettingsMainSwitchPreference; import com.android.settings.widget.SettingsMainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
/** /**
* Controller that updates the adaptive brightness. * Controller that updates the adaptive brightness.
*/ */
public class AutoBrightnessDetailPreferenceController extends public class AutoBrightnessDetailPreferenceController extends
AutoBrightnessPreferenceController implements OnCheckedChangeListener { AutoBrightnessPreferenceController implements OnMainSwitchChangeListener {
public AutoBrightnessDetailPreferenceController(Context context, String key) { public AutoBrightnessDetailPreferenceController(Context context, String key) {
super(context, key); super(context, key);
@@ -58,7 +58,7 @@ public class AutoBrightnessDetailPreferenceController extends
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
if (isChecked != isChecked()) { if (isChecked != isChecked()) {
setChecked(isChecked); setChecked(isChecked);
} }

View File

@@ -19,8 +19,7 @@ package com.android.settings.display;
import android.content.Context; import android.content.Context;
import android.hardware.display.ColorDisplayManager; import android.hardware.display.ColorDisplayManager;
import android.text.TextUtils; import android.text.TextUtils;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.preference.Preference; import androidx.preference.Preference;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
@@ -30,12 +29,13 @@ import com.android.settings.core.TogglePreferenceController;
import com.android.settings.overlay.FeatureFactory; import com.android.settings.overlay.FeatureFactory;
import com.android.settingslib.core.instrumentation.MetricsFeatureProvider; import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
/** /**
* Controller that updates the night display. * Controller that updates the night display.
*/ */
public class NightDisplayActivationPreferenceController extends public class NightDisplayActivationPreferenceController extends
TogglePreferenceController implements OnCheckedChangeListener { TogglePreferenceController implements OnMainSwitchChangeListener {
private final MetricsFeatureProvider mMetricsFeatureProvider; private final MetricsFeatureProvider mMetricsFeatureProvider;
private ColorDisplayManager mColorDisplayManager; private ColorDisplayManager mColorDisplayManager;
@@ -81,7 +81,7 @@ public class NightDisplayActivationPreferenceController extends
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
final boolean activated = mColorDisplayManager.isNightDisplayActivated(); final boolean activated = mColorDisplayManager.isNightDisplayActivated();
if (isChecked != activated) { if (isChecked != activated) {
// TODO(b/179017365): Create a controller which extends TogglePreferenceController to // TODO(b/179017365): Create a controller which extends TogglePreferenceController to

View File

@@ -18,8 +18,7 @@ package com.android.settings.display.darkmode;
import android.app.UiModeManager; import android.app.UiModeManager;
import android.content.Context; import android.content.Context;
import android.content.res.Configuration; import android.content.res.Configuration;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.preference.Preference; import androidx.preference.Preference;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
@@ -29,6 +28,7 @@ import com.android.settings.core.BasePreferenceController;
import com.android.settings.overlay.FeatureFactory; import com.android.settings.overlay.FeatureFactory;
import com.android.settingslib.core.instrumentation.MetricsFeatureProvider; import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import java.time.LocalTime; import java.time.LocalTime;
@@ -36,7 +36,7 @@ import java.time.LocalTime;
* Controller for activate/deactivate night mode button * Controller for activate/deactivate night mode button
*/ */
public class DarkModeActivationPreferenceController extends BasePreferenceController implements public class DarkModeActivationPreferenceController extends BasePreferenceController implements
OnCheckedChangeListener { OnMainSwitchChangeListener {
private final UiModeManager mUiModeManager; private final UiModeManager mUiModeManager;
private final MetricsFeatureProvider mMetricsFeatureProvider; private final MetricsFeatureProvider mMetricsFeatureProvider;
@@ -96,7 +96,7 @@ public class DarkModeActivationPreferenceController extends BasePreferenceContro
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
mMetricsFeatureProvider.logClickedPreference(mPreference, getMetricsCategory()); mMetricsFeatureProvider.logClickedPreference(mPreference, getMetricsCategory());
final boolean active = (mContext.getResources().getConfiguration().uiMode final boolean active = (mContext.getResources().getConfiguration().uiMode
& Configuration.UI_MODE_NIGHT_YES) != 0; & Configuration.UI_MODE_NIGHT_YES) != 0;

View File

@@ -29,8 +29,7 @@ import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import android.widget.Button; import android.widget.Button;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
import androidx.preference.Preference; import androidx.preference.Preference;
@@ -45,12 +44,13 @@ import com.android.settingslib.dream.DreamBackend;
import com.android.settingslib.dream.DreamBackend.WhenToDream; import com.android.settingslib.dream.DreamBackend.WhenToDream;
import com.android.settingslib.search.SearchIndexable; import com.android.settingslib.search.SearchIndexable;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
@SearchIndexable @SearchIndexable
public class DreamSettings extends DashboardFragment implements OnCheckedChangeListener { public class DreamSettings extends DashboardFragment implements OnMainSwitchChangeListener {
private static final String TAG = "DreamSettings"; private static final String TAG = "DreamSettings";
static final String WHILE_CHARGING_ONLY = "while_charging_only"; static final String WHILE_CHARGING_ONLY = "while_charging_only";
@@ -246,7 +246,7 @@ public class DreamSettings extends DashboardFragment implements OnCheckedChangeL
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
setAllPreferencesEnabled(isChecked); setAllPreferencesEnabled(isChecked);
mPreviewButton.setVisibility(isChecked ? View.VISIBLE : View.GONE); mPreviewButton.setVisibility(isChecked ? View.VISIBLE : View.GONE);
updatePaddingForPreviewButton(); updatePaddingForPreviewButton();

View File

@@ -17,8 +17,7 @@
package com.android.settings.emergency; package com.android.settings.emergency;
import android.content.Context; import android.content.Context;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
import androidx.preference.Preference; import androidx.preference.Preference;
@@ -28,12 +27,13 @@ import com.android.settings.R;
import com.android.settings.core.BasePreferenceController; import com.android.settings.core.BasePreferenceController;
import com.android.settingslib.emergencynumber.EmergencyNumberUtils; import com.android.settingslib.emergencynumber.EmergencyNumberUtils;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
/** /**
* Preference controller for emergency gesture setting * Preference controller for emergency gesture setting
*/ */
public class EmergencyGesturePreferenceController extends BasePreferenceController implements public class EmergencyGesturePreferenceController extends BasePreferenceController implements
OnCheckedChangeListener { OnMainSwitchChangeListener {
@VisibleForTesting @VisibleForTesting
EmergencyNumberUtils mEmergencyNumberUtils; EmergencyNumberUtils mEmergencyNumberUtils;
@@ -72,7 +72,7 @@ public class EmergencyGesturePreferenceController extends BasePreferenceControll
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
mEmergencyNumberUtils.setEmergencyGestureEnabled(isChecked); mEmergencyNumberUtils.setEmergencyGestureEnabled(isChecked);
} }
} }

View File

@@ -28,8 +28,7 @@ import android.os.UserHandle;
import android.text.TextUtils; import android.text.TextUtils;
import android.util.Log; import android.util.Log;
import android.view.View; import android.view.View;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
@@ -45,6 +44,7 @@ import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.widget.FooterPreference; import com.android.settingslib.widget.FooterPreference;
import com.android.settingslib.widget.LayoutPreference; import com.android.settingslib.widget.LayoutPreference;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import com.android.settingslib.widget.SelectorWithWidgetPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import java.util.ArrayList; import java.util.ArrayList;
@@ -54,7 +54,7 @@ import java.util.concurrent.Executors;
/** Allow background usage fragment for each app */ /** Allow background usage fragment for each app */
public class PowerBackgroundUsageDetail extends DashboardFragment public class PowerBackgroundUsageDetail extends DashboardFragment
implements SelectorWithWidgetPreference.OnClickListener, OnCheckedChangeListener { implements SelectorWithWidgetPreference.OnClickListener, OnMainSwitchChangeListener {
private static final String TAG = "PowerBackgroundUsageDetail"; private static final String TAG = "PowerBackgroundUsageDetail";
public static final String EXTRA_UID = "extra_uid"; public static final String EXTRA_UID = "extra_uid";
@@ -155,7 +155,7 @@ public class PowerBackgroundUsageDetail extends DashboardFragment
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
mMainSwitchPreference.setChecked(isChecked); mMainSwitchPreference.setChecked(isChecked);
updateSelectorPreference(isChecked); updateSelectorPreference(isChecked);
} }

View File

@@ -18,8 +18,7 @@ package com.android.settings.gestures;
import android.content.Context; import android.content.Context;
import android.provider.Settings; import android.provider.Settings;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
import androidx.preference.Preference; import androidx.preference.Preference;
@@ -29,9 +28,10 @@ import com.android.settings.R;
import com.android.settings.core.PreferenceControllerMixin; import com.android.settings.core.PreferenceControllerMixin;
import com.android.settingslib.core.AbstractPreferenceController; import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
public class PreventRingingSwitchPreferenceController extends AbstractPreferenceController public class PreventRingingSwitchPreferenceController extends AbstractPreferenceController
implements PreferenceControllerMixin, OnCheckedChangeListener { implements PreferenceControllerMixin, OnMainSwitchChangeListener {
private static final String KEY = "gesture_prevent_ringing_switch"; private static final String KEY = "gesture_prevent_ringing_switch";
private final Context mContext; private final Context mContext;
@@ -94,7 +94,7 @@ public class PreventRingingSwitchPreferenceController extends AbstractPreference
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
final int preventRingingSetting = Settings.Secure.getInt(mContext.getContentResolver(), final int preventRingingSetting = Settings.Secure.getInt(mContext.getContentResolver(),
Settings.Secure.VOLUME_HUSH_GESTURE, Settings.Secure.VOLUME_HUSH_VIBRATE); Settings.Secure.VOLUME_HUSH_GESTURE, Settings.Secure.VOLUME_HUSH_VIBRATE);
final int newRingingSetting = preventRingingSetting == Settings.Secure.VOLUME_HUSH_OFF final int newRingingSetting = preventRingingSetting == Settings.Secure.VOLUME_HUSH_OFF

View File

@@ -26,8 +26,7 @@ import android.util.Log;
import android.view.textservice.SpellCheckerInfo; import android.view.textservice.SpellCheckerInfo;
import android.view.textservice.SpellCheckerSubtype; import android.view.textservice.SpellCheckerSubtype;
import android.view.textservice.TextServicesManager; import android.view.textservice.TextServicesManager;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.appcompat.app.AlertDialog; import androidx.appcompat.app.AlertDialog;
import androidx.preference.Preference; import androidx.preference.Preference;
@@ -38,9 +37,10 @@ import com.android.settings.R;
import com.android.settings.SettingsActivity; import com.android.settings.SettingsActivity;
import com.android.settings.SettingsPreferenceFragment; import com.android.settings.SettingsPreferenceFragment;
import com.android.settings.widget.SettingsMainSwitchBar; import com.android.settings.widget.SettingsMainSwitchBar;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
public class SpellCheckersSettings extends SettingsPreferenceFragment public class SpellCheckersSettings extends SettingsPreferenceFragment
implements OnCheckedChangeListener, OnPreferenceChangeListener { implements OnMainSwitchChangeListener, OnPreferenceChangeListener {
private static final String TAG = SpellCheckersSettings.class.getSimpleName(); private static final String TAG = SpellCheckersSettings.class.getSimpleName();
private static final boolean DBG = false; private static final boolean DBG = false;
@@ -105,7 +105,7 @@ public class SpellCheckersSettings extends SettingsPreferenceFragment
} }
@Override @Override
public void onCheckedChanged(final CompoundButton buttonView, final boolean isChecked) { public void onSwitchChanged(final Switch switchView, final boolean isChecked) {
Settings.Secure.putInt(getContentResolver(), Settings.Secure.SPELL_CHECKER_ENABLED, Settings.Secure.putInt(getContentResolver(), Settings.Secure.SPELL_CHECKER_ENABLED,
isChecked ? 1 : 0); isChecked ? 1 : 0);
updatePreferenceScreen(); updatePreferenceScreen();

View File

@@ -16,22 +16,22 @@
package com.android.settings.location; package com.android.settings.location;
import android.content.Context; import android.content.Context;
import android.os.UserManager;
import android.provider.Settings; import android.provider.Settings;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener; import android.os.UserManager;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.TogglePreferenceController; import com.android.settings.core.TogglePreferenceController;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
/** /**
* Preference controller for Bluetooth scanning main switch. * Preference controller for Bluetooth scanning main switch.
*/ */
public class BluetoothScanningMainSwitchPreferenceController extends TogglePreferenceController public class BluetoothScanningMainSwitchPreferenceController extends TogglePreferenceController
implements OnCheckedChangeListener { implements OnMainSwitchChangeListener {
private static final String KEY_BLUETOOTH_SCANNING_SWITCH = "bluetooth_always_scanning_switch"; private static final String KEY_BLUETOOTH_SCANNING_SWITCH = "bluetooth_always_scanning_switch";
private final UserManager mUserManager; private final UserManager mUserManager;
@@ -78,7 +78,7 @@ public class BluetoothScanningMainSwitchPreferenceController extends TogglePrefe
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
if (isChecked != isChecked()) { if (isChecked != isChecked()) {
setChecked(isChecked); setChecked(isChecked);
} }

View File

@@ -16,8 +16,7 @@ package com.android.settings.location;
import android.content.Context; import android.content.Context;
import android.os.UserHandle; import android.os.UserHandle;
import android.os.UserManager; import android.os.UserManager;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import com.android.settings.widget.SettingsMainSwitchBar; import com.android.settings.widget.SettingsMainSwitchBar;
import com.android.settingslib.RestrictedLockUtils; import com.android.settingslib.RestrictedLockUtils;
@@ -25,11 +24,12 @@ import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.core.lifecycle.LifecycleObserver; import com.android.settingslib.core.lifecycle.LifecycleObserver;
import com.android.settingslib.core.lifecycle.events.OnStart; import com.android.settingslib.core.lifecycle.events.OnStart;
import com.android.settingslib.core.lifecycle.events.OnStop; import com.android.settingslib.core.lifecycle.events.OnStop;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
/** /**
* The switch controller for the location. * The switch controller for the location.
*/ */
public class LocationSwitchBarController implements OnCheckedChangeListener, public class LocationSwitchBarController implements OnMainSwitchChangeListener,
LocationEnabler.LocationModeChangeListener, LifecycleObserver, OnStart, OnStop { LocationEnabler.LocationModeChangeListener, LifecycleObserver, OnStart, OnStop {
private final SettingsMainSwitchBar mSwitchBar; private final SettingsMainSwitchBar mSwitchBar;
@@ -100,7 +100,7 @@ public class LocationSwitchBarController implements OnCheckedChangeListener,
* Listens to the state change of the location primary switch. * Listens to the state change of the location primary switch.
*/ */
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
mLocationEnabler.setLocationEnabled(isChecked); mLocationEnabler.setLocationEnabled(isChecked);
} }
} }

View File

@@ -17,21 +17,21 @@ package com.android.settings.location;
import android.content.Context; import android.content.Context;
import android.net.wifi.WifiManager; import android.net.wifi.WifiManager;
import android.widget.Switch;
import android.os.UserManager; import android.os.UserManager;
import android.widget.CompoundButton;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.TogglePreferenceController; import com.android.settings.core.TogglePreferenceController;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
/** /**
* Preference controller for Wi-Fi scanning main switch. * Preference controller for Wi-Fi scanning main switch.
*/ */
public class WifiScanningMainSwitchPreferenceController extends TogglePreferenceController public class WifiScanningMainSwitchPreferenceController extends TogglePreferenceController
implements OnCheckedChangeListener { implements OnMainSwitchChangeListener {
private static final String KEY_WIFI_SCANNING_SWITCH = "wifi_always_scanning_switch"; private static final String KEY_WIFI_SCANNING_SWITCH = "wifi_always_scanning_switch";
private final WifiManager mWifiManager; private final WifiManager mWifiManager;
@@ -79,7 +79,7 @@ public class WifiScanningMainSwitchPreferenceController extends TogglePreference
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
if (isChecked != isChecked()) { if (isChecked != isChecked()) {
setChecked(isChecked); setChecked(isChecked);
} }

View File

@@ -86,7 +86,7 @@ public class MobileNetworkSwitchController extends BasePreferenceController impl
super.displayPreference(screen); super.displayPreference(screen);
mSwitchBar = (SettingsMainSwitchPreference) screen.findPreference(mPreferenceKey); mSwitchBar = (SettingsMainSwitchPreference) screen.findPreference(mPreferenceKey);
mSwitchBar.setOnBeforeCheckedChangeListener((isChecked) -> { mSwitchBar.setOnBeforeCheckedChangeListener((toggleSwitch, isChecked) -> {
// TODO b/135222940: re-evaluate whether to use // TODO b/135222940: re-evaluate whether to use
// mSubscriptionManager#isSubscriptionEnabled // mSubscriptionManager#isSubscriptionEnabled
if (mSubscriptionManager.isActiveSubscriptionId(mSubId) != isChecked) { if (mSubscriptionManager.isActiveSubscriptionId(mSubId) != isChecked) {

View File

@@ -22,8 +22,7 @@ import android.content.IntentFilter;
import android.net.Uri; import android.net.Uri;
import android.nfc.NfcAdapter; import android.nfc.NfcAdapter;
import android.util.Log; import android.util.Log;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
@@ -34,11 +33,12 @@ import com.android.settingslib.core.lifecycle.LifecycleObserver;
import com.android.settingslib.core.lifecycle.events.OnPause; import com.android.settingslib.core.lifecycle.events.OnPause;
import com.android.settingslib.core.lifecycle.events.OnResume; import com.android.settingslib.core.lifecycle.events.OnResume;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import java.io.IOException; import java.io.IOException;
public class NfcPreferenceController extends TogglePreferenceController public class NfcPreferenceController extends TogglePreferenceController
implements LifecycleObserver, OnResume, OnPause, OnCheckedChangeListener { implements LifecycleObserver, OnResume, OnPause, OnMainSwitchChangeListener {
public static final String KEY_TOGGLE_NFC = "toggle_nfc"; public static final String KEY_TOGGLE_NFC = "toggle_nfc";
private final NfcAdapter mNfcAdapter; private final NfcAdapter mNfcAdapter;
@@ -64,7 +64,7 @@ public class NfcPreferenceController extends TogglePreferenceController
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
if (isChecked != mNfcAdapter.isEnabled()) { if (isChecked != mNfcAdapter.isEnabled()) {
setChecked(isChecked); setChecked(isChecked);
} }

View File

@@ -23,8 +23,7 @@ import static android.app.NotificationManager.IMPORTANCE_UNSPECIFIED;
import android.app.NotificationChannel; import android.app.NotificationChannel;
import android.app.NotificationManager; import android.app.NotificationManager;
import android.content.Context; import android.content.Context;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.preference.Preference; import androidx.preference.Preference;
@@ -32,9 +31,10 @@ import com.android.settings.R;
import com.android.settings.core.PreferenceControllerMixin; import com.android.settings.core.PreferenceControllerMixin;
import com.android.settings.notification.NotificationBackend; import com.android.settings.notification.NotificationBackend;
import com.android.settings.widget.SettingsMainSwitchPreference; import com.android.settings.widget.SettingsMainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
public class BlockPreferenceController extends NotificationPreferenceController public class BlockPreferenceController extends NotificationPreferenceController
implements PreferenceControllerMixin, OnCheckedChangeListener { implements PreferenceControllerMixin, OnMainSwitchChangeListener {
private static final String KEY_BLOCK = "block"; private static final String KEY_BLOCK = "block";
private NotificationSettings.DependentFieldListener mDependentFieldListener; private NotificationSettings.DependentFieldListener mDependentFieldListener;
@@ -104,7 +104,7 @@ public class BlockPreferenceController extends NotificationPreferenceController
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
boolean blocked = !isChecked; boolean blocked = !isChecked;
if (mChannel != null) { if (mChannel != null) {
final int originalImportance = mChannel.getImportance(); final int originalImportance = mChannel.getImportance();

View File

@@ -47,7 +47,6 @@ import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import android.view.ViewOutlineProvider; import android.view.ViewOutlineProvider;
import android.widget.CompoundButton.OnCheckedChangeListener;
import android.widget.ImageView; import android.widget.ImageView;
import android.widget.TextView; import android.widget.TextView;
@@ -65,6 +64,7 @@ import com.android.settingslib.collapsingtoolbar.CollapsingToolbarBaseActivity;
import com.android.settingslib.utils.StringUtil; import com.android.settingslib.utils.StringUtil;
import com.android.settingslib.utils.ThreadUtils; import com.android.settingslib.utils.ThreadUtils;
import com.android.settingslib.widget.MainSwitchBar; import com.android.settingslib.widget.MainSwitchBar;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
@@ -355,7 +355,7 @@ public class NotificationHistoryActivity extends CollapsingToolbarBaseActivity {
mHistoryEmpty.setVisibility(View.GONE); mHistoryEmpty.setVisibility(View.GONE);
} }
private final OnCheckedChangeListener mOnSwitchClickListener = private final OnMainSwitchChangeListener mOnSwitchClickListener =
(switchView, isChecked) -> { (switchView, isChecked) -> {
int oldState = 0; int oldState = 0;
try { try {

View File

@@ -18,8 +18,7 @@ package com.android.settings.notification.zen;
import android.app.AutomaticZenRule; import android.app.AutomaticZenRule;
import android.content.Context; import android.content.Context;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.fragment.app.Fragment; import androidx.fragment.app.Fragment;
import androidx.preference.Preference; import androidx.preference.Preference;
@@ -28,10 +27,11 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
public class ZenAutomaticRuleSwitchPreferenceController extends public class ZenAutomaticRuleSwitchPreferenceController extends
AbstractZenModeAutomaticRulePreferenceController implements AbstractZenModeAutomaticRulePreferenceController implements
OnCheckedChangeListener { OnMainSwitchChangeListener {
private static final String KEY = "zen_automatic_rule_switch"; private static final String KEY = "zen_automatic_rule_switch";
private AutomaticZenRule mRule; private AutomaticZenRule mRule;
@@ -86,7 +86,7 @@ public class ZenAutomaticRuleSwitchPreferenceController extends
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
final boolean enabled = isChecked; final boolean enabled = isChecked;
if (enabled == mRule.isEnabled()) return; if (enabled == mRule.isEnabled()) return;
mRule.setEnabled(enabled); mRule.setEnabled(enabled);

View File

@@ -43,13 +43,12 @@ import android.view.View;
import android.view.View.OnClickListener; import android.view.View.OnClickListener;
import android.view.ViewGroup; import android.view.ViewGroup;
import android.view.accessibility.AccessibilityManager; import android.view.accessibility.AccessibilityManager;
import android.widget.CompoundButton;
import android.widget.CompoundButton.OnCheckedChangeListener;
import android.widget.Filter; import android.widget.Filter;
import android.widget.Filterable; import android.widget.Filterable;
import android.widget.ImageView; import android.widget.ImageView;
import android.widget.LinearLayout; import android.widget.LinearLayout;
import android.widget.SearchView; import android.widget.SearchView;
import android.widget.Switch;
import android.widget.TextView; import android.widget.TextView;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
@@ -62,6 +61,7 @@ import com.android.settings.R;
import com.android.settings.SettingsActivity; import com.android.settings.SettingsActivity;
import com.android.settings.SettingsPreferenceFragment; import com.android.settings.SettingsPreferenceFragment;
import com.android.settings.widget.SettingsMainSwitchBar; import com.android.settings.widget.SettingsMainSwitchBar;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.LinkedHashMap; import java.util.LinkedHashMap;
@@ -72,7 +72,7 @@ import java.util.Map;
* Fragment with print service settings. * Fragment with print service settings.
*/ */
public class PrintServiceSettingsFragment extends SettingsPreferenceFragment public class PrintServiceSettingsFragment extends SettingsPreferenceFragment
implements OnCheckedChangeListener, implements OnMainSwitchChangeListener,
LoaderManager.LoaderCallbacks<List<PrintServiceInfo>> { LoaderManager.LoaderCallbacks<List<PrintServiceInfo>> {
private static final String LOG_TAG = "PrintServiceSettings"; private static final String LOG_TAG = "PrintServiceSettings";
@@ -240,7 +240,7 @@ public class PrintServiceSettingsFragment extends SettingsPreferenceFragment
mSwitchBar.addOnSwitchChangeListener(this); mSwitchBar.addOnSwitchChangeListener(this);
mSwitchBar.show(); mSwitchBar.show();
mSwitchBar.setOnBeforeCheckedChangeListener((checked) -> { mSwitchBar.setOnBeforeCheckedChangeListener((toggleSwitch, checked) -> {
onPreferenceToggled(mPreferenceKey, checked); onPreferenceToggled(mPreferenceKey, checked);
return false; return false;
}); });
@@ -250,7 +250,7 @@ public class PrintServiceSettingsFragment extends SettingsPreferenceFragment
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
updateEmptyView(); updateEmptyView();
} }

View File

@@ -27,8 +27,7 @@ import android.os.Bundle;
import android.os.UserHandle; import android.os.UserHandle;
import android.os.UserManager; import android.os.UserManager;
import android.provider.Settings; import android.provider.Settings;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.appcompat.app.AlertDialog; import androidx.appcompat.app.AlertDialog;
import androidx.preference.Preference; import androidx.preference.Preference;
@@ -46,12 +45,13 @@ import com.android.settings.search.BaseSearchIndexProvider;
import com.android.settings.widget.SettingsMainSwitchBar; import com.android.settings.widget.SettingsMainSwitchBar;
import com.android.settingslib.search.SearchIndexable; import com.android.settingslib.search.SearchIndexable;
import com.android.settingslib.widget.FooterPreference; import com.android.settingslib.widget.FooterPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
/** /**
* Screen pinning settings. * Screen pinning settings.
*/ */
@SearchIndexable @SearchIndexable
public class ScreenPinningSettings extends SettingsPreferenceFragment public class ScreenPinningSettings extends SettingsPreferenceFragment
implements OnCheckedChangeListener, DialogInterface.OnClickListener { implements OnMainSwitchChangeListener, DialogInterface.OnClickListener {
private static final String KEY_USE_SCREEN_LOCK = "use_screen_lock"; private static final String KEY_USE_SCREEN_LOCK = "use_screen_lock";
private static final String KEY_FOOTER = "screen_pinning_settings_screen_footer"; private static final String KEY_FOOTER = "screen_pinning_settings_screen_footer";
@@ -198,7 +198,7 @@ public class ScreenPinningSettings extends SettingsPreferenceFragment
* Listens to the state change of the overall lock-to-app switch. * Listens to the state change of the overall lock-to-app switch.
*/ */
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
if (isChecked) { if (isChecked) {
new AlertDialog.Builder(getContext()) new AlertDialog.Builder(getContext())
.setMessage(R.string.screen_pinning_dialog_message) .setMessage(R.string.screen_pinning_dialog_message)

View File

@@ -16,16 +16,16 @@
package com.android.settings.widget; package com.android.settings.widget;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import com.android.settingslib.RestrictedLockUtils; import com.android.settingslib.RestrictedLockUtils;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
/** /**
* The switch controller that is used to update the switch widget in the SettingsMainSwitchBar. * The switch controller that is used to update the switch widget in the SettingsMainSwitchBar.
*/ */
public class MainSwitchBarController extends SwitchWidgetController implements public class MainSwitchBarController extends SwitchWidgetController implements
OnCheckedChangeListener { OnMainSwitchChangeListener {
private final SettingsMainSwitchBar mMainSwitch; private final SettingsMainSwitchBar mMainSwitch;
@@ -74,7 +74,7 @@ public class MainSwitchBarController extends SwitchWidgetController implements
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
if (mListener != null) { if (mListener != null) {
mListener.onSwitchToggled(isChecked); mListener.onSwitchToggled(isChecked);
} }

View File

@@ -21,6 +21,7 @@ import static com.android.settingslib.RestrictedLockUtils.EnforcedAdmin;
import android.content.Context; import android.content.Context;
import android.util.AttributeSet; import android.util.AttributeSet;
import android.view.View; import android.view.View;
import android.widget.Switch;
import com.android.settings.overlay.FeatureFactory; import com.android.settings.overlay.FeatureFactory;
import com.android.settingslib.RestrictedLockUtils; import com.android.settingslib.RestrictedLockUtils;
@@ -38,9 +39,10 @@ public class SettingsMainSwitchBar extends MainSwitchBar {
public interface OnBeforeCheckedChangeListener { public interface OnBeforeCheckedChangeListener {
/** /**
* @param isChecked The new checked state of switchView. * @param switchView The Switch view whose state has changed.
* @param isChecked The new checked state of switchView.
*/ */
boolean onBeforeCheckedChanged(boolean isChecked); boolean onBeforeCheckedChanged(Switch switchView, boolean isChecked);
} }
private EnforcedAdmin mEnforcedAdmin; private EnforcedAdmin mEnforcedAdmin;
@@ -115,7 +117,7 @@ public class SettingsMainSwitchBar extends MainSwitchBar {
@Override @Override
public void setChecked(boolean checked) { public void setChecked(boolean checked) {
if (mOnBeforeListener != null if (mOnBeforeListener != null
&& mOnBeforeListener.onBeforeCheckedChanged(checked)) { && mOnBeforeListener.onBeforeCheckedChanged(mSwitch, checked)) {
return; return;
} }
super.setChecked(checked); super.setChecked(checked);

View File

@@ -20,8 +20,7 @@ import static com.android.settingslib.RestrictedLockUtils.EnforcedAdmin;
import android.content.Context; import android.content.Context;
import android.util.AttributeSet; import android.util.AttributeSet;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.preference.PreferenceViewHolder; import androidx.preference.PreferenceViewHolder;
import androidx.preference.TwoStatePreference; import androidx.preference.TwoStatePreference;
@@ -30,6 +29,7 @@ import com.android.settings.R;
import com.android.settings.widget.SettingsMainSwitchBar.OnBeforeCheckedChangeListener; import com.android.settings.widget.SettingsMainSwitchBar.OnBeforeCheckedChangeListener;
import com.android.settingslib.RestrictedPreferenceHelper; import com.android.settingslib.RestrictedPreferenceHelper;
import com.android.settingslib.core.instrumentation.SettingsJankMonitor; import com.android.settingslib.core.instrumentation.SettingsJankMonitor;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
@@ -40,11 +40,11 @@ import java.util.List;
* to enable or disable the preferences on the page. * to enable or disable the preferences on the page.
*/ */
public class SettingsMainSwitchPreference extends TwoStatePreference implements public class SettingsMainSwitchPreference extends TwoStatePreference implements
OnCheckedChangeListener { OnMainSwitchChangeListener {
private final List<OnBeforeCheckedChangeListener> mBeforeCheckedChangeListeners = private final List<OnBeforeCheckedChangeListener> mBeforeCheckedChangeListeners =
new ArrayList<>(); new ArrayList<>();
private final List<OnCheckedChangeListener> mSwitchChangeListeners = new ArrayList<>(); private final List<OnMainSwitchChangeListener> mSwitchChangeListeners = new ArrayList<>();
private SettingsMainSwitchBar mMainSwitchBar; private SettingsMainSwitchBar mMainSwitchBar;
private EnforcedAdmin mEnforcedAdmin; private EnforcedAdmin mEnforcedAdmin;
@@ -127,9 +127,9 @@ public class SettingsMainSwitchPreference extends TwoStatePreference implements
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
super.setChecked(isChecked); super.setChecked(isChecked);
SettingsJankMonitor.detectToggleJank(getKey(), buttonView); SettingsJankMonitor.detectToggleJank(getKey(), switchView);
} }
/** /**
@@ -197,7 +197,7 @@ public class SettingsMainSwitchPreference extends TwoStatePreference implements
/** /**
* Adds a listener for switch changes * Adds a listener for switch changes
*/ */
public void addOnSwitchChangeListener(OnCheckedChangeListener listener) { public void addOnSwitchChangeListener(OnMainSwitchChangeListener listener) {
if (!mSwitchChangeListeners.contains(listener)) { if (!mSwitchChangeListeners.contains(listener)) {
mSwitchChangeListeners.add(listener); mSwitchChangeListeners.add(listener);
} }
@@ -209,7 +209,7 @@ public class SettingsMainSwitchPreference extends TwoStatePreference implements
/** /**
* Remove a listener for switch changes * Remove a listener for switch changes
*/ */
public void removeOnSwitchChangeListener(OnCheckedChangeListener listener) { public void removeOnSwitchChangeListener(OnMainSwitchChangeListener listener) {
mSwitchChangeListeners.remove(listener); mSwitchChangeListeners.remove(listener);
if (mMainSwitchBar != null) { if (mMainSwitchBar != null) {
mMainSwitchBar.removeOnSwitchChangeListener(listener); mMainSwitchBar.removeOnSwitchChangeListener(listener);
@@ -239,7 +239,7 @@ public class SettingsMainSwitchPreference extends TwoStatePreference implements
for (OnBeforeCheckedChangeListener listener : mBeforeCheckedChangeListeners) { for (OnBeforeCheckedChangeListener listener : mBeforeCheckedChangeListeners) {
mMainSwitchBar.setOnBeforeCheckedChangeListener(listener); mMainSwitchBar.setOnBeforeCheckedChangeListener(listener);
} }
for (OnCheckedChangeListener listener : mSwitchChangeListeners) { for (OnMainSwitchChangeListener listener : mSwitchChangeListeners) {
mMainSwitchBar.addOnSwitchChangeListener(listener); mMainSwitchBar.addOnSwitchChangeListener(listener);
} }
} }

View File

@@ -17,20 +17,20 @@
package com.android.settings.widget; package com.android.settings.widget;
import android.content.Context; import android.content.Context;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.preference.Preference; import androidx.preference.Preference;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settings.core.TogglePreferenceController; import com.android.settings.core.TogglePreferenceController;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
/** /**
* Preference controller for MainSwitchPreference. * Preference controller for MainSwitchPreference.
*/ */
public abstract class SettingsMainSwitchPreferenceController extends public abstract class SettingsMainSwitchPreferenceController extends
TogglePreferenceController implements OnCheckedChangeListener { TogglePreferenceController implements OnMainSwitchChangeListener {
protected MainSwitchPreference mSwitchPreference; protected MainSwitchPreference mSwitchPreference;
@@ -49,7 +49,7 @@ public abstract class SettingsMainSwitchPreferenceController extends
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
mSwitchPreference.setChecked(isChecked); mSwitchPreference.setChecked(isChecked);
setChecked(isChecked); setChecked(isChecked);
} }

View File

@@ -38,8 +38,7 @@ import android.util.Log;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.appcompat.app.AlertDialog; import androidx.appcompat.app.AlertDialog;
import androidx.preference.Preference; import androidx.preference.Preference;
@@ -56,6 +55,7 @@ import com.android.settings.Utils;
import com.android.settings.core.SubSettingLauncher; import com.android.settings.core.SubSettingLauncher;
import com.android.settings.network.ims.WifiCallingQueryImsState; import com.android.settings.network.ims.WifiCallingQueryImsState;
import com.android.settings.widget.SettingsMainSwitchPreference; import com.android.settings.widget.SettingsMainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import java.util.List; import java.util.List;
@@ -64,7 +64,7 @@ import java.util.List;
* The preference screen lets you enable/disable Wi-Fi Calling and change Wi-Fi Calling mode. * The preference screen lets you enable/disable Wi-Fi Calling and change Wi-Fi Calling mode.
*/ */
public class WifiCallingSettingsForSub extends SettingsPreferenceFragment public class WifiCallingSettingsForSub extends SettingsPreferenceFragment
implements OnCheckedChangeListener, implements OnMainSwitchChangeListener,
Preference.OnPreferenceChangeListener { Preference.OnPreferenceChangeListener {
private static final String TAG = "WifiCallingForSub"; private static final String TAG = "WifiCallingForSub";
@@ -463,7 +463,7 @@ public class WifiCallingSettingsForSub extends SettingsPreferenceFragment
* Listens to the state change of the switch. * Listens to the state change of the switch.
*/ */
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
Log.d(TAG, "onSwitchChanged(" + isChecked + ")"); Log.d(TAG, "onSwitchChanged(" + isChecked + ")");
if (!isChecked) { if (!isChecked) {

View File

@@ -32,8 +32,7 @@ import android.net.wifi.WifiManager;
import android.os.Handler; import android.os.Handler;
import android.os.Looper; import android.os.Looper;
import android.util.Log; import android.util.Log;
import android.widget.CompoundButton; import android.widget.Switch;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
@@ -42,12 +41,13 @@ import com.android.settings.widget.SettingsMainSwitchBar;
import com.android.settingslib.core.lifecycle.LifecycleObserver; import com.android.settingslib.core.lifecycle.LifecycleObserver;
import com.android.settingslib.core.lifecycle.events.OnStart; import com.android.settingslib.core.lifecycle.events.OnStart;
import com.android.settingslib.core.lifecycle.events.OnStop; import com.android.settingslib.core.lifecycle.events.OnStop;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
/** /**
* Controller for logic pertaining to switch Wi-Fi tethering. * Controller for logic pertaining to switch Wi-Fi tethering.
*/ */
public class WifiTetherSwitchBarController implements public class WifiTetherSwitchBarController implements
LifecycleObserver, OnStart, OnStop, DataSaverBackend.Listener, OnCheckedChangeListener { LifecycleObserver, OnStart, OnStop, DataSaverBackend.Listener, OnMainSwitchChangeListener {
private static final String TAG = "WifiTetherSBC"; private static final String TAG = "WifiTetherSBC";
private static final IntentFilter WIFI_INTENT_FILTER; private static final IntentFilter WIFI_INTENT_FILTER;
@@ -101,9 +101,9 @@ public class WifiTetherSwitchBarController implements
} }
@Override @Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) { public void onSwitchChanged(Switch switchView, boolean isChecked) {
// Filter out unnecessary callbacks when switch is disabled. // Filter out unnecessary callbacks when switch is disabled.
if (!buttonView.isEnabled()) return; if (!switchView.isEnabled()) return;
if (isChecked) { if (isChecked) {
startTether(); startTether();

View File

@@ -142,7 +142,7 @@ public class CaptioningTogglePreferenceControllerTest {
public void onSwitchChanged_switchChecked_shouldSetCaptionEnabled() { public void onSwitchChanged_switchChecked_shouldSetCaptionEnabled() {
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
mController.onCheckedChanged(/* buttonView= */ null, /* isChecked= */ true); mController.onSwitchChanged(/* switchView= */ null, /* isChecked= */ true);
assertThat(isCaptionEnabled()).isTrue(); assertThat(isCaptionEnabled()).isTrue();
} }
@@ -151,7 +151,7 @@ public class CaptioningTogglePreferenceControllerTest {
public void onSwitchChanged_switchUnchecked_shouldSetCaptionDisabled() { public void onSwitchChanged_switchUnchecked_shouldSetCaptionDisabled() {
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
mController.onCheckedChanged(/* buttonView= */ null, /* isChecked= */ false); mController.onSwitchChanged(/* switchView= */ null, /* isChecked= */ false);
assertThat(isCaptionEnabled()).isFalse(); assertThat(isCaptionEnabled()).isFalse();
} }

View File

@@ -115,11 +115,11 @@ public class WorkModePreferenceControllerTest {
@Test @Test
public void onPreferenceChange_shouldRequestQuietModeEnabled() { public void onPreferenceChange_shouldRequestQuietModeEnabled() {
mController.onCheckedChanged(mSwitch, true); mController.onSwitchChanged(mSwitch, true);
verify(mUserManager).requestQuietModeEnabled(false, mManagedUser); verify(mUserManager).requestQuietModeEnabled(false, mManagedUser);
mController.onCheckedChanged(mSwitch, false); mController.onSwitchChanged(mSwitch, false);
verify(mUserManager).requestQuietModeEnabled(true, mManagedUser); verify(mUserManager).requestQuietModeEnabled(true, mManagedUser);
} }

View File

@@ -80,7 +80,7 @@ public class AutomaticStorageManagerSwitchBarControllerTest {
@Test @Test
public void onSwitchChanged_false_recordsAMetric() { public void onSwitchChanged_false_recordsAMetric() {
mController.onCheckedChanged(null, false); mController.onSwitchChanged(null, false);
verify(mMetricsFeatureProvider) verify(mMetricsFeatureProvider)
.action( .action(
@@ -91,7 +91,7 @@ public class AutomaticStorageManagerSwitchBarControllerTest {
@Test @Test
public void onSwitchChanged_true_recordsAMetric() { public void onSwitchChanged_true_recordsAMetric() {
mController.onCheckedChanged(null, true); mController.onSwitchChanged(null, true);
verify(mMetricsFeatureProvider) verify(mMetricsFeatureProvider)
.action( .action(
@@ -102,7 +102,7 @@ public class AutomaticStorageManagerSwitchBarControllerTest {
@Test @Test
public void onSwitchChanged_showWarningFragmentIfNotEnabledByDefault() { public void onSwitchChanged_showWarningFragmentIfNotEnabledByDefault() {
mController.onCheckedChanged(null, true); mController.onSwitchChanged(null, true);
verify(mFragmentManager.beginTransaction()) verify(mFragmentManager.beginTransaction())
.add(any(Fragment.class), eq(ActivationWarningFragment.TAG)); .add(any(Fragment.class), eq(ActivationWarningFragment.TAG));
@@ -112,7 +112,7 @@ public class AutomaticStorageManagerSwitchBarControllerTest {
public void onSwitchChange_doNotShowWarningFragmentIfEnabledByDefault() { public void onSwitchChange_doNotShowWarningFragmentIfEnabledByDefault() {
SystemProperties.set("ro.storage_manager.enabled", "true"); SystemProperties.set("ro.storage_manager.enabled", "true");
mController.onCheckedChanged(null, true); mController.onSwitchChanged(null, true);
verify(mFragmentManager.beginTransaction(), never()) verify(mFragmentManager.beginTransaction(), never())
.add(any(Fragment.class), eq(ActivationWarningFragment.TAG)); .add(any(Fragment.class), eq(ActivationWarningFragment.TAG));

View File

@@ -160,7 +160,7 @@ public class DevelopmentSettingsDashboardFragmentTest {
Settings.Global.putInt(mContext.getContentResolver(), Settings.Global.putInt(mContext.getContentResolver(),
Settings.Global.DEVELOPMENT_SETTINGS_ENABLED, 0); Settings.Global.DEVELOPMENT_SETTINGS_ENABLED, 0);
mDashboard.onCheckedChanged(null, false /* isChecked */); mDashboard.onSwitchChanged(null, false /* isChecked */);
assertThat(ShadowEnableDevelopmentSettingWarningDialog.mShown).isFalse(); assertThat(ShadowEnableDevelopmentSettingWarningDialog.mShown).isFalse();
} }
@@ -172,7 +172,7 @@ public class DevelopmentSettingsDashboardFragmentTest {
Settings.Global.putInt(mContext.getContentResolver(), Settings.Global.putInt(mContext.getContentResolver(),
Settings.Global.DEVELOPMENT_SETTINGS_ENABLED, 0); Settings.Global.DEVELOPMENT_SETTINGS_ENABLED, 0);
mDashboard.onCheckedChanged(null, true /* isChecked */); mDashboard.onSwitchChanged(null, true /* isChecked */);
assertThat(ShadowEnableDevelopmentSettingWarningDialog.mShown).isTrue(); assertThat(ShadowEnableDevelopmentSettingWarningDialog.mShown).isTrue();
} }
@@ -184,7 +184,7 @@ public class DevelopmentSettingsDashboardFragmentTest {
Settings.Global.putInt(mContext.getContentResolver(), Settings.Global.putInt(mContext.getContentResolver(),
Settings.Global.DEVELOPMENT_SETTINGS_ENABLED, 1); Settings.Global.DEVELOPMENT_SETTINGS_ENABLED, 1);
mDashboard.onCheckedChanged(null, false /* isChecked */); mDashboard.onSwitchChanged(null, false /* isChecked */);
assertThat(ShadowEnableDevelopmentSettingWarningDialog.mShown).isFalse(); assertThat(ShadowEnableDevelopmentSettingWarningDialog.mShown).isFalse();
assertThat(DevelopmentSettingsEnabler.isDevelopmentSettingsEnabled(mContext)).isFalse(); assertThat(DevelopmentSettingsEnabler.isDevelopmentSettingsEnabled(mContext)).isFalse();
@@ -203,7 +203,7 @@ public class DevelopmentSettingsDashboardFragmentTest {
Settings.Global.putInt(mContext.getContentResolver(), Settings.Global.putInt(mContext.getContentResolver(),
Settings.Global.DEVELOPMENT_SETTINGS_ENABLED, 1); Settings.Global.DEVELOPMENT_SETTINGS_ENABLED, 1);
mDashboard.onCheckedChanged(null, false /* isChecked */); mDashboard.onSwitchChanged(null, false /* isChecked */);
AlertDialog dialog = ShadowAlertDialogCompat.getLatestAlertDialog(); AlertDialog dialog = ShadowAlertDialogCompat.getLatestAlertDialog();
assertThat(dialog).isNotNull(); assertThat(dialog).isNotNull();

View File

@@ -24,7 +24,6 @@ import static com.google.common.truth.Truth.assertThat;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import android.content.Context; import android.content.Context;
import android.widget.CompoundButton.OnCheckedChangeListener;
import androidx.lifecycle.LifecycleOwner; import androidx.lifecycle.LifecycleOwner;
@@ -32,6 +31,7 @@ import com.android.settings.testutils.shadow.ShadowUserManager;
import com.android.settings.testutils.shadow.ShadowUtils; import com.android.settings.testutils.shadow.ShadowUtils;
import com.android.settings.widget.SettingsMainSwitchBar; import com.android.settings.widget.SettingsMainSwitchBar;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import org.junit.After; import org.junit.After;
import org.junit.Before; import org.junit.Before;
@@ -78,7 +78,7 @@ public class DevelopmentSwitchBarControllerTest {
ShadowUtils.setIsUserAMonkey(true); ShadowUtils.setIsUserAMonkey(true);
new DevelopmentSwitchBarController(mSettings, mSwitchBar, new DevelopmentSwitchBarController(mSettings, mSwitchBar,
true /* isAvailable */, mLifecycle); true /* isAvailable */, mLifecycle);
final List<OnCheckedChangeListener> listeners = final List<OnMainSwitchChangeListener> listeners =
ReflectionHelpers.getField(mSwitchBar, "mSwitchChangeListeners"); ReflectionHelpers.getField(mSwitchBar, "mSwitchChangeListeners");
mLifecycle.handleLifecycleEvent(ON_START); mLifecycle.handleLifecycleEvent(ON_START);
@@ -93,7 +93,7 @@ public class DevelopmentSwitchBarControllerTest {
ShadowUtils.setIsUserAMonkey(false); ShadowUtils.setIsUserAMonkey(false);
new DevelopmentSwitchBarController(mSettings, mSwitchBar, new DevelopmentSwitchBarController(mSettings, mSwitchBar,
true /* isAvailable */, mLifecycle); true /* isAvailable */, mLifecycle);
final List<OnCheckedChangeListener> listeners = final List<OnMainSwitchChangeListener> listeners =
ReflectionHelpers.getField(mSwitchBar, "mSwitchChangeListeners"); ReflectionHelpers.getField(mSwitchBar, "mSwitchChangeListeners");
mLifecycle.handleLifecycleEvent(ON_START); mLifecycle.handleLifecycleEvent(ON_START);
@@ -109,7 +109,7 @@ public class DevelopmentSwitchBarControllerTest {
ShadowUtils.setIsUserAMonkey(false); ShadowUtils.setIsUserAMonkey(false);
new DevelopmentSwitchBarController(mSettings, mSwitchBar, new DevelopmentSwitchBarController(mSettings, mSwitchBar,
true /* isAvailable */, mLifecycle); true /* isAvailable */, mLifecycle);
final List<OnCheckedChangeListener> listeners = final List<OnMainSwitchChangeListener> listeners =
ReflectionHelpers.getField(mSwitchBar, "mSwitchChangeListeners"); ReflectionHelpers.getField(mSwitchBar, "mSwitchChangeListeners");
mLifecycle.handleLifecycleEvent(ON_START); mLifecycle.handleLifecycleEvent(ON_START);

View File

@@ -104,7 +104,7 @@ public class NightDisplayActivationPreferenceControllerTest {
final NightDisplayActivationPreferenceController controller = final NightDisplayActivationPreferenceController controller =
new NightDisplayActivationPreferenceController(mContext, "night_display_activated"); new NightDisplayActivationPreferenceController(mContext, "night_display_activated");
controller.onCheckedChanged(null, true); controller.onSwitchChanged(null, true);
assertThat(mColorDisplayManager.isNightDisplayActivated()).isEqualTo(true); assertThat(mColorDisplayManager.isNightDisplayActivated()).isEqualTo(true);
} }
@@ -115,7 +115,7 @@ public class NightDisplayActivationPreferenceControllerTest {
final NightDisplayActivationPreferenceController controller = final NightDisplayActivationPreferenceController controller =
new NightDisplayActivationPreferenceController(mContext, "night_display_activated"); new NightDisplayActivationPreferenceController(mContext, "night_display_activated");
controller.onCheckedChanged(null, false); controller.onSwitchChanged(null, false);
assertThat(mColorDisplayManager.isNightDisplayActivated()).isEqualTo(false); assertThat(mColorDisplayManager.isNightDisplayActivated()).isEqualTo(false);
} }

View File

@@ -28,6 +28,7 @@ import androidx.test.core.app.ApplicationProvider;
import com.android.settingslib.dream.DreamBackend; import com.android.settingslib.dream.DreamBackend;
import com.android.settingslib.widget.MainSwitchPreference; import com.android.settingslib.widget.MainSwitchPreference;
import com.android.settingslib.widget.OnMainSwitchChangeListener;
import org.junit.After; import org.junit.After;
import org.junit.Before; import org.junit.Before;
@@ -52,6 +53,8 @@ public class DreamMainSwitchPreferenceControllerTest {
private DreamMainSwitchPreferenceController mController; private DreamMainSwitchPreferenceController mController;
private MainSwitchPreference mPreference; private MainSwitchPreference mPreference;
private DreamBackend mBackend; private DreamBackend mBackend;
@Mock
private OnMainSwitchChangeListener mChangeListener;
private ShadowContentResolver mShadowContentResolver; private ShadowContentResolver mShadowContentResolver;
@Before @Before

View File

@@ -39,7 +39,7 @@ import android.content.pm.PackageManager;
import android.graphics.drawable.Drawable; import android.graphics.drawable.Drawable;
import android.os.Bundle; import android.os.Bundle;
import android.os.UserHandle; import android.os.UserHandle;
import android.widget.CompoundButton; import android.widget.Switch;
import androidx.fragment.app.FragmentActivity; import androidx.fragment.app.FragmentActivity;
import androidx.loader.app.LoaderManager; import androidx.loader.app.LoaderManager;
@@ -109,7 +109,7 @@ public class PowerBackgroundUsageDetailTest {
@Mock private BackupManager mBackupManager; @Mock private BackupManager mBackupManager;
@Mock private PackageManager mPackageManager; @Mock private PackageManager mPackageManager;
@Mock private AppOpsManager mAppOpsManager; @Mock private AppOpsManager mAppOpsManager;
@Mock private CompoundButton mMockSwitch; @Mock private Switch mMockSwitch;
@Before @Before
public void setUp() { public void setUp() {
@@ -259,7 +259,7 @@ public class PowerBackgroundUsageDetailTest {
final int optimizedMode = BatteryOptimizeUtils.MODE_OPTIMIZED; final int optimizedMode = BatteryOptimizeUtils.MODE_OPTIMIZED;
mFragment.mOptimizationMode = optimizedMode; mFragment.mOptimizationMode = optimizedMode;
mFragment.onCheckedChanged(mMockSwitch, /* isChecked= */ false); mFragment.onSwitchChanged(mMockSwitch, /* isChecked= */ false);
verify(mOptimizePreference).setEnabled(false); verify(mOptimizePreference).setEnabled(false);
verify(mUnrestrictedPreference).setEnabled(false); verify(mUnrestrictedPreference).setEnabled(false);
@@ -275,7 +275,7 @@ public class PowerBackgroundUsageDetailTest {
final int optimizedMode = BatteryOptimizeUtils.MODE_OPTIMIZED; final int optimizedMode = BatteryOptimizeUtils.MODE_OPTIMIZED;
mFragment.mOptimizationMode = restrictedMode; mFragment.mOptimizationMode = restrictedMode;
mFragment.onCheckedChanged(mMockSwitch, /* isChecked= */ true); mFragment.onSwitchChanged(mMockSwitch, /* isChecked= */ true);
verify(mOptimizePreference).setEnabled(true); verify(mOptimizePreference).setEnabled(true);
verify(mUnrestrictedPreference).setEnabled(true); verify(mUnrestrictedPreference).setEnabled(true);

View File

@@ -116,7 +116,7 @@ public class PreventRingingSwitchPreferenceControllerTest {
Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.VOLUME_HUSH_GESTURE, Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.VOLUME_HUSH_GESTURE,
VOLUME_HUSH_OFF); VOLUME_HUSH_OFF);
mController.onCheckedChanged(null, true); mController.onSwitchChanged(null, true);
assertThat(Settings.Secure.getInt(mContext.getContentResolver(), assertThat(Settings.Secure.getInt(mContext.getContentResolver(),
Settings.Secure.VOLUME_HUSH_GESTURE, UNKNOWN)).isEqualTo(VOLUME_HUSH_VIBRATE); Settings.Secure.VOLUME_HUSH_GESTURE, UNKNOWN)).isEqualTo(VOLUME_HUSH_VIBRATE);
@@ -127,7 +127,7 @@ public class PreventRingingSwitchPreferenceControllerTest {
Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.VOLUME_HUSH_GESTURE, Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.VOLUME_HUSH_GESTURE,
VOLUME_HUSH_MUTE); VOLUME_HUSH_MUTE);
mController.onCheckedChanged(null, false); mController.onSwitchChanged(null, false);
assertThat(Settings.Secure.getInt(mContext.getContentResolver(), assertThat(Settings.Secure.getInt(mContext.getContentResolver(),
Settings.Secure.VOLUME_HUSH_GESTURE, UNKNOWN)).isEqualTo(VOLUME_HUSH_OFF); Settings.Secure.VOLUME_HUSH_GESTURE, UNKNOWN)).isEqualTo(VOLUME_HUSH_OFF);
@@ -139,7 +139,7 @@ public class PreventRingingSwitchPreferenceControllerTest {
Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.VOLUME_HUSH_GESTURE, Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.VOLUME_HUSH_GESTURE,
VOLUME_HUSH_MUTE); VOLUME_HUSH_MUTE);
mController.onCheckedChanged(null, true); mController.onSwitchChanged(null, true);
assertThat(Settings.Secure.getInt(mContext.getContentResolver(), assertThat(Settings.Secure.getInt(mContext.getContentResolver(),
Settings.Secure.VOLUME_HUSH_GESTURE, UNKNOWN)).isEqualTo(VOLUME_HUSH_MUTE); Settings.Secure.VOLUME_HUSH_GESTURE, UNKNOWN)).isEqualTo(VOLUME_HUSH_MUTE);
@@ -151,7 +151,7 @@ public class PreventRingingSwitchPreferenceControllerTest {
Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.VOLUME_HUSH_GESTURE, Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.VOLUME_HUSH_GESTURE,
VOLUME_HUSH_VIBRATE); VOLUME_HUSH_VIBRATE);
mController.onCheckedChanged(null, true); mController.onSwitchChanged(null, true);
assertThat(Settings.Secure.getInt(mContext.getContentResolver(), assertThat(Settings.Secure.getInt(mContext.getContentResolver(),
Settings.Secure.VOLUME_HUSH_GESTURE, UNKNOWN)).isEqualTo(VOLUME_HUSH_VIBRATE); Settings.Secure.VOLUME_HUSH_GESTURE, UNKNOWN)).isEqualTo(VOLUME_HUSH_VIBRATE);

View File

@@ -85,14 +85,14 @@ public class LocationSwitchBarControllerTest {
@Test @Test
public void onSwitchChanged_switchChecked_shouldSetLocationEnabled() { public void onSwitchChanged_switchChecked_shouldSetLocationEnabled() {
mController.onCheckedChanged(mSwitch, true); mController.onSwitchChanged(mSwitch, true);
verify(mEnabler).setLocationEnabled(true); verify(mEnabler).setLocationEnabled(true);
} }
@Test @Test
public void onSwitchChanged_switchUnchecked_shouldSetLocationDisabled() { public void onSwitchChanged_switchUnchecked_shouldSetLocationDisabled() {
mController.onCheckedChanged(mSwitch, false); mController.onSwitchChanged(mSwitch, false);
verify(mEnabler).setLocationEnabled(false); verify(mEnabler).setLocationEnabled(false);
} }

View File

@@ -112,7 +112,7 @@ public class BubbleNotificationPreferenceControllerTest {
public void onSwitchChanged_true_settingIsOff_flagShouldOn() { public void onSwitchChanged_true_settingIsOff_flagShouldOn() {
Settings.Global.putInt(mContext.getContentResolver(), NOTIFICATION_BUBBLES, OFF); Settings.Global.putInt(mContext.getContentResolver(), NOTIFICATION_BUBBLES, OFF);
mController.onCheckedChanged(mSwitch, true); mController.onSwitchChanged(mSwitch, true);
assertThat(Settings.Global.getInt(mContext.getContentResolver(), assertThat(Settings.Global.getInt(mContext.getContentResolver(),
NOTIFICATION_BUBBLES, OFF)).isEqualTo(ON); NOTIFICATION_BUBBLES, OFF)).isEqualTo(ON);
@@ -122,7 +122,7 @@ public class BubbleNotificationPreferenceControllerTest {
public void onSwitchChanged_false_settingIsOn_flagShouldOff() { public void onSwitchChanged_false_settingIsOn_flagShouldOff() {
Settings.Global.putInt(mContext.getContentResolver(), NOTIFICATION_BUBBLES, ON); Settings.Global.putInt(mContext.getContentResolver(), NOTIFICATION_BUBBLES, ON);
mController.onCheckedChanged(mSwitch, false); mController.onSwitchChanged(mSwitch, false);
assertThat(Settings.Global.getInt(mContext.getContentResolver(), assertThat(Settings.Global.getInt(mContext.getContentResolver(),
NOTIFICATION_BUBBLES, ON)).isEqualTo(OFF); NOTIFICATION_BUBBLES, ON)).isEqualTo(OFF);

View File

@@ -101,7 +101,7 @@ public class BlockPreferenceControllerTest {
@Test @Test
public void testNoCrashIfNoOnResume() { public void testNoCrashIfNoOnResume() {
mController.isAvailable(); mController.isAvailable();
mController.onCheckedChanged(null, false); mController.onSwitchChanged(null, false);
} }
@Test @Test
@@ -355,11 +355,11 @@ public class BlockPreferenceControllerTest {
mController.onResume(appRow, channel, null, null, null, null, null); mController.onResume(appRow, channel, null, null, null, null, null);
mController.updateState(mPreference); mController.updateState(mPreference);
mController.onCheckedChanged(null, false); mController.onSwitchChanged(null, false);
assertEquals(IMPORTANCE_NONE, channel.getImportance()); assertEquals(IMPORTANCE_NONE, channel.getImportance());
assertTrue(appRow.banned); assertTrue(appRow.banned);
mController.onCheckedChanged(null, true); mController.onSwitchChanged(null, true);
assertEquals(IMPORTANCE_UNSPECIFIED, channel.getImportance()); assertEquals(IMPORTANCE_UNSPECIFIED, channel.getImportance());
assertFalse(appRow.banned); assertFalse(appRow.banned);
@@ -377,10 +377,10 @@ public class BlockPreferenceControllerTest {
mController.onResume(appRow, channel, null, null, null, null, null); mController.onResume(appRow, channel, null, null, null, null, null);
mController.updateState(mPreference); mController.updateState(mPreference);
mController.onCheckedChanged(null, false); mController.onSwitchChanged(null, false);
assertEquals(IMPORTANCE_NONE, channel.getImportance()); assertEquals(IMPORTANCE_NONE, channel.getImportance());
mController.onCheckedChanged(null, true); mController.onSwitchChanged(null, true);
assertEquals(IMPORTANCE_HIGH, channel.getImportance()); assertEquals(IMPORTANCE_HIGH, channel.getImportance());
verify(mBackend, times(2)).updateChannel(any(), anyInt(), any()); verify(mBackend, times(2)).updateChannel(any(), anyInt(), any());

View File

@@ -292,7 +292,7 @@ public class WifiCallingSettingsForSubTest {
public void onSwitchChanged_enableSetting_shouldLaunchWfcDisclaimerFragment() { public void onSwitchChanged_enableSetting_shouldLaunchWfcDisclaimerFragment() {
final ArgumentCaptor<Intent> intentCaptor = ArgumentCaptor.forClass(Intent.class); final ArgumentCaptor<Intent> intentCaptor = ArgumentCaptor.forClass(Intent.class);
mFragment.onCheckedChanged(null, true); mFragment.onSwitchChanged(null, true);
// Check the WFC disclaimer fragment is launched. // Check the WFC disclaimer fragment is launched.
verify(mFragment).startActivityForResult(intentCaptor.capture(), verify(mFragment).startActivityForResult(intentCaptor.capture(),
@@ -337,7 +337,7 @@ public class WifiCallingSettingsForSubTest {
@Test @Test
public void onSwitchChanged_disableSetting_shouldNotLaunchWfcDisclaimerFragment() { public void onSwitchChanged_disableSetting_shouldNotLaunchWfcDisclaimerFragment() {
mFragment.onCheckedChanged(null, false); mFragment.onSwitchChanged(null, false);
// Check the WFC disclaimer fragment is not launched. // Check the WFC disclaimer fragment is not launched.
verify(mFragment, never()).startActivityForResult(any(Intent.class), anyInt()); verify(mFragment, never()).startActivityForResult(any(Intent.class), anyInt());

View File

@@ -150,7 +150,7 @@ public class WifiTetherSwitchBarControllerTest {
public void onSwitchChanged_switchNotEnabled_doNothingForTethering() { public void onSwitchChanged_switchNotEnabled_doNothingForTethering() {
when(mSwitch.isEnabled()).thenReturn(false); when(mSwitch.isEnabled()).thenReturn(false);
mController.onCheckedChanged(mSwitch, true); mController.onSwitchChanged(mSwitch, mSwitch.isChecked());
verify(mConnectivityManager, never()).startTethering(anyInt(), anyBoolean(), any(), any()); verify(mConnectivityManager, never()).startTethering(anyInt(), anyBoolean(), any(), any());
verify(mConnectivityManager, never()).stopTethering(anyInt()); verify(mConnectivityManager, never()).stopTethering(anyInt());
@@ -158,7 +158,9 @@ public class WifiTetherSwitchBarControllerTest {
@Test @Test
public void onSwitchChanged_isChecked_startTethering() { public void onSwitchChanged_isChecked_startTethering() {
mController.onCheckedChanged(mSwitch, true); when(mSwitch.isChecked()).thenReturn(true);
mController.onSwitchChanged(mSwitch, mSwitch.isChecked());
verify(mConnectivityManager).startTethering(anyInt(), anyBoolean(), any(), any()); verify(mConnectivityManager).startTethering(anyInt(), anyBoolean(), any(), any());
} }
@@ -166,7 +168,9 @@ public class WifiTetherSwitchBarControllerTest {
@Test @Test
public void onSwitchChanged_isNotChecked_stopTethering() { public void onSwitchChanged_isNotChecked_stopTethering() {
when(mWifiManager.getWifiApState()).thenReturn(WIFI_AP_STATE_ENABLED); when(mWifiManager.getWifiApState()).thenReturn(WIFI_AP_STATE_ENABLED);
mController.onCheckedChanged(mSwitch, false); when(mSwitch.isChecked()).thenReturn(false);
mController.onSwitchChanged(mSwitch, mSwitch.isChecked());
verify(mConnectivityManager).stopTethering(anyInt()); verify(mConnectivityManager).stopTethering(anyInt());
} }