PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't use debug data in app list controller

Browse Source 
This is a bug, USE_FAKE_DATA should never be true in build

Change-Id: I14059cd243380c754ca0cff09f088d62828ec755
Fixes: 73117246
Test: Build
This commit is contained in:
jackqdyulei
2018-02-08 10:12:34 -08:00
parent b1c7b88f10
commit 88c86f73bb
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/com/android/settings/fuelgauge/BatteryAppListPreferenceController.java
View File

@@ -62,7 +62,8 @@ import java.util.List;
*/ */
public class BatteryAppListPreferenceController extends AbstractPreferenceController public class BatteryAppListPreferenceController extends AbstractPreferenceController
implements PreferenceControllerMixin, LifecycleObserver, OnPause, OnDestroy { implements PreferenceControllerMixin, LifecycleObserver, OnPause, OnDestroy {
private static final boolean USE_FAKE_DATA = true; @VisibleForTesting
static final boolean USE_FAKE_DATA = false;
private static final int MAX_ITEMS_TO_LIST = USE_FAKE_DATA ? 30 : 10; private static final int MAX_ITEMS_TO_LIST = USE_FAKE_DATA ? 30 : 10;
private static final int MIN_AVERAGE_POWER_THRESHOLD_MILLI_AMP = 10; private static final int MIN_AVERAGE_POWER_THRESHOLD_MILLI_AMP = 10;
private static final int STATS_TYPE = BatteryStats.STATS_SINCE_CHARGED; private static final int STATS_TYPE = BatteryStats.STATS_SINCE_CHARGED;

5
tests/robotests/src/com/android/settings/fuelgauge/BatteryAppListPreferenceControllerTest.java
View File

@@ -220,4 +220,9 @@ public class BatteryAppListPreferenceControllerTest {
assertThat(mPreferenceController.isAvailable()).isFalse(); assertThat(mPreferenceController.isAvailable()).isFalse();
} }
@Test
public void testNeverUseFakeData() {
assertThat(BatteryAppListPreferenceController.USE_FAKE_DATA).isFalse();
}
} }