From e1ce633dd4abe81e924a5fb96818a2c888146a3f Mon Sep 17 00:00:00 2001 From: menghanli Date: Sat, 18 Feb 2023 08:43:36 +0800 Subject: [PATCH] fix(tablet assets): update a11y button navigation asset for tablets Fix: 269707768 Test: Go to Settings > Accessibility > Accessibility shortcuts > Accessibility button > Location to "Navigation bar". Change-Id: I2d56a104848c93d8e6d138c849d05b4a77388c3b --- ...accessibility_button_navigation_tablet.xml | 54 +++++++++++++++++++ ...accessibility_button_navigation_tablet.xml | 54 +++++++++++++++++++ res/values/drawables.xml | 3 ++ ...lityButtonPreviewPreferenceController.java | 2 +- ...ButtonPreviewPreferenceControllerTest.java | 2 +- 5 files changed, 113 insertions(+), 2 deletions(-) create mode 100644 res/drawable-night/accessibility_button_navigation_tablet.xml create mode 100644 res/drawable/accessibility_button_navigation_tablet.xml diff --git a/res/drawable-night/accessibility_button_navigation_tablet.xml b/res/drawable-night/accessibility_button_navigation_tablet.xml new file mode 100644 index 00000000000..d92b1440f54 --- /dev/null +++ b/res/drawable-night/accessibility_button_navigation_tablet.xml @@ -0,0 +1,54 @@ + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/accessibility_button_navigation_tablet.xml b/res/drawable/accessibility_button_navigation_tablet.xml new file mode 100644 index 00000000000..d8ae5034663 --- /dev/null +++ b/res/drawable/accessibility_button_navigation_tablet.xml @@ -0,0 +1,54 @@ + + + + + + + + + + + + + + + + diff --git a/res/values/drawables.xml b/res/values/drawables.xml index 61c7fe0b5fb..d0bc4ceb1c7 100644 --- a/res/values/drawables.xml +++ b/res/values/drawables.xml @@ -32,6 +32,9 @@ @drawable/accessibility_button_preview_two_finger @drawable/accessibility_button_preview_two_finger_tablet + @drawable/accessibility_button_navigation + @drawable/accessibility_button_navigation_tablet + @drawable/accessibility_captioning_banner @drawable/accessibility_captioning_banner_tablet diff --git a/src/com/android/settings/accessibility/AccessibilityButtonPreviewPreferenceController.java b/src/com/android/settings/accessibility/AccessibilityButtonPreviewPreferenceController.java index 1cde1b3b5f5..22552eaaf19 100644 --- a/src/com/android/settings/accessibility/AccessibilityButtonPreviewPreferenceController.java +++ b/src/com/android/settings/accessibility/AccessibilityButtonPreviewPreferenceController.java @@ -122,7 +122,7 @@ public class AccessibilityButtonPreviewPreferenceController extends BasePreferen : R.drawable.a11y_button_preview_two_finger)); } else { mIllustrationPreference.setImageDrawable( - mContext.getDrawable(R.drawable.accessibility_button_navigation)); + mContext.getDrawable(R.drawable.a11y_button_navigation)); } } diff --git a/tests/robotests/src/com/android/settings/accessibility/AccessibilityButtonPreviewPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/accessibility/AccessibilityButtonPreviewPreferenceControllerTest.java index 0cce56bd4d3..a2b27136578 100644 --- a/tests/robotests/src/com/android/settings/accessibility/AccessibilityButtonPreviewPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/accessibility/AccessibilityButtonPreviewPreferenceControllerTest.java @@ -74,7 +74,7 @@ public class AccessibilityButtonPreviewPreferenceControllerTest { mController.mContentObserver.onChange(false); final Drawable navigationBarDrawable = mContext.getDrawable( - R.drawable.accessibility_button_navigation); + R.drawable.a11y_button_navigation); assertThat(drawableToBitmap(mController.mIllustrationPreference.getImageDrawable()).sameAs( drawableToBitmap(navigationBarDrawable))).isTrue(); }