diff --git a/res/drawable/homepage_app_bar_background.xml b/res/drawable/homepage_app_bar_background.xml new file mode 100644 index 00000000000..6872ab77a6f --- /dev/null +++ b/res/drawable/homepage_app_bar_background.xml @@ -0,0 +1,24 @@ + + + + + + \ No newline at end of file diff --git a/res/layout/search_bar_two_pane_version.xml b/res/layout/search_bar_two_pane_version.xml index ede57226699..9ce220c8c5f 100644 --- a/res/layout/search_bar_two_pane_version.xml +++ b/res/layout/search_bar_two_pane_version.xml @@ -21,8 +21,7 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_weight="1" - android:layout_marginEnd="@dimen/search_bar_margin" - android:layout_marginVertical="@dimen/search_bar_margin"> + android:layout_marginEnd="@dimen/search_bar_margin"> + android:layout_marginHorizontal="@dimen/homepage_app_bar_margin_horizontal_two_pane" + android:padding="@dimen/homepage_app_bar_padding_two_pane" + android:orientation="horizontal" + android:background="@drawable/homepage_app_bar_background"> - + - + - - - - - - \ No newline at end of file + diff --git a/res/layout/settings_homepage_container.xml b/res/layout/settings_homepage_container.xml index 3de5a8a2dc4..89d40d08b44 100644 --- a/res/layout/settings_homepage_container.xml +++ b/res/layout/settings_homepage_container.xml @@ -34,6 +34,11 @@ android:layout_height="wrap_content" android:orientation="vertical"> + + + + + + + + + diff --git a/res/values/dimens.xml b/res/values/dimens.xml index 1582d217d1c..4a4231f2c8b 100755 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -152,6 +152,12 @@ 8dp 16dp 24dp + 32dp + 6dp + + 10dp + + 18dp 16dp diff --git a/src/com/android/settings/homepage/SettingsHomepageActivity.java b/src/com/android/settings/homepage/SettingsHomepageActivity.java index 025168778bb..5eaaa17d130 100644 --- a/src/com/android/settings/homepage/SettingsHomepageActivity.java +++ b/src/com/android/settings/homepage/SettingsHomepageActivity.java @@ -86,7 +86,6 @@ public class SettingsHomepageActivity extends FragmentActivity implements private TopLevelSettings mMainFragment; private View mHomepageView; - private View mAppBar; private View mSuggestionView; private View mTwoPaneSuggestionView; private CategoryMixin mCategoryMixin; @@ -171,8 +170,7 @@ public class SettingsHomepageActivity extends FragmentActivity implements mSplitController = SplitController.getInstance(); mIsTwoPane = mSplitController.isActivityEmbedded(this); - mAppBar = findViewById(R.id.app_bar_container); - mAppBar.setMinimumHeight(getSearchBoxHeight()); + updateAppBarMinHeight(); initHomepageContainer(); updateHomepageAppBar(); updateHomepageBackground(); @@ -482,12 +480,15 @@ public class SettingsHomepageActivity extends FragmentActivity implements if (!mIsEmbeddingActivityEnabled) { return; } + updateAppBarMinHeight(); if (mIsTwoPane) { findViewById(R.id.homepage_app_bar_regular_phone_view).setVisibility(View.GONE); findViewById(R.id.homepage_app_bar_two_pane_view).setVisibility(View.VISIBLE); + findViewById(R.id.suggestion_container_two_pane).setVisibility(View.VISIBLE); } else { findViewById(R.id.homepage_app_bar_regular_phone_view).setVisibility(View.VISIBLE); findViewById(R.id.homepage_app_bar_two_pane_view).setVisibility(View.GONE); + findViewById(R.id.suggestion_container_two_pane).setVisibility(View.GONE); } } @@ -498,19 +499,20 @@ public class SettingsHomepageActivity extends FragmentActivity implements if (mIsTwoPane) { int padding = getResources().getDimensionPixelSize( R.dimen.homepage_padding_horizontal_two_pane); - mAppBar.setPaddingRelative(padding, 0, padding, 0); mMainFragment.setPaddingHorizontal(padding); } else { - mAppBar.setPaddingRelative(0, 0, 0, 0); mMainFragment.setPaddingHorizontal(0); } mMainFragment.updatePreferencePadding(mIsTwoPane); } - private int getSearchBoxHeight() { + private void updateAppBarMinHeight() { final int searchBarHeight = getResources().getDimensionPixelSize(R.dimen.search_bar_height); - final int searchBarMargin = getResources().getDimensionPixelSize(R.dimen.search_bar_margin); - return searchBarHeight + searchBarMargin * 2; + final int margin = getResources().getDimensionPixelSize( + mIsEmbeddingActivityEnabled && mIsTwoPane + ? R.dimen.homepage_app_bar_padding_two_pane + : R.dimen.search_bar_margin); + findViewById(R.id.app_bar_container).setMinimumHeight(searchBarHeight + margin * 2); } private static class SuggestionFragCreator implements FragmentCreator {