Merge "Update battery saver schedule min trigger value" into tm-dev
This commit is contained in:
@@ -111,9 +111,8 @@ public class BatterySaverButtonPreferenceController extends
|
|||||||
|
|
||||||
@Override
|
@Override
|
||||||
public boolean setChecked(boolean stateOn) {
|
public boolean setChecked(boolean stateOn) {
|
||||||
// This screen already shows a warning, so we don't need another warning.
|
|
||||||
return BatterySaverUtils.setPowerSaveMode(mContext, stateOn,
|
return BatterySaverUtils.setPowerSaveMode(mContext, stateOn,
|
||||||
false /* needFirstTimeWarning */);
|
true /* needFirstTimeWarning */);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
@@ -40,7 +40,7 @@ public class BatterySaverScheduleRadioButtonsController {
|
|||||||
public static final String KEY_NO_SCHEDULE = "key_battery_saver_no_schedule";
|
public static final String KEY_NO_SCHEDULE = "key_battery_saver_no_schedule";
|
||||||
public static final String KEY_ROUTINE = "key_battery_saver_routine";
|
public static final String KEY_ROUTINE = "key_battery_saver_routine";
|
||||||
public static final String KEY_PERCENTAGE = "key_battery_saver_percentage";
|
public static final String KEY_PERCENTAGE = "key_battery_saver_percentage";
|
||||||
public static final int TRIGGER_LEVEL_MIN = 5;
|
public static final int TRIGGER_LEVEL_MIN = 10;
|
||||||
|
|
||||||
private Context mContext;
|
private Context mContext;
|
||||||
private BatterySaverScheduleSeekBarController mSeekBarController;
|
private BatterySaverScheduleSeekBarController mSeekBarController;
|
||||||
|
@@ -45,7 +45,7 @@ public class BatterySaverScheduleSeekBarController implements
|
|||||||
OnPreferenceChangeListener {
|
OnPreferenceChangeListener {
|
||||||
|
|
||||||
public static final int MAX_SEEKBAR_VALUE = 15;
|
public static final int MAX_SEEKBAR_VALUE = 15;
|
||||||
public static final int MIN_SEEKBAR_VALUE = 1;
|
public static final int MIN_SEEKBAR_VALUE = 2;
|
||||||
public static final String KEY_BATTERY_SAVER_SEEK_BAR = "battery_saver_seek_bar";
|
public static final String KEY_BATTERY_SAVER_SEEK_BAR = "battery_saver_seek_bar";
|
||||||
|
|
||||||
@VisibleForTesting
|
@VisibleForTesting
|
||||||
|
@@ -18,13 +18,17 @@ package com.android.settings.fuelgauge.batterysaver;
|
|||||||
|
|
||||||
import static com.google.common.truth.Truth.assertThat;
|
import static com.google.common.truth.Truth.assertThat;
|
||||||
|
|
||||||
|
import static org.mockito.ArgumentMatchers.any;
|
||||||
|
import static org.mockito.ArgumentMatchers.anyBoolean;
|
||||||
import static org.mockito.ArgumentMatchers.anyString;
|
import static org.mockito.ArgumentMatchers.anyString;
|
||||||
import static org.mockito.Mockito.doReturn;
|
import static org.mockito.Mockito.doReturn;
|
||||||
|
import static org.mockito.Mockito.never;
|
||||||
import static org.mockito.Mockito.spy;
|
import static org.mockito.Mockito.spy;
|
||||||
import static org.mockito.Mockito.verify;
|
import static org.mockito.Mockito.verify;
|
||||||
import static org.mockito.Mockito.when;
|
import static org.mockito.Mockito.when;
|
||||||
|
|
||||||
import android.content.Context;
|
import android.content.Context;
|
||||||
|
import android.content.Intent;
|
||||||
import android.os.PowerManager;
|
import android.os.PowerManager;
|
||||||
import android.provider.SettingsSlicesContract;
|
import android.provider.SettingsSlicesContract;
|
||||||
|
|
||||||
@@ -90,10 +94,11 @@ public class BatterySaverButtonPreferenceControllerTest {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void setChecked_on_setPowerSaveMode() {
|
public void setChecked_on_showWarningMessage() {
|
||||||
mController.setChecked(true);
|
mController.setChecked(true);
|
||||||
|
|
||||||
verify(mPowerManager).setPowerSaveModeEnabled(true);
|
verify(mContext).sendBroadcast(any(Intent.class));
|
||||||
|
verify(mPowerManager, never()).setPowerSaveModeEnabled(anyBoolean());
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
|
@@ -3,8 +3,8 @@ package com.android.settings.fuelgauge.batterysaver;
|
|||||||
import static com.google.common.truth.Truth.assertThat;
|
import static com.google.common.truth.Truth.assertThat;
|
||||||
|
|
||||||
import static org.mockito.ArgumentMatchers.any;
|
import static org.mockito.ArgumentMatchers.any;
|
||||||
import static org.mockito.Mockito.spy;
|
|
||||||
import static org.mockito.Mockito.never;
|
import static org.mockito.Mockito.never;
|
||||||
|
import static org.mockito.Mockito.spy;
|
||||||
import static org.mockito.Mockito.verify;
|
import static org.mockito.Mockito.verify;
|
||||||
|
|
||||||
import android.content.ContentResolver;
|
import android.content.ContentResolver;
|
||||||
@@ -64,10 +64,10 @@ public class BatterySaverScheduleSeekBarControllerTest {
|
|||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void updateSeekBar_percentageMode_hasCorrectProperties() {
|
public void updateSeekBar_percentageMode_hasCorrectProperties() {
|
||||||
final CharSequence expectedTitle = "5%";
|
final CharSequence expectedTitle = "10%";
|
||||||
Settings.Global.putInt(mResolver, Global.AUTOMATIC_POWER_SAVE_MODE,
|
Settings.Global.putInt(mResolver, Global.AUTOMATIC_POWER_SAVE_MODE,
|
||||||
PowerManager.POWER_SAVE_MODE_TRIGGER_PERCENTAGE);
|
PowerManager.POWER_SAVE_MODE_TRIGGER_PERCENTAGE);
|
||||||
Settings.Global.putInt(mResolver, Global.LOW_POWER_MODE_TRIGGER_LEVEL, 5);
|
Settings.Global.putInt(mResolver, Global.LOW_POWER_MODE_TRIGGER_LEVEL, 10);
|
||||||
mController.updateSeekBar();
|
mController.updateSeekBar();
|
||||||
|
|
||||||
assertThat(mController.mSeekBarPreference.isVisible()).isTrue();
|
assertThat(mController.mSeekBarPreference.isVisible()).isTrue();
|
||||||
|
@@ -1,7 +1,5 @@
|
|||||||
package com.android.settings.fuelgauge.batterysaver;
|
package com.android.settings.fuelgauge.batterysaver;
|
||||||
|
|
||||||
import static com.google.common.truth.Truth.assertThat;
|
|
||||||
|
|
||||||
import static org.mockito.Mockito.spy;
|
import static org.mockito.Mockito.spy;
|
||||||
import static org.mockito.Mockito.verify;
|
import static org.mockito.Mockito.verify;
|
||||||
import static org.mockito.Mockito.verifyNoMoreInteractions;
|
import static org.mockito.Mockito.verifyNoMoreInteractions;
|
||||||
@@ -10,7 +8,6 @@ import android.app.settings.SettingsEnums;
|
|||||||
import android.content.Context;
|
import android.content.Context;
|
||||||
import android.os.PowerManager;
|
import android.os.PowerManager;
|
||||||
import android.provider.Settings;
|
import android.provider.Settings;
|
||||||
import android.util.Pair;
|
|
||||||
|
|
||||||
import com.android.settings.testutils.FakeFeatureFactory;
|
import com.android.settings.testutils.FakeFeatureFactory;
|
||||||
import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
|
import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
|
||||||
|
Reference in New Issue
Block a user