Merge "Consider usage map valid even if [all][all] is null."
This commit is contained in:
committed by
Android (Google) Code Review
commit
86f436dd0d
@@ -896,7 +896,7 @@ public final class DataProcessor {
|
|||||||
final Map<Integer, Map<Integer, BatteryDiffData>> batteryUsageMap,
|
final Map<Integer, Map<Integer, BatteryDiffData>> batteryUsageMap,
|
||||||
final List<BatteryLevelData.PeriodBatteryLevelData> hourlyBatteryLevelsPerDay) {
|
final List<BatteryLevelData.PeriodBatteryLevelData> hourlyBatteryLevelsPerDay) {
|
||||||
if (batteryUsageMap.get(SELECTED_INDEX_ALL) == null
|
if (batteryUsageMap.get(SELECTED_INDEX_ALL) == null
|
||||||
|| batteryUsageMap.get(SELECTED_INDEX_ALL).get(SELECTED_INDEX_ALL) == null) {
|
|| !batteryUsageMap.get(SELECTED_INDEX_ALL).containsKey(SELECTED_INDEX_ALL)) {
|
||||||
Log.e(TAG, "no [SELECTED_INDEX_ALL][SELECTED_INDEX_ALL] in batteryUsageMap");
|
Log.e(TAG, "no [SELECTED_INDEX_ALL][SELECTED_INDEX_ALL] in batteryUsageMap");
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
@@ -423,17 +423,6 @@ public class DataProcessorTest {
|
|||||||
mContext, hourlyBatteryLevelsPerDay, new HashMap<>())).isNull();
|
mContext, hourlyBatteryLevelsPerDay, new HashMap<>())).isNull();
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
|
||||||
public void getBatteryUsageMap_emptyHourlyData_returnNull() {
|
|
||||||
final long[] timestamps = {1000000L, 2000000L};
|
|
||||||
final int[] levels = {100, 99};
|
|
||||||
final Map<Long, Map<String, BatteryHistEntry>> batteryHistoryMap =
|
|
||||||
createHistoryMap(timestamps, levels);
|
|
||||||
|
|
||||||
assertThat(DataProcessor.getBatteryUsageMap(
|
|
||||||
mContext, new ArrayList<>(), batteryHistoryMap)).isNull();
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void getBatteryUsageMap_returnsExpectedResult() {
|
public void getBatteryUsageMap_returnsExpectedResult() {
|
||||||
final long[] batteryHistoryKeys = new long[]{
|
final long[] batteryHistoryKeys = new long[]{
|
||||||
|
Reference in New Issue
Block a user