PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Settings] Reduce CDMA API access when not required

Browse Source 
Avoid from accessing CDMA roaming API to reduce some latency on UI.

Bug: 264656126
Test: local

Change-Id: I5c74636d8418a379724676e1f854c8adff5d4387
This commit is contained in:
Bonian Chen
2023-01-06 14:29:30 +00:00
parent 8d13ea9e64
commit 86b80b2508
1 changed files with 30 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
src/com/android/settings/network/telephony/cdma/CdmaSystemSelectPreferenceController.java
View File

@@ -23,6 +23,7 @@ import static com.android.settings.network.telephony.TelephonyConstants.Telephon
import android.content.Context; import android.content.Context;
import android.provider.Settings; import android.provider.Settings;
import android.telephony.TelephonyManager; import android.telephony.TelephonyManager;
import android.util.Log;
import androidx.preference.ListPreference; import androidx.preference.ListPreference;
import androidx.preference.Preference; import androidx.preference.Preference;
@@ -34,6 +35,7 @@ import com.android.settings.network.telephony.MobileNetworkUtils;
*/ */
public class CdmaSystemSelectPreferenceController extends CdmaBasePreferenceController public class CdmaSystemSelectPreferenceController extends CdmaBasePreferenceController
implements ListPreference.OnPreferenceChangeListener { implements ListPreference.OnPreferenceChangeListener {
private static final String TAG = "CdmaSystemSelectPreferenceController";
public CdmaSystemSelectPreferenceController(Context context, String key) { public CdmaSystemSelectPreferenceController(Context context, String key) {
super(context, key); super(context, key);
@@ -43,28 +45,36 @@ public class CdmaSystemSelectPreferenceController extends CdmaBasePreferenceCont
public void updateState(Preference preference) { public void updateState(Preference preference) {
super.updateState(preference); super.updateState(preference);
final ListPreference listPreference = (ListPreference) preference; final ListPreference listPreference = (ListPreference) preference;
listPreference.setVisible(getAvailabilityStatus() == AVAILABLE); boolean isVisible = (getAvailabilityStatus() == AVAILABLE);
boolean hasTelephonyMgr = mTelephonyManager != null; listPreference.setVisible(isVisible);
final int mode = if (!isVisible) {
hasTelephonyMgr ? mTelephonyManager.getCdmaRoamingMode() return;
: TelephonyManager.CDMA_ROAMING_MODE_RADIO_DEFAULT;
if (mode != TelephonyManager.CDMA_ROAMING_MODE_RADIO_DEFAULT) {
if (mode == TelephonyManager.CDMA_ROAMING_MODE_HOME
|| mode == TelephonyManager.CDMA_ROAMING_MODE_ANY) {
listPreference.setValue(Integer.toString(mode));
} else {
resetCdmaRoamingModeToDefault();
}
} }
boolean hasTelephonyMgr = mTelephonyManager != null;
try {
final int mode =
hasTelephonyMgr ? mTelephonyManager.getCdmaRoamingMode()
: TelephonyManager.CDMA_ROAMING_MODE_RADIO_DEFAULT;
if (mode != TelephonyManager.CDMA_ROAMING_MODE_RADIO_DEFAULT) {
if (mode == TelephonyManager.CDMA_ROAMING_MODE_HOME
|| mode == TelephonyManager.CDMA_ROAMING_MODE_ANY) {
listPreference.setValue(Integer.toString(mode));
} else {
resetCdmaRoamingModeToDefault();
}
}
final int settingsNetworkMode = final int settingsNetworkMode =
hasTelephonyMgr ? MobileNetworkUtils.getNetworkTypeFromRaf( hasTelephonyMgr ? MobileNetworkUtils.getNetworkTypeFromRaf(
(int) mTelephonyManager.getAllowedNetworkTypesForReason( (int) mTelephonyManager.getAllowedNetworkTypesForReason(
TelephonyManager.ALLOWED_NETWORK_TYPES_REASON_USER)) TelephonyManager.ALLOWED_NETWORK_TYPES_REASON_USER))
: NETWORK_MODE_UNKNOWN; : NETWORK_MODE_UNKNOWN;
final boolean enableList = settingsNetworkMode != NETWORK_MODE_LTE_GSM_WCDMA final boolean enableList = settingsNetworkMode != NETWORK_MODE_LTE_GSM_WCDMA
&& settingsNetworkMode != NETWORK_MODE_NR_LTE_GSM_WCDMA; && settingsNetworkMode != NETWORK_MODE_NR_LTE_GSM_WCDMA;
listPreference.setEnabled(enableList); listPreference.setEnabled(enableList);
} catch (Exception exception) {
Log.e(TAG, "Fail to access framework API", exception);
}
} }
@Override @Override