Don't show Screen as Apps in advanced battery page

Bug: 37293020
Test: RunSettngsRoboTests
Change-Id: I9a6259e1eb3a2d3451b0479bfe20be735825cd64
This commit is contained in:
jackqdyulei
2017-04-14 17:04:49 -07:00
parent be6fab0135
commit 8648873e91
2 changed files with 22 additions and 1 deletions

View File

@@ -226,6 +226,11 @@ public class PowerUsageAdvanced extends PowerUsageBase {
return false; return false;
} }
@VisibleForTesting
boolean shouldShowBatterySipper(BatterySipper batterySipper) {
return batterySipper.drainType != DrainType.SCREEN;
}
@VisibleForTesting @VisibleForTesting
List<PowerUsageData> parsePowerUsageData(BatteryStatsHelper statusHelper) { List<PowerUsageData> parsePowerUsageData(BatteryStatsHelper statusHelper) {
final List<BatterySipper> batterySippers = statusHelper.getUsageList(); final List<BatterySipper> batterySippers = statusHelper.getUsageList();
@@ -245,7 +250,9 @@ public class PowerUsageAdvanced extends PowerUsageBase {
BatteryUtils.StatusType.FOREGROUND, sipper.uidObj, STATUS_TYPE); BatteryUtils.StatusType.FOREGROUND, sipper.uidObj, STATUS_TYPE);
} }
usageData.totalUsageTimeMs += sipper.usageTimeMs; usageData.totalUsageTimeMs += sipper.usageTimeMs;
usageData.usageList.add(sipper); if (shouldShowBatterySipper(sipper)) {
usageData.usageList.add(sipper);
}
} }
final List<PowerUsageData> batteryDataList = new ArrayList<>(batteryDataMap.values()); final List<PowerUsageData> batteryDataList = new ArrayList<>(batteryDataMap.values());

View File

@@ -260,4 +260,18 @@ public class PowerUsageAdvancedTest {
assertThat(mPowerUsageAdvanced.shouldHideSummary(mPowerUsageData)).isFalse(); assertThat(mPowerUsageAdvanced.shouldHideSummary(mPowerUsageData)).isFalse();
} }
@Test
public void testShouldShowBatterySipper_typeScreen_returnFalse() {
mNormalBatterySipper.drainType = DrainType.SCREEN;
assertThat(mPowerUsageAdvanced.shouldShowBatterySipper(mNormalBatterySipper)).isFalse();
}
@Test
public void testShouldShowBatterySipper_typeNormal_returnTrue() {
mNormalBatterySipper.drainType = DrainType.APP;
assertThat(mPowerUsageAdvanced.shouldShowBatterySipper(mNormalBatterySipper)).isTrue();
}
} }