PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove plug/unplug condition for the incompatible charging

Browse Source 
Remove the plug/unplug condition checking for the incompatible
notification based on the feedback from:
https://b.corp.google.com/issues/276403405#comment3

Bug: 276403405
Test: make -j64 RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.fuelgauge.batterytip"
Change-Id: Iec177ed33a3cc8cf5a5747b6f65440d31120823c
This commit is contained in:
ykhung
2023-04-12 17:43:02 +08:00
parent c00fb2efbd
commit 836dc0d76c
3 changed files with 9 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/com/android/settings/fuelgauge/batterytip/BatteryTipLoader.java
View File

@@ -72,7 +72,7 @@ public class BatteryTipLoader extends AsyncLoaderCompat<List<BatteryTip>> {
.detect());
tips.add(new BatteryDefenderDetector(batteryInfo, context).detect());
tips.add(new DockDefenderDetector(batteryInfo, context).detect());
tips.add(new IncompatibleChargerDetector(context, batteryInfo).detect());
tips.add(new IncompatibleChargerDetector(context).detect());
Collections.sort(tips);
return tips;
}

19
src/com/android/settings/fuelgauge/batterytip/detectors/IncompatibleChargerDetector.java
View File

@@ -18,7 +18,6 @@ package com.android.settings.fuelgauge.batterytip.detectors;
import android.content.Context;
import android.util.Log;
import com.android.settings.fuelgauge.BatteryInfo;
import com.android.settings.fuelgauge.batterytip.tips.BatteryTip;
import com.android.settings.fuelgauge.batterytip.tips.IncompatibleChargerTip;
import com.android.settingslib.Utils;
@@ -28,25 +27,17 @@ public final class IncompatibleChargerDetector implements BatteryTipDetector {
private static final String TAG = "IncompatibleChargerDetector";
private final Context mContext;
private final BatteryInfo mBatteryInfo;
public IncompatibleChargerDetector(Context context, BatteryInfo batteryInfo) {
public IncompatibleChargerDetector(Context context) {
mContext = context;
mBatteryInfo = batteryInfo;
}
@Override
public BatteryTip detect() {
int state = BatteryTip.StateType.INVISIBLE;
boolean isIncompatibleCharging = false;
// Check incompatible charging state if the device is plugged.
if (mBatteryInfo.pluggedStatus != 0) {
isIncompatibleCharging = Utils.containsIncompatibleChargers(mContext, TAG);
if (isIncompatibleCharging) {
state = BatteryTip.StateType.NEW;
}
}
final boolean isIncompatibleCharging =
Utils.containsIncompatibleChargers(mContext, TAG);
final int state = isIncompatibleCharging
? BatteryTip.StateType.NEW : BatteryTip.StateType.INVISIBLE;
Log.d(TAG, "detect() state= " + state + " isIncompatibleCharging: "
+ isIncompatibleCharging);
return new IncompatibleChargerTip(state);