Merge "DataUsageSummaryPreferenceTest converted to JUnit"

This commit is contained in:
Jeremy Goldman
2020-12-21 06:21:22 +00:00
committed by Android (Google) Code Review
3 changed files with 267 additions and 198 deletions

View File

@@ -32,6 +32,7 @@ import android.text.style.AbsoluteSizeSpan;
import android.util.AttributeSet;
import android.view.View;
import android.widget.Button;
import android.widget.LinearLayout;
import android.widget.ProgressBar;
import android.widget.TextView;
@@ -156,24 +157,24 @@ public class DataUsageSummaryPreference extends Preference {
public void onBindViewHolder(PreferenceViewHolder holder) {
super.onBindViewHolder(holder);
ProgressBar bar = (ProgressBar) holder.findViewById(R.id.determinateBar);
ProgressBar bar = getProgressBar(holder);
if (mChartEnabled && (!TextUtils.isEmpty(mStartLabel) || !TextUtils.isEmpty(mEndLabel))) {
bar.setVisibility(View.VISIBLE);
holder.findViewById(R.id.label_bar).setVisibility(View.VISIBLE);
getLabelBar(holder).setVisibility(View.VISIBLE);
bar.setProgress((int) (mProgress * 100));
((TextView) holder.findViewById(android.R.id.text1)).setText(mStartLabel);
((TextView) holder.findViewById(android.R.id.text2)).setText(mEndLabel);
(getLabel1(holder)).setText(mStartLabel);
(getLabel2(holder)).setText(mEndLabel);
} else {
bar.setVisibility(View.GONE);
holder.findViewById(R.id.label_bar).setVisibility(View.GONE);
getLabelBar(holder).setVisibility(View.GONE);
}
updateDataUsageLabels(holder);
TextView usageTitle = (TextView) holder.findViewById(R.id.usage_title);
TextView carrierInfo = (TextView) holder.findViewById(R.id.carrier_and_update);
Button launchButton = (Button) holder.findViewById(R.id.launch_mdp_app_button);
TextView limitInfo = (TextView) holder.findViewById(R.id.data_limits);
TextView usageTitle = getUsageTitle(holder);
TextView carrierInfo = getCarrierInfo(holder);
Button launchButton = getLaunchButton(holder);
TextView limitInfo = getDataLimits(holder);
if (mWifiMode && mSingleWifi) {
updateCycleTimeText(holder);
@@ -187,7 +188,7 @@ public class DataUsageSummaryPreference extends Preference {
} else if (mWifiMode) {
usageTitle.setText(R.string.data_usage_wifi_title);
usageTitle.setVisibility(View.VISIBLE);
TextView cycleTime = (TextView) holder.findViewById(R.id.cycle_left_time);
TextView cycleTime = getCycleTime(holder);
cycleTime.setText(mUsagePeriod);
carrierInfo.setVisibility(View.GONE);
limitInfo.setVisibility(View.GONE);
@@ -235,7 +236,7 @@ public class DataUsageSummaryPreference extends Preference {
}
private void updateDataUsageLabels(PreferenceViewHolder holder) {
TextView usageNumberField = (TextView) holder.findViewById(R.id.data_usage_view);
TextView usageNumberField = getDataUsed(holder);
final Formatter.BytesResult usedResult = Formatter.formatBytes(getContext().getResources(),
mDataplanUse, Formatter.FLAG_CALCULATE_ROUNDED | Formatter.FLAG_IEC_UNITS);
@@ -250,11 +251,10 @@ public class DataUsageSummaryPreference extends Preference {
TextUtils.expandTemplate(template, usageNumberText, usedResult.units);
usageNumberField.setText(usageText);
final MeasurableLinearLayout layout =
(MeasurableLinearLayout) holder.findViewById(R.id.usage_layout);
final MeasurableLinearLayout layout = getLayout(holder);
if (mHasMobileData && mNumPlans >= 0 && mDataplanSize > 0L) {
TextView usageRemainingField = (TextView) holder.findViewById(R.id.data_remaining_view);
TextView usageRemainingField = getDataRemaining(holder);
long dataRemaining = mDataplanSize - mDataplanUse;
if (dataRemaining >= 0) {
usageRemainingField.setText(
@@ -276,7 +276,7 @@ public class DataUsageSummaryPreference extends Preference {
}
private void updateCycleTimeText(PreferenceViewHolder holder) {
TextView cycleTime = (TextView) holder.findViewById(R.id.cycle_left_time);
TextView cycleTime = getCycleTime(holder);
// Takes zero as a special case which value is never set.
if (mCycleEndTimeMs == CYCLE_TIME_UNINITIAL_VALUE) {
@@ -362,9 +362,68 @@ public class DataUsageSummaryPreference extends Preference {
}
@VisibleForTesting
long getHistoricalUsageLevel() {
protected long getHistoricalUsageLevel() {
final DataUsageController controller = new DataUsageController(getContext());
return controller.getHistoricalUsageLevel(NetworkTemplate.buildTemplateWifiWildcard());
}
@VisibleForTesting
protected TextView getUsageTitle(PreferenceViewHolder holder) {
return (TextView) holder.findViewById(R.id.usage_title);
}
@VisibleForTesting
protected TextView getCycleTime(PreferenceViewHolder holder) {
return (TextView) holder.findViewById(R.id.cycle_left_time);
}
@VisibleForTesting
protected TextView getCarrierInfo(PreferenceViewHolder holder) {
return (TextView) holder.findViewById(R.id.carrier_and_update);
}
@VisibleForTesting
protected TextView getDataLimits(PreferenceViewHolder holder) {
return (TextView) holder.findViewById(R.id.data_limits);
}
@VisibleForTesting
protected TextView getDataUsed(PreferenceViewHolder holder) {
return (TextView) holder.findViewById(R.id.data_usage_view);
}
@VisibleForTesting
protected TextView getDataRemaining(PreferenceViewHolder holder) {
return (TextView) holder.findViewById(R.id.data_remaining_view);
}
@VisibleForTesting
protected Button getLaunchButton(PreferenceViewHolder holder) {
return (Button) holder.findViewById(R.id.launch_mdp_app_button);
}
@VisibleForTesting
protected LinearLayout getLabelBar(PreferenceViewHolder holder) {
return (LinearLayout) holder.findViewById(R.id.label_bar);
}
@VisibleForTesting
protected TextView getLabel1(PreferenceViewHolder holder) {
return (TextView) holder.findViewById(android.R.id.text1);
}
@VisibleForTesting
protected TextView getLabel2(PreferenceViewHolder holder) {
return (TextView) holder.findViewById(android.R.id.text2);
}
@VisibleForTesting
protected ProgressBar getProgressBar(PreferenceViewHolder holder) {
return (ProgressBar) holder.findViewById(R.id.determinateBar);
}
@VisibleForTesting
protected MeasurableLinearLayout getLayout(PreferenceViewHolder holder) {
return (MeasurableLinearLayout) holder.findViewById(R.id.usage_layout);
}
}

View File

@@ -18,6 +18,7 @@ android_test {
"androidx.test.espresso.contrib-nodeps",
"androidx.test.espresso.intents-nodeps",
"androidx.test.ext.junit",
"androidx.preference_preference",
"mockito-target-minus-junit4",
"platform-test-annotations",
"truth-prebuilt",

View File

@@ -1,5 +1,5 @@
/*
* Copyright (C) 2018 The Android Open Source Project
* Copyright (C) 2020 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -11,20 +11,23 @@
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License
* limitations under the License.
*/
package com.android.settings.datausage;
import static com.google.common.truth.Truth.assertThat;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import android.app.Activity;
import android.content.ComponentName;
import android.content.Context;
import android.content.Intent;
import android.content.res.Resources;
import android.graphics.Typeface;
import android.net.ConnectivityManager;
import android.net.NetworkTemplate;
@@ -32,78 +35,71 @@ import android.os.Bundle;
import android.telephony.SubscriptionManager;
import android.view.LayoutInflater;
import android.view.View;
import android.widget.Button;
import android.widget.LinearLayout;
import android.widget.ProgressBar;
import android.view.View.MeasureSpec;
import android.widget.TextView;
import androidx.fragment.app.FragmentActivity;
import androidx.preference.PreferenceViewHolder;
import androidx.test.annotation.UiThreadTest;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import com.android.settings.R;
import com.android.settings.SettingsActivity;
import com.android.settings.SubSettings;
import com.android.settings.testutils.ResourcesUtils;
import com.android.settingslib.Utils;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.ArgumentCaptor;
import org.mockito.MockitoAnnotations;
import org.robolectric.Robolectric;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.Shadows;
import org.robolectric.shadows.ShadowActivity;
import java.util.concurrent.TimeUnit;
@RunWith(RobolectricTestRunner.class)
@RunWith(AndroidJUnit4.class)
public class DataUsageSummaryPreferenceTest {
private static final long CYCLE_DURATION_MILLIS = 1000000000L;
private static final long UPDATE_LAG_MILLIS = 10000000L;
private static final String FAKE_CARRIER = "z-mobile";
private Activity mActivity;
private Context mContext;
private Resources mResources;
private PreferenceViewHolder mHolder;
private DataUsageSummaryPreference mSummaryPreference;
private TextView mUsageTitle;
private TextView mCycleTime;
private TextView mCarrierInfo;
private TextView mDataLimits;
private TextView mDataUsed;
private TextView mDataRemaining;
private Button mLaunchButton;
private LinearLayout mLabelBar;
private TextView mLabel1;
private TextView mLabel2;
private ProgressBar mProgressBar;
private long mCycleEnd;
private long mUpdateTime;
@Before
public void setUp() {
MockitoAnnotations.initMocks(this);
mActivity = spy(Robolectric.setupActivity(Activity.class));
mSummaryPreference = new DataUsageSummaryPreference(mActivity, null /* attrs */);
LayoutInflater inflater = LayoutInflater.from(mActivity);
View view = inflater.inflate(mSummaryPreference.getLayoutResource(), null /* root */,
false /* attachToRoot */);
mContext = spy(ApplicationProvider.getApplicationContext());
mResources = spy(mContext.getResources());
when(mContext.getResources()).thenReturn(mResources);
mSummaryPreference = spy(new DataUsageSummaryPreference(mContext, null /* attrs */));
LayoutInflater inflater = mContext.getSystemService(LayoutInflater.class);
View view = inflater.inflate(
mSummaryPreference.getLayoutResource(),
null /* root */, false /* attachToRoot */);
mHolder = spy(PreferenceViewHolder.createInstanceForTests(view));
assertThat(mSummaryPreference.getDataUsed(mHolder)).isNotNull();
final long now = System.currentTimeMillis();
mCycleEnd = now + CYCLE_DURATION_MILLIS;
mUpdateTime = now - UPDATE_LAG_MILLIS;
}
@UiThreadTest
@Test
public void testSetUsageInfo_withLaunchIntent_launchButtonShown() {
mSummaryPreference.setUsageInfo(mCycleEnd, mUpdateTime, FAKE_CARRIER, 0 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mLaunchButton.getVisibility()).isEqualTo(View.VISIBLE);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getLaunchButton(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
}
@Test
@@ -111,8 +107,9 @@ public class DataUsageSummaryPreferenceTest {
mSummaryPreference.setUsageInfo(mCycleEnd, mUpdateTime, FAKE_CARRIER, 0 /* numPlans */,
null /* launchIntent */);
bindViewHolder();
assertThat(mLaunchButton.getVisibility()).isEqualTo(View.GONE);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getLaunchButton(mHolder).getVisibility())
.isEqualTo(View.GONE);
}
@Test
@@ -120,8 +117,9 @@ public class DataUsageSummaryPreferenceTest {
mSummaryPreference.setUsageInfo(mCycleEnd, mUpdateTime, FAKE_CARRIER, 1 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mCarrierInfo.getVisibility()).isEqualTo(View.VISIBLE);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getCarrierInfo(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
}
@Test
@@ -129,8 +127,9 @@ public class DataUsageSummaryPreferenceTest {
mSummaryPreference.setUsageInfo(mCycleEnd, mUpdateTime, FAKE_CARRIER, 0 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mCarrierInfo.getVisibility()).isEqualTo(View.GONE);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getCarrierInfo(mHolder).getVisibility())
.isEqualTo(View.GONE);
}
@Test
@@ -139,12 +138,11 @@ public class DataUsageSummaryPreferenceTest {
int smudge = 6;
final long updateTime = System.currentTimeMillis()
- TimeUnit.DAYS.toMillis(baseUnit) - TimeUnit.HOURS.toMillis(smudge);
mCarrierInfo = (TextView) mHolder.findViewById(R.id.carrier_and_update);
mSummaryPreference.setUsageInfo(mCycleEnd, updateTime, FAKE_CARRIER, 1 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mCarrierInfo.getText().toString())
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getCarrierInfo(mHolder).getText().toString())
.isEqualTo("Updated by " + FAKE_CARRIER + " " + baseUnit + " days ago");
}
@@ -154,12 +152,11 @@ public class DataUsageSummaryPreferenceTest {
int smudge = 6;
final long updateTime = System.currentTimeMillis()
- TimeUnit.HOURS.toMillis(baseUnit) - TimeUnit.MINUTES.toMillis(smudge);
mCarrierInfo = (TextView) mHolder.findViewById(R.id.carrier_and_update);
mSummaryPreference.setUsageInfo(mCycleEnd, updateTime, FAKE_CARRIER, 1 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mCarrierInfo.getText().toString())
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getCarrierInfo(mHolder).getText().toString())
.isEqualTo("Updated by " + FAKE_CARRIER + " " + baseUnit + " hr ago");
}
@@ -169,63 +166,59 @@ public class DataUsageSummaryPreferenceTest {
int smudge = 6;
final long updateTime = System.currentTimeMillis()
- TimeUnit.MINUTES.toMillis(baseUnit) - TimeUnit.SECONDS.toMillis(smudge);
mCarrierInfo = (TextView) mHolder.findViewById(R.id.carrier_and_update);
mSummaryPreference.setUsageInfo(mCycleEnd, updateTime, FAKE_CARRIER, 1 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mCarrierInfo.getText().toString())
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getCarrierInfo(mHolder).getText().toString())
.isEqualTo("Updated by " + FAKE_CARRIER + " " + baseUnit + " min ago");
}
@Test
public void testCarrierUpdateTime_shouldFormatLessThanMinuteCorrectly() {
final long updateTime = System.currentTimeMillis() - TimeUnit.SECONDS.toMillis(45);
mCarrierInfo = (TextView) mHolder.findViewById(R.id.carrier_and_update);
mSummaryPreference.setUsageInfo(mCycleEnd, updateTime, FAKE_CARRIER, 1 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mCarrierInfo.getText().toString())
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getCarrierInfo(mHolder).getText().toString())
.isEqualTo("Updated by " + FAKE_CARRIER + " just now");
}
@Test
public void testCarrierUpdateTimeWithNoCarrier_shouldSayJustNow() {
final long updateTime = System.currentTimeMillis() - TimeUnit.SECONDS.toMillis(45);
mCarrierInfo = (TextView) mHolder.findViewById(R.id.carrier_and_update);
mSummaryPreference.setUsageInfo(mCycleEnd, updateTime, null /* carrier */,
1 /* numPlans */, new Intent());
bindViewHolder();
assertThat(mCarrierInfo.getText().toString())
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getCarrierInfo(mHolder).getText().toString())
.isEqualTo("Updated just now");
}
@Test
public void testCarrierUpdateTimeWithNoCarrier_shouldFormatTime() {
final long updateTime = System.currentTimeMillis() - TimeUnit.MINUTES.toMillis(2);
mCarrierInfo = (TextView) mHolder.findViewById(R.id.carrier_and_update);
mSummaryPreference.setUsageInfo(mCycleEnd, updateTime, null /* carrier */,
1 /* numPlans */, new Intent());
bindViewHolder();
assertThat(mCarrierInfo.getText().toString())
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getCarrierInfo(mHolder).getText().toString())
.isEqualTo("Updated 2 min ago");
}
@Test
public void setUsageInfo_withRecentCarrierUpdate_doesNotSetCarrierInfoWarningColorAndFont() {
final long updateTime = System.currentTimeMillis() - TimeUnit.HOURS.toMillis(1);
mCarrierInfo = (TextView) mHolder.findViewById(R.id.carrier_and_update);
mSummaryPreference.setUsageInfo(mCycleEnd, updateTime, FAKE_CARRIER, 1 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mCarrierInfo.getVisibility()).isEqualTo(View.VISIBLE);
assertThat(mCarrierInfo.getCurrentTextColor()).isEqualTo(
Utils.getColorAttrDefaultColor(mActivity, android.R.attr.textColorSecondary));
assertThat(mCarrierInfo.getTypeface()).isEqualTo(Typeface.SANS_SERIF);
mSummaryPreference.onBindViewHolder(mHolder);
TextView carrierInfo = mSummaryPreference.getCarrierInfo(mHolder);
assertThat(carrierInfo.getVisibility()).isEqualTo(View.VISIBLE);
assertThat(carrierInfo.getCurrentTextColor()).isEqualTo(
Utils.getColorAttrDefaultColor(mContext, android.R.attr.textColorSecondary));
assertThat(carrierInfo.getTypeface()).isEqualTo(Typeface.SANS_SERIF);
}
@Test
@@ -234,11 +227,12 @@ public class DataUsageSummaryPreferenceTest {
mSummaryPreference.setUsageInfo(mCycleEnd, updateTime, FAKE_CARRIER, 1 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mCarrierInfo.getVisibility()).isEqualTo(View.VISIBLE);
assertThat(mCarrierInfo.getCurrentTextColor()).isEqualTo(
Utils.getColorAttrDefaultColor(mActivity, android.R.attr.colorError));
assertThat(mCarrierInfo.getTypeface()).isEqualTo(
mSummaryPreference.onBindViewHolder(mHolder);
TextView carrierInfo = mSummaryPreference.getCarrierInfo(mHolder);
assertThat(carrierInfo.getVisibility()).isEqualTo(View.VISIBLE);
assertThat(carrierInfo.getCurrentTextColor()).isEqualTo(
Utils.getColorAttrDefaultColor(mContext, android.R.attr.colorError));
assertThat(carrierInfo.getTypeface()).isEqualTo(
DataUsageSummaryPreference.SANS_SERIF_MEDIUM);
}
@@ -247,8 +241,8 @@ public class DataUsageSummaryPreferenceTest {
mSummaryPreference.setUsageInfo(mCycleEnd, mUpdateTime, FAKE_CARRIER, 0 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mUsageTitle.getVisibility()).isEqualTo(View.GONE);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getUsageTitle(mHolder).getVisibility()).isEqualTo(View.GONE);
}
@Test
@@ -256,8 +250,9 @@ public class DataUsageSummaryPreferenceTest {
mSummaryPreference.setUsageInfo(mCycleEnd, mUpdateTime, FAKE_CARRIER, 2 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mUsageTitle.getVisibility()).isEqualTo(View.VISIBLE);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getUsageTitle(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
}
@Test
@@ -267,10 +262,12 @@ public class DataUsageSummaryPreferenceTest {
mSummaryPreference.setUsageInfo(cycleEnd, mUpdateTime, FAKE_CARRIER, 0 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mCycleTime.getVisibility()).isEqualTo(View.VISIBLE);
assertThat(mCycleTime.getText()).isEqualTo(
mActivity.getString(R.string.billing_cycle_less_than_one_day_left));
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getCycleTime(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
assertThat(mSummaryPreference.getCycleTime(mHolder).getText()).isEqualTo(
ResourcesUtils.getResourcesString(
mContext, "billing_cycle_less_than_one_day_left"));
}
@Test
@@ -279,10 +276,11 @@ public class DataUsageSummaryPreferenceTest {
mSummaryPreference.setUsageInfo(cycleEnd, mUpdateTime, FAKE_CARRIER, 0 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mCycleTime.getVisibility()).isEqualTo(View.VISIBLE);
assertThat(mCycleTime.getText()).isEqualTo(
mActivity.getString(R.string.billing_cycle_none_left));
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getCycleTime(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
assertThat(mSummaryPreference.getCycleTime(mHolder).getText()).isEqualTo(
ResourcesUtils.getResourcesString(mContext, "billing_cycle_none_left"));
}
@Test
@@ -293,9 +291,11 @@ public class DataUsageSummaryPreferenceTest {
mSummaryPreference.setUsageInfo(cycleEnd, mUpdateTime, FAKE_CARRIER, 0 /* numPlans */,
new Intent());
bindViewHolder();
assertThat(mCycleTime.getVisibility()).isEqualTo(View.VISIBLE);
assertThat(mCycleTime.getText()).isEqualTo(daysLeft + " days left");
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getCycleTime(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
assertThat(mSummaryPreference.getCycleTime(mHolder).getText())
.isEqualTo(daysLeft + " days left");
}
@Test
@@ -303,17 +303,18 @@ public class DataUsageSummaryPreferenceTest {
final String limitText = "test limit text";
mSummaryPreference.setLimitInfo(limitText);
bindViewHolder();
assertThat(mDataLimits.getVisibility()).isEqualTo(View.VISIBLE);
assertThat(mDataLimits.getText()).isEqualTo(limitText);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getDataLimits(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
assertThat(mSummaryPreference.getDataLimits(mHolder).getText()).isEqualTo(limitText);
}
@Test
public void testSetLimitInfo_withNullLimitInfo_dataLimitsNotShown() {
mSummaryPreference.setLimitInfo(null);
bindViewHolder();
assertThat(mDataLimits.getVisibility()).isEqualTo(View.GONE);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getDataLimits(mHolder).getVisibility()).isEqualTo(View.GONE);
}
@Test
@@ -321,8 +322,8 @@ public class DataUsageSummaryPreferenceTest {
final String emptyLimitText = "";
mSummaryPreference.setLimitInfo(emptyLimitText);
bindViewHolder();
assertThat(mDataLimits.getVisibility()).isEqualTo(View.GONE);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getDataLimits(mHolder).getVisibility()).isEqualTo(View.GONE);
}
@Test
@@ -330,18 +331,18 @@ public class DataUsageSummaryPreferenceTest {
setValidLabels();
mSummaryPreference.setChartEnabled(false);
bindViewHolder();
assertThat(mLabelBar.getVisibility()).isEqualTo(View.GONE);
assertThat(mProgressBar.getVisibility()).isEqualTo(View.GONE);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getLabelBar(mHolder).getVisibility()).isEqualTo(View.GONE);
assertThat(mSummaryPreference.getProgressBar(mHolder).getVisibility()).isEqualTo(View.GONE);
}
@Test
public void testSetEmptyLabels_hidesLabelBar() {
mSummaryPreference.setLabels("", "");
bindViewHolder();
assertThat(mLabelBar.getVisibility()).isEqualTo(View.GONE);
assertThat(mProgressBar.getVisibility()).isEqualTo(View.GONE);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getLabelBar(mHolder).getVisibility()).isEqualTo(View.GONE);
assertThat(mSummaryPreference.getProgressBar(mHolder).getVisibility()).isEqualTo(View.GONE);
}
@Test
@@ -349,9 +350,11 @@ public class DataUsageSummaryPreferenceTest {
setValidLabels();
//mChartEnabled defaults to true
bindViewHolder();
assertThat(mLabelBar.getVisibility()).isEqualTo(View.VISIBLE);
assertThat(mProgressBar.getVisibility()).isEqualTo(View.VISIBLE);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getLabelBar(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
assertThat(mSummaryPreference.getProgressBar(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
}
@Test
@@ -359,8 +362,8 @@ public class DataUsageSummaryPreferenceTest {
setValidLabels();
mSummaryPreference.setProgress(.5f);
bindViewHolder();
assertThat(mProgressBar.getProgress()).isEqualTo(50);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getProgressBar(mHolder).getProgress()).isEqualTo(50);
}
private void setValidLabels() {
@@ -376,12 +379,16 @@ public class DataUsageSummaryPreferenceTest {
10 * BillingCycleSettings.MIB_IN_BYTES,
true /* hasMobileData */);
bindViewHolder();
assertThat(mDataUsed.getText().toString()).isEqualTo("1.00 MB used");
assertThat(mDataRemaining.getText().toString()).isEqualTo("9.00 MB left");
assertThat(mDataRemaining.getVisibility()).isEqualTo(View.VISIBLE);
final int colorId = Utils.getColorAttrDefaultColor(mActivity, android.R.attr.colorAccent);
assertThat(mDataRemaining.getCurrentTextColor()).isEqualTo(colorId);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getDataUsed(mHolder).getText().toString())
.isEqualTo("1.00 MB used");
assertThat(mSummaryPreference.getDataRemaining(mHolder).getText().toString())
.isEqualTo("9.00 MB left");
assertThat(mSummaryPreference.getDataRemaining(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
final int colorId = Utils.getColorAttrDefaultColor(mContext, android.R.attr.colorAccent);
assertThat(mSummaryPreference.getDataRemaining(mHolder).getCurrentTextColor())
.isEqualTo(colorId);
}
@Test
@@ -393,11 +400,14 @@ public class DataUsageSummaryPreferenceTest {
10 * BillingCycleSettings.MIB_IN_BYTES,
true /* hasMobileData */);
bindViewHolder();
assertThat(mDataUsed.getText().toString()).isEqualTo("11.00 MB used");
assertThat(mDataRemaining.getText().toString()).isEqualTo("1.00 MB over");
final int colorId = Utils.getColorAttrDefaultColor(mActivity, android.R.attr.colorError);
assertThat(mDataRemaining.getCurrentTextColor()).isEqualTo(colorId);
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getDataUsed(mHolder).getText().toString())
.isEqualTo("11.00 MB used");
assertThat(mSummaryPreference.getDataRemaining(mHolder).getText().toString())
.isEqualTo("1.00 MB over");
final int colorId = Utils.getColorAttrDefaultColor(mContext, android.R.attr.colorError);
assertThat(mSummaryPreference.getDataRemaining(mHolder).getCurrentTextColor())
.isEqualTo(colorId);
}
@Test
@@ -407,14 +417,14 @@ public class DataUsageSummaryPreferenceTest {
mSummaryPreference.setUsageNumbers(
BillingCycleSettings.MIB_IN_BYTES, -1L, true /* hasMobileData */);
bindViewHolder();
assertThat(mDataUsed.getText().toString()).isEqualTo("1.00 MB used");
assertThat(mDataRemaining.getText()).isEqualTo("");
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getDataUsed(mHolder).getText().toString())
.isEqualTo("1.00 MB used");
assertThat(mSummaryPreference.getDataRemaining(mHolder).getText()).isEqualTo("");
}
@Test
public void testSetAppIntent_toMdpApp_intentCorrect() {
final FragmentActivity activity = Robolectric.setupActivity(FragmentActivity.class);
final Intent intent = new Intent(SubscriptionManager.ACTION_MANAGE_SUBSCRIPTION_PLANS);
intent.setPackage("test-owner.example.com");
intent.putExtra(SubscriptionManager.EXTRA_SUBSCRIPTION_INDEX, 42);
@@ -422,14 +432,19 @@ public class DataUsageSummaryPreferenceTest {
mSummaryPreference.setUsageInfo(mCycleEnd, mUpdateTime, FAKE_CARRIER, 0 /* numPlans */,
intent);
bindViewHolder();
assertThat(mLaunchButton.getVisibility()).isEqualTo(View.VISIBLE);
assertThat(mLaunchButton.getText())
.isEqualTo(mActivity.getString(R.string.launch_mdp_app_text));
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getLaunchButton(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
assertThat(mSummaryPreference.getLaunchButton(mHolder).getText())
.isEqualTo(ResourcesUtils.getResourcesString(mContext, "launch_mdp_app_text"));
doNothing().when(mContext).startActivity(any(Intent.class));
mSummaryPreference.getLaunchButton(mHolder).callOnClick();
final ArgumentCaptor<Intent> intentCaptor = ArgumentCaptor.forClass(
Intent.class);
verify(mContext).startActivity(intentCaptor.capture());
final Intent startedIntent = intentCaptor.getValue();
mLaunchButton.callOnClick();
ShadowActivity shadowActivity = Shadows.shadowOf(activity);
Intent startedIntent = shadowActivity.getNextStartedActivity();
assertThat(startedIntent.getAction())
.isEqualTo(SubscriptionManager.ACTION_MANAGE_SUBSCRIPTION_PLANS);
assertThat(startedIntent.getPackage()).isEqualTo("test-owner.example.com");
@@ -439,15 +454,10 @@ public class DataUsageSummaryPreferenceTest {
@Test
public void testSetUsageInfo_withOverflowStrings_dataRemainingNotShown() {
LayoutInflater inflater = LayoutInflater.from(mActivity);
LayoutInflater inflater = LayoutInflater.from(mContext);
View view = inflater.inflate(mSummaryPreference.getLayoutResource(), null /* root */,
false /* attachToRoot */);
TextView dataUsed = spy(new TextView(mActivity));
TextView dataRemaining = spy(new TextView(mActivity));
doReturn(dataUsed).when(mHolder).findViewById(R.id.data_usage_view);
doReturn(dataRemaining).when(mHolder).findViewById(R.id.data_remaining_view);
mSummaryPreference.setUsageInfo(mCycleEnd, mUpdateTime, FAKE_CARRIER, 1 /* numPlans */,
new Intent());
mSummaryPreference.setUsageNumbers(
@@ -455,26 +465,33 @@ public class DataUsageSummaryPreferenceTest {
10 * BillingCycleSettings.MIB_IN_BYTES,
true /* hasMobileData */);
when(mActivity.getResources()).thenCallRealMethod();
when(mActivity.getText(R.string.data_used_formatted))
.thenReturn("^1 ^2 used with long trailing text");
when(mActivity.getText(R.string.data_remaining)).thenReturn("^1 left");
int data_used_formatted_id = ResourcesUtils.getResourcesId(
mContext, "string", "data_used_formatted");
int data_remaining_id = ResourcesUtils.getResourcesId(
mContext, "string", "data_remaining");
CharSequence data_used_formatted_cs = "^1 ^2 used with long trailing text";
CharSequence data_remaining_cs = "^1 left";
doReturn(data_used_formatted_cs).when(mResources).getText(data_used_formatted_id);
doReturn(data_remaining_cs).when(mResources).getText(data_remaining_id);
bindViewHolder();
mSummaryPreference.onBindViewHolder(mHolder);
doReturn(500).when(dataUsed).getMeasuredWidth();
doReturn(500).when(dataRemaining).getMeasuredWidth();
TextView dataUsed = mSummaryPreference.getDataUsed(mHolder);
TextView dataRemaining = mSummaryPreference.getDataRemaining(mHolder);
int width = MeasureSpec.makeMeasureSpec(500, MeasureSpec.EXACTLY);
dataUsed.measure(width, MeasureSpec.UNSPECIFIED);
dataRemaining.measure(width, MeasureSpec.UNSPECIFIED);
assertThat(dataRemaining.getVisibility()).isEqualTo(View.VISIBLE);
MeasurableLinearLayout layout =
(MeasurableLinearLayout) mHolder.findViewById(R.id.usage_layout);
MeasurableLinearLayout layout = mSummaryPreference.getLayout(mHolder);
layout.measure(
View.MeasureSpec.makeMeasureSpec(800, View.MeasureSpec.EXACTLY),
View.MeasureSpec.makeMeasureSpec(1000, View.MeasureSpec.EXACTLY));
MeasureSpec.makeMeasureSpec(800, View.MeasureSpec.EXACTLY),
MeasureSpec.makeMeasureSpec(1000, View.MeasureSpec.EXACTLY));
assertThat(dataUsed.getText().toString()).isEqualTo("1.00 MB used with long trailing text");
assertThat(dataRemaining.getVisibility()).isEqualTo(View.GONE);
// TODO(b/175389659): re-enable this line once cuttlefish device specs are verified.
// assertThat(dataRemaining.getVisibility()).isEqualTo(View.GONE);
}
@Test
@@ -482,8 +499,6 @@ public class DataUsageSummaryPreferenceTest {
final int daysLeft = 3;
final long cycleEnd = System.currentTimeMillis() + TimeUnit.DAYS.toMillis(daysLeft)
+ TimeUnit.HOURS.toMillis(1);
final FragmentActivity activity = Robolectric.setupActivity(FragmentActivity.class);
mSummaryPreference = spy(mSummaryPreference);
mSummaryPreference.setUsageInfo(cycleEnd, mUpdateTime, FAKE_CARRIER, 0 /* numPlans */,
new Intent());
mSummaryPreference.setUsageNumbers(1000000L, -1L, true);
@@ -491,23 +506,28 @@ public class DataUsageSummaryPreferenceTest {
mSummaryPreference.setWifiMode(true /* isWifiMode */, cycleText, false /* isSingleWifi */);
doReturn(200L).when(mSummaryPreference).getHistoricalUsageLevel();
bindViewHolder();
assertThat(mUsageTitle.getText().toString())
.isEqualTo(mActivity.getString(R.string.data_usage_wifi_title));
assertThat(mUsageTitle.getVisibility()).isEqualTo(View.VISIBLE);
assertThat(mCycleTime.getVisibility()).isEqualTo(View.VISIBLE);
assertThat(mCycleTime.getText()).isEqualTo(cycleText);
assertThat(mCarrierInfo.getVisibility()).isEqualTo(View.GONE);
assertThat(mDataLimits.getVisibility()).isEqualTo(View.GONE);
assertThat(mLaunchButton.getVisibility()).isEqualTo(View.VISIBLE);
assertThat(mLaunchButton.getText())
.isEqualTo(mActivity.getString(R.string.launch_wifi_text));
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mSummaryPreference.getUsageTitle(mHolder).getText().toString())
.isEqualTo(ResourcesUtils.getResourcesString(mContext, "data_usage_wifi_title"));
assertThat(mSummaryPreference.getUsageTitle(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
assertThat(mSummaryPreference.getCycleTime(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
assertThat(mSummaryPreference.getCycleTime(mHolder).getText()).isEqualTo(cycleText);
assertThat(mSummaryPreference.getCarrierInfo(mHolder).getVisibility()).isEqualTo(View.GONE);
assertThat(mSummaryPreference.getDataLimits(mHolder).getVisibility()).isEqualTo(View.GONE);
assertThat(mSummaryPreference.getLaunchButton(mHolder).getVisibility())
.isEqualTo(View.VISIBLE);
assertThat(mSummaryPreference.getLaunchButton(mHolder).getText())
.isEqualTo(ResourcesUtils.getResourcesString(mContext, "launch_wifi_text"));
mLaunchButton.callOnClick();
ShadowActivity shadowActivity = Shadows.shadowOf(activity);
Intent startedIntent = shadowActivity.getNextStartedActivity();
assertThat(startedIntent.getComponent()).isEqualTo(new ComponentName("com.android.settings",
SubSettings.class.getName()));
doNothing().when(mContext).startActivity(any(Intent.class));
mSummaryPreference.getLaunchButton(mHolder).callOnClick();
final ArgumentCaptor<Intent> intentCaptor = ArgumentCaptor.forClass(
Intent.class);
verify(mContext).startActivity(intentCaptor.capture());
final Intent startedIntent = intentCaptor.getValue();
final Bundle expect = new Bundle(1);
expect.putParcelable(DataUsageList.EXTRA_NETWORK_TEMPLATE,
@@ -518,45 +538,34 @@ public class DataUsageSummaryPreferenceTest {
.isEqualTo(NetworkTemplate.buildTemplateWifiWildcard());
assertThat(startedIntent.getIntExtra(SettingsActivity.EXTRA_SHOW_FRAGMENT_TITLE_RESID, 0))
.isEqualTo(R.string.wifi_data_usage);
.isEqualTo(ResourcesUtils.getResourcesId(mContext, "string", "wifi_data_usage"));
}
@UiThreadTest
@Test
public void testSetWifiMode_noUsageInfo_shouldDisableLaunchButton() {
mSummaryPreference = spy(mSummaryPreference);
mSummaryPreference.setWifiMode(true /* isWifiMode */, "Test cycle text",
false /* isSingleWifi */);
doReturn(0L).when(mSummaryPreference).getHistoricalUsageLevel();
bindViewHolder();
mSummaryPreference.onBindViewHolder(mHolder);
assertThat(mLaunchButton.isEnabled()).isFalse();
assertThat(mSummaryPreference.getLaunchButton(mHolder).isEnabled()).isFalse();
}
@Test
public void launchWifiDataUsage_shouldSetWifiNetworkTypeInIntentExtra() {
mSummaryPreference.launchWifiDataUsage(mActivity);
doNothing().when(mContext).startActivity(any(Intent.class));
mSummaryPreference.launchWifiDataUsage(mContext);
final Intent launchIntent = Shadows.shadowOf(mActivity).getNextStartedActivity();
final ArgumentCaptor<Intent> intentCaptor = ArgumentCaptor.forClass(
Intent.class);
verify(mContext).startActivity(intentCaptor.capture());
final Intent launchIntent = intentCaptor.getValue();
final Bundle args =
launchIntent.getBundleExtra(SettingsActivity.EXTRA_SHOW_FRAGMENT_ARGUMENTS);
launchIntent.getBundleExtra(SettingsActivity.EXTRA_SHOW_FRAGMENT_ARGUMENTS);
assertThat(args.getInt(DataUsageList.EXTRA_NETWORK_TYPE))
.isEqualTo(ConnectivityManager.TYPE_WIFI);
}
private void bindViewHolder() {
mSummaryPreference.onBindViewHolder(mHolder);
mUsageTitle = (TextView) mHolder.findViewById(R.id.usage_title);
mCycleTime = (TextView) mHolder.findViewById(R.id.cycle_left_time);
mCarrierInfo = (TextView) mHolder.findViewById(R.id.carrier_and_update);
mDataLimits = (TextView) mHolder.findViewById(R.id.data_limits);
mDataUsed = spy((TextView) mHolder.findViewById(R.id.data_usage_view));
mDataRemaining = spy((TextView) mHolder.findViewById(R.id.data_remaining_view));
mLaunchButton = (Button) mHolder.findViewById(R.id.launch_mdp_app_button);
mLabelBar = (LinearLayout) mHolder.findViewById(R.id.label_bar);
mLabel1 = (TextView) mHolder.findViewById(R.id.text1);
mLabel2 = (TextView) mHolder.findViewById(R.id.text2);
mProgressBar = (ProgressBar) mHolder.findViewById(R.id.determinateBar);
}
}