PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable Mobile settings in one condition.

Browse Source 
If there is no active subscription and esim is unsupported, disable
this preference.

Bug: 129143739
Test: RunSettingsRoboTests
Change-Id: I5f8b0d95df8764a3a505aae5e26df42e9412c021
This commit is contained in:
Lei Yu
2019-04-15 12:28:53 -07:00
parent fd3cf32ad8
commit 8164361792
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/com/android/settings/network/MobileNetworkSummaryController.java
View File

@@ -137,6 +137,8 @@ public class MobileNetworkSummaryController extends AbstractPreferenceController
startAddSimFlow(); startAddSimFlow();
return true; return true;
}); });
} else {
mPreference.setEnabled(false);
} }
} else { } else {
// We have one or more existing subscriptions, so we want the plus button if eSIM is // We have one or more existing subscriptions, so we want the plus button if eSIM is

12
tests/robotests/src/com/android/settings/network/MobileNetworkSummaryControllerTest.java
View File

@@ -282,6 +282,18 @@ public class MobileNetworkSummaryControllerTest {
assertThat(captor.getValue()).isFalse(); assertThat(captor.getValue()).isFalse();
} }
@Test
public void onResume_noSubscriptionEsimDisabled_isDisabled() {
Settings.Global.putInt(mContext.getContentResolver(), Settings.Global.AIRPLANE_MODE_ON, 0);
SubscriptionUtil.setAvailableSubscriptionsForTesting(null);
when(mEuiccManager.isEnabled()).thenReturn(false);
mController.displayPreference(mPreferenceScreen);
mController.onResume();
assertThat(mPreference.isEnabled()).isFalse();
}
@Test @Test
public void onAirplaneModeChanged_oneSubscriptionAirplaneModeGetsTurnedOn_isDisabled() { public void onAirplaneModeChanged_oneSubscriptionAirplaneModeGetsTurnedOn_isDisabled() {
final SubscriptionInfo sub1 = mock(SubscriptionInfo.class); final SubscriptionInfo sub1 = mock(SubscriptionInfo.class);