Merge "Show "uninstall for all users" when >1 users installed it."

This commit is contained in:
Lei Yu
2016-11-02 23:21:35 +00:00
committed by Android (Google) Code Review
2 changed files with 127 additions and 0 deletions

View File

@@ -54,6 +54,7 @@ import android.os.UserHandle;
import android.os.UserManager;
import android.provider.Settings;
import android.service.notification.NotificationListenerService.Ranking;
import android.support.annotation.VisibleForTesting;
import android.support.v7.preference.Preference;
import android.support.v7.preference.Preference.OnPreferenceClickListener;
import android.support.v7.preference.PreferenceCategory;
@@ -493,6 +494,8 @@ public class InstalledAppDetails extends AppInfoBase
showIt = false;
} else if (mUserManager.getUsers().size() < 2) {
showIt = false;
} else if (PackageUtil.countPackageInUsers(mPm, mUserManager, mPackageName) < 2) {
showIt = false;
}
menu.findItem(UNINSTALL_ALL_USERS_MENU).setVisible(showIt);
mUpdatedSysApp = (mAppEntry.info.flags & ApplicationInfo.FLAG_UPDATED_SYSTEM_APP) != 0;
@@ -1213,6 +1216,37 @@ public class InstalledAppDetails extends AppInfoBase
}
}
/**
* Elicit this class for testing. Test cannot be done in robolectric because it
* invokes the new API.
*/
@VisibleForTesting
public static class PackageUtil {
/**
* Count how many users in device have installed package {@paramref packageName}
*/
public static int countPackageInUsers(PackageManager packageManager, UserManager
userManager, String packageName) {
final List<UserInfo> userInfos = userManager.getUsers(true);
int count = 0;
for (final UserInfo userInfo : userInfos) {
try {
// Use this API to check whether user has this package
final ApplicationInfo info = packageManager.getApplicationInfoAsUser(
packageName, PackageManager.GET_META_DATA, userInfo.id);
if ((info.flags & ApplicationInfo.FLAG_INSTALLED) != 0) {
count++;
}
} catch(NameNotFoundException e) {
Log.e(TAG, "Package: " + packageName + " not found for user: " + userInfo.id);
}
}
return count;
}
}
private static class DisableChanger extends AsyncTask<Object, Object, Object> {
final PackageManager mPm;
final WeakReference<InstalledAppDetails> mActivity;