Fixing bug 2455152 - Enabled accessibility services are disabled upon restarting accessibility

This commit is contained in:
Svetoslav Ganov
2010-02-18 17:20:10 -08:00
parent fae5ed1eeb
commit 80d6c74bb9

View File

@@ -105,8 +105,6 @@ public class AccessibilitySettings extends PreferenceActivity {
if (!accessibilityServices.isEmpty()) { if (!accessibilityServices.isEmpty()) {
if (serviceState == 1) { if (serviceState == 1) {
mToggleCheckBox.setChecked(true); mToggleCheckBox.setChecked(true);
} else {
setAccessibilityServicePreferencesState(false);
} }
mToggleCheckBox.setEnabled(true); mToggleCheckBox.setEnabled(true);
} else { } else {
@@ -114,7 +112,6 @@ public class AccessibilitySettings extends PreferenceActivity {
// no service and accessibility is enabled => disable // no service and accessibility is enabled => disable
Settings.Secure.putInt(getContentResolver(), Settings.Secure.putInt(getContentResolver(),
Settings.Secure.ACCESSIBILITY_ENABLED, 0); Settings.Secure.ACCESSIBILITY_ENABLED, 0);
setAccessibilityServicePreferencesState(false);
} }
mToggleCheckBox.setEnabled(false); mToggleCheckBox.setEnabled(false);
// Notify user that they do not have any accessibility apps // Notify user that they do not have any accessibility apps
@@ -130,26 +127,6 @@ public class AccessibilitySettings extends PreferenceActivity {
persistEnabledAccessibilityServices(); persistEnabledAccessibilityServices();
} }
/**
* Sets the state of the preferences for enabling/disabling AccessibilityServices.
*
* @param isEnabled If to enable or disable the preferences.
*/
private void setAccessibilityServicePreferencesState(boolean isEnabled) {
if (mAccessibilityServicesCategory == null) {
return;
}
int count = mAccessibilityServicesCategory.getPreferenceCount();
for (int i = 0; i < count; i++) {
Preference pref = mAccessibilityServicesCategory.getPreference(i);
pref.setEnabled(isEnabled);
if (!isEnabled){
((CheckBoxPreference) pref).setChecked(false);
}
}
}
@Override @Override
public boolean onPreferenceTreeClick(PreferenceScreen preferenceScreen, Preference preference) { public boolean onPreferenceTreeClick(PreferenceScreen preferenceScreen, Preference preference) {
final String key = preference.getKey(); final String key = preference.getKey();
@@ -173,7 +150,6 @@ public class AccessibilitySettings extends PreferenceActivity {
if (preference.isChecked()) { if (preference.isChecked()) {
Settings.Secure.putInt(getContentResolver(), Settings.Secure.putInt(getContentResolver(),
Settings.Secure.ACCESSIBILITY_ENABLED, 1); Settings.Secure.ACCESSIBILITY_ENABLED, 1);
setAccessibilityServicePreferencesState(true);
} else { } else {
final CheckBoxPreference checkBoxPreference = preference; final CheckBoxPreference checkBoxPreference = preference;
AlertDialog dialog = (new AlertDialog.Builder(this)) AlertDialog dialog = (new AlertDialog.Builder(this))
@@ -186,7 +162,6 @@ public class AccessibilitySettings extends PreferenceActivity {
public void onClick(DialogInterface dialog, int which) { public void onClick(DialogInterface dialog, int which) {
Settings.Secure.putInt(getContentResolver(), Settings.Secure.putInt(getContentResolver(),
Settings.Secure.ACCESSIBILITY_ENABLED, 0); Settings.Secure.ACCESSIBILITY_ENABLED, 0);
setAccessibilityServicePreferencesState(false);
} }
}) })
.setNegativeButton(android.R.string.cancel, .setNegativeButton(android.R.string.cancel,