diff --git a/src/com/android/settings/gestures/AssistGestureSettings.java b/src/com/android/settings/gestures/AssistGestureSettings.java index f457320eff1..1d827207989 100644 --- a/src/com/android/settings/gestures/AssistGestureSettings.java +++ b/src/com/android/settings/gestures/AssistGestureSettings.java @@ -22,6 +22,7 @@ import android.provider.SearchIndexableResource; import com.android.internal.logging.nano.MetricsProto; import com.android.settings.R; import com.android.settings.core.PreferenceController; +import com.android.settings.core.lifecycle.Lifecycle; import com.android.settings.dashboard.DashboardFragment; import com.android.settings.overlay.FeatureFactory; import com.android.settings.search.BaseSearchIndexProvider; @@ -51,8 +52,13 @@ public class AssistGestureSettings extends DashboardFragment { @Override protected List getPreferenceControllers(Context context) { + return buildPreferenceControllers(context, getLifecycle()); + } + + private static List buildPreferenceControllers(Context context, + Lifecycle lifecycle) { final List controllers = new ArrayList<>(); - controllers.add(new AssistGesturePreferenceController(context, getLifecycle())); + controllers.add(new AssistGesturePreferenceController(context, lifecycle)); return controllers; } @@ -69,6 +75,11 @@ public class AssistGestureSettings extends DashboardFragment { sir.xmlResId = R.xml.assist_gesture_settings; return Arrays.asList(sir); } + + @Override + public List getPreferenceControllers(Context context) { + return buildPreferenceControllers(context, null /* lifecycle */); + } }; } diff --git a/src/com/android/settings/gestures/DoubleTapPowerSettings.java b/src/com/android/settings/gestures/DoubleTapPowerSettings.java index 9251f0b5a82..b17341a124d 100644 --- a/src/com/android/settings/gestures/DoubleTapPowerSettings.java +++ b/src/com/android/settings/gestures/DoubleTapPowerSettings.java @@ -22,6 +22,7 @@ import android.provider.SearchIndexableResource; import com.android.internal.logging.nano.MetricsProto; import com.android.settings.R; import com.android.settings.core.PreferenceController; +import com.android.settings.core.lifecycle.Lifecycle; import com.android.settings.dashboard.DashboardFragment; import com.android.settings.overlay.FeatureFactory; import com.android.settings.search.BaseSearchIndexProvider; @@ -51,8 +52,13 @@ public class DoubleTapPowerSettings extends DashboardFragment { @Override protected List getPreferenceControllers(Context context) { + return buildPreferenceControllers(context, getLifecycle()); + } + + private static List buildPreferenceControllers(Context context, + Lifecycle lifecycle) { final List controllers = new ArrayList<>(); - controllers.add(new DoubleTapPowerPreferenceController(context, getLifecycle())); + controllers.add(new DoubleTapPowerPreferenceController(context, lifecycle)); return controllers; } @@ -69,5 +75,10 @@ public class DoubleTapPowerSettings extends DashboardFragment { sir.xmlResId = R.xml.double_tap_power_settings; return Arrays.asList(sir); } + + @Override + public List getPreferenceControllers(Context context) { + return buildPreferenceControllers(context, null /* lifecycle */); + } }; } diff --git a/src/com/android/settings/gestures/DoubleTapScreenSettings.java b/src/com/android/settings/gestures/DoubleTapScreenSettings.java index f374f9ea68b..a215daed48a 100644 --- a/src/com/android/settings/gestures/DoubleTapScreenSettings.java +++ b/src/com/android/settings/gestures/DoubleTapScreenSettings.java @@ -24,6 +24,7 @@ import com.android.internal.hardware.AmbientDisplayConfiguration; import com.android.internal.logging.nano.MetricsProto; import com.android.settings.R; import com.android.settings.core.PreferenceController; +import com.android.settings.core.lifecycle.Lifecycle; import com.android.settings.dashboard.DashboardFragment; import com.android.settings.overlay.FeatureFactory; import com.android.settings.search.BaseSearchIndexProvider; @@ -53,8 +54,13 @@ public class DoubleTapScreenSettings extends DashboardFragment { @Override protected List getPreferenceControllers(Context context) { + return buildPreferenceControllers(context, getLifecycle()); + } + + private static List buildPreferenceControllers(Context context, + Lifecycle lifecycle) { final List controllers = new ArrayList<>(); - controllers.add(new DoubleTapScreenPreferenceController(context, getLifecycle(), + controllers.add(new DoubleTapScreenPreferenceController(context, lifecycle, new AmbientDisplayConfiguration(context), UserHandle.myUserId())); return controllers; } @@ -72,5 +78,10 @@ public class DoubleTapScreenSettings extends DashboardFragment { sir.xmlResId = R.xml.double_tap_screen_settings; return Arrays.asList(sir); } + + @Override + public List getPreferenceControllers(Context context) { + return buildPreferenceControllers(context, null /* lifecycle */); + } }; } diff --git a/src/com/android/settings/gestures/DoubleTwistGestureSettings.java b/src/com/android/settings/gestures/DoubleTwistGestureSettings.java index 5f5b8737b75..bee9474eb32 100644 --- a/src/com/android/settings/gestures/DoubleTwistGestureSettings.java +++ b/src/com/android/settings/gestures/DoubleTwistGestureSettings.java @@ -22,6 +22,7 @@ import android.provider.SearchIndexableResource; import com.android.internal.logging.nano.MetricsProto; import com.android.settings.R; import com.android.settings.core.PreferenceController; +import com.android.settings.core.lifecycle.Lifecycle; import com.android.settings.dashboard.DashboardFragment; import com.android.settings.overlay.FeatureFactory; import com.android.settings.search.BaseSearchIndexProvider; @@ -51,8 +52,13 @@ public class DoubleTwistGestureSettings extends DashboardFragment { @Override protected List getPreferenceControllers(Context context) { + return buildPreferenceControllers(context, getLifecycle()); + } + + private static List buildPreferenceControllers(Context context, + Lifecycle lifecycle) { final List controllers = new ArrayList<>(); - controllers.add(new DoubleTwistPreferenceController(context, getLifecycle())); + controllers.add(new DoubleTwistPreferenceController(context, lifecycle)); return controllers; } @@ -69,5 +75,11 @@ public class DoubleTwistGestureSettings extends DashboardFragment { sir.xmlResId = R.xml.double_twist_gesture_settings; return Arrays.asList(sir); } + + @Override + public List getPreferenceControllers(Context context) { + return buildPreferenceControllers(context, null /* lifecycle */); + } }; + } diff --git a/src/com/android/settings/gestures/PickupGestureSettings.java b/src/com/android/settings/gestures/PickupGestureSettings.java index 08e61fa5ea1..e4d12f2c0a7 100644 --- a/src/com/android/settings/gestures/PickupGestureSettings.java +++ b/src/com/android/settings/gestures/PickupGestureSettings.java @@ -24,6 +24,7 @@ import com.android.internal.hardware.AmbientDisplayConfiguration; import com.android.internal.logging.nano.MetricsProto; import com.android.settings.R; import com.android.settings.core.PreferenceController; +import com.android.settings.core.lifecycle.Lifecycle; import com.android.settings.dashboard.DashboardFragment; import com.android.settings.overlay.FeatureFactory; import com.android.settings.search.BaseSearchIndexProvider; @@ -53,8 +54,13 @@ public class PickupGestureSettings extends DashboardFragment { @Override protected List getPreferenceControllers(Context context) { + return buildPreferenceControllers(context, getLifecycle()); + } + + private static List buildPreferenceControllers(Context context, + Lifecycle lifecycle) { final List controllers = new ArrayList<>(); - controllers.add(new PickupGesturePreferenceController(context, getLifecycle(), + controllers.add(new PickupGesturePreferenceController(context, lifecycle, new AmbientDisplayConfiguration(context), UserHandle.myUserId())); return controllers; } @@ -72,6 +78,11 @@ public class PickupGestureSettings extends DashboardFragment { sir.xmlResId = R.xml.pick_up_gesture_settings; return Arrays.asList(sir); } + + @Override + public List getPreferenceControllers(Context context) { + return buildPreferenceControllers(context, null /* lifecycle */); + } }; } diff --git a/src/com/android/settings/gestures/SwipeToNotificationSettings.java b/src/com/android/settings/gestures/SwipeToNotificationSettings.java index 155412ca452..d948e55bafc 100644 --- a/src/com/android/settings/gestures/SwipeToNotificationSettings.java +++ b/src/com/android/settings/gestures/SwipeToNotificationSettings.java @@ -22,6 +22,7 @@ import android.provider.SearchIndexableResource; import com.android.internal.logging.nano.MetricsProto; import com.android.settings.R; import com.android.settings.core.PreferenceController; +import com.android.settings.core.lifecycle.Lifecycle; import com.android.settings.dashboard.DashboardFragment; import com.android.settings.overlay.FeatureFactory; import com.android.settings.search.BaseSearchIndexProvider; @@ -51,8 +52,13 @@ public class SwipeToNotificationSettings extends DashboardFragment { @Override protected List getPreferenceControllers(Context context) { + return buildPreferenceControllers(context, getLifecycle()); + } + + private static List buildPreferenceControllers(Context context, + Lifecycle lifecycle) { final List controllers = new ArrayList<>(); - controllers.add(new SwipeToNotificationPreferenceController(context, getLifecycle())); + controllers.add(new SwipeToNotificationPreferenceController(context, lifecycle)); return controllers; } @@ -69,5 +75,10 @@ public class SwipeToNotificationSettings extends DashboardFragment { sir.xmlResId = R.xml.swipe_to_notification_settings; return Arrays.asList(sir); } + + @Override + public List getPreferenceControllers(Context context) { + return buildPreferenceControllers(context, null /* lifecycle */); + } }; } diff --git a/tests/robotests/assets/grandfather_not_sharing_pref_controllers_with_search_provider b/tests/robotests/assets/grandfather_not_sharing_pref_controllers_with_search_provider index cb04679fc48..8184d2cfe77 100644 --- a/tests/robotests/assets/grandfather_not_sharing_pref_controllers_with_search_provider +++ b/tests/robotests/assets/grandfather_not_sharing_pref_controllers_with_search_provider @@ -1,11 +1,5 @@ -com.android.settings.gestures.PickupGestureSettings com.android.settings.language.LanguageAndInputSettings com.android.settings.enterprise.EnterprisePrivacySettings -com.android.settings.gestures.DoubleTapScreenSettings com.android.settings.applications.AdvancedAppSettings -com.android.settings.gestures.AssistGestureSettings com.android.settings.fuelgauge.PowerUsageSummary -com.android.settings.gestures.SwipeToNotificationSettings com.android.settings.inputmethod.InputMethodAndLanguageSettings -com.android.settings.gestures.DoubleTapPowerSettings -com.android.settings.gestures.DoubleTwistGestureSettings \ No newline at end of file