Merge "Change zen mode schedules page rule handling" into tm-dev am: 9fb3262a1a
am: 24c9dd2808
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/18189363 Change-Id: I7e0648c0c1f93a0761c917573f40508a1eb49d92 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
This commit is contained in:
@@ -18,6 +18,7 @@ package com.android.settings.notification.zen;
|
||||
|
||||
import android.app.AutomaticZenRule;
|
||||
import android.content.Context;
|
||||
import android.util.ArrayMap;
|
||||
|
||||
import androidx.annotation.VisibleForTesting;
|
||||
import androidx.fragment.app.Fragment;
|
||||
@@ -28,7 +29,6 @@ import androidx.preference.PreferenceScreen;
|
||||
import com.android.settingslib.core.lifecycle.Lifecycle;
|
||||
|
||||
import java.util.Map;
|
||||
import java.util.Objects;
|
||||
|
||||
public class ZenModeAutomaticRulesPreferenceController extends
|
||||
AbstractZenModeAutomaticRulePreferenceController {
|
||||
@@ -38,6 +38,10 @@ public class ZenModeAutomaticRulesPreferenceController extends
|
||||
@VisibleForTesting
|
||||
protected PreferenceCategory mPreferenceCategory;
|
||||
|
||||
// Map of rule key -> preference so that we can update each preference as needed
|
||||
@VisibleForTesting
|
||||
protected Map<String, ZenRulePreference> mZenRulePreferences = new ArrayMap<>();
|
||||
|
||||
public ZenModeAutomaticRulesPreferenceController(Context context, Fragment parent, Lifecycle
|
||||
lifecycle) {
|
||||
super(context, KEY, parent, lifecycle);
|
||||
@@ -58,38 +62,73 @@ public class ZenModeAutomaticRulesPreferenceController extends
|
||||
super.displayPreference(screen);
|
||||
mPreferenceCategory = screen.findPreference(getPreferenceKey());
|
||||
mPreferenceCategory.setPersistent(false);
|
||||
|
||||
// if mPreferenceCategory was un-set, make sure to clear out mZenRulePreferences too, just
|
||||
// in case
|
||||
if (mPreferenceCategory.getPreferenceCount() == 0) {
|
||||
mZenRulePreferences.clear();
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public void updateState(Preference preference) {
|
||||
super.updateState(preference);
|
||||
Map.Entry<String, AutomaticZenRule>[] sortedRules = getRules();
|
||||
final int currNumPreferences = mPreferenceCategory.getPreferenceCount();
|
||||
if (currNumPreferences == sortedRules.length) {
|
||||
|
||||
// refresh the whole preference category list if the total number of rules has changed, or
|
||||
// if any individual rules have changed, so we can rebuild the list & keep things in sync
|
||||
boolean refreshPrefs = false;
|
||||
if (mPreferenceCategory.getPreferenceCount() != sortedRules.length) {
|
||||
refreshPrefs = true;
|
||||
} else {
|
||||
// check whether any rules in sortedRules are not in mZenRulePreferences; that should
|
||||
// be enough to see whether something has changed
|
||||
for (int i = 0; i < sortedRules.length; i++) {
|
||||
ZenRulePreference pref = (ZenRulePreference) mPreferenceCategory.getPreference(i);
|
||||
// we are either:
|
||||
// 1. updating everything about the rule
|
||||
// 2. rule was added or deleted, so reload the entire list
|
||||
if (Objects.equals(pref.mId, sortedRules[i].getKey())) {
|
||||
AutomaticZenRule rule = sortedRules[i].getValue();
|
||||
pref.updatePreference(rule);
|
||||
} else {
|
||||
reloadAllRules(sortedRules);
|
||||
if (!mZenRulePreferences.containsKey(sortedRules[i].getKey())) {
|
||||
refreshPrefs = true;
|
||||
break;
|
||||
}
|
||||
}
|
||||
} else {
|
||||
reloadAllRules(sortedRules);
|
||||
}
|
||||
}
|
||||
|
||||
@VisibleForTesting
|
||||
void reloadAllRules(Map.Entry<String, AutomaticZenRule>[] rules) {
|
||||
mPreferenceCategory.removeAll();
|
||||
for (Map.Entry<String, AutomaticZenRule> rule : rules) {
|
||||
ZenRulePreference pref = createZenRulePreference(rule);
|
||||
mPreferenceCategory.addPreference(pref);
|
||||
// if we need to refresh the whole list, clear the preference category and also start a
|
||||
// new map of preferences according to the preference category contents
|
||||
// we need to not update the existing one yet, as we'll need to know what preferences
|
||||
// previously existed in order to update and re-attach them to the preference category
|
||||
Map<String, ZenRulePreference> newPrefs = new ArrayMap<>();
|
||||
if (refreshPrefs) {
|
||||
mPreferenceCategory.removeAll();
|
||||
}
|
||||
|
||||
// Loop through each rule, either updating the existing rule or creating the rule's
|
||||
// preference if needed (and, in the case where we need to rebuild the preference category
|
||||
// list, do so as well)
|
||||
for (int i = 0; i < sortedRules.length; i++) {
|
||||
String key = sortedRules[i].getKey();
|
||||
if (mZenRulePreferences.containsKey(key)) {
|
||||
// existing rule; update its info if it's changed since the last display
|
||||
AutomaticZenRule rule = sortedRules[i].getValue();
|
||||
ZenRulePreference pref = mZenRulePreferences.get(key);
|
||||
pref.updatePreference(rule);
|
||||
|
||||
// only add to preference category if the overall set of rules has changed so this
|
||||
// needs to be rearranged
|
||||
if (refreshPrefs) {
|
||||
mPreferenceCategory.addPreference(pref);
|
||||
newPrefs.put(key, pref);
|
||||
}
|
||||
} else {
|
||||
// new rule; create a new ZenRulePreference & add it to the preference category
|
||||
// and the map so we'll know about it later
|
||||
ZenRulePreference pref = createZenRulePreference(sortedRules[i]);
|
||||
mPreferenceCategory.addPreference(pref);
|
||||
newPrefs.put(key, pref);
|
||||
}
|
||||
}
|
||||
|
||||
// If anything was new, then make sure we overwrite mZenRulePreferences with our new data
|
||||
if (refreshPrefs) {
|
||||
mZenRulePreferences = newPrefs;
|
||||
}
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user