PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update screen lock and biometrics options in order

Browse Source 
Previously the screen lock and biometrics order is :
UI & UX: b/182806496, b/183649070
- PIN • Face • Fingerprint
- Pattern • Face • Fingerprint
- Password • Face • Fingerprint

By requirement, we need to reverse Fingerprint & Face position
- PIN • Fingerprint • Face
- Pattern • Fingerprint • Face
- Password • Fingerprint • Face

Also remove unused strings

Fixes: 242143765
Test: Manual login corp, and observe the UI in Choose screen lock
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.password
Change-Id: I1938f867360512121ecfdae8e2ca6de7002156f4
This commit is contained in:
lbill
2023-07-04 01:25:52 +00:00
committed by Bill Lin
parent 114d068fbb
commit 7f8197da82
3 changed files with 29 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
tests/robotests/src/com/android/settings/password/ChooseLockGenericTest.java
View File

@@ -60,6 +60,7 @@ import com.android.internal.widget.LockPatternUtils;
import com.android.internal.widget.LockscreenCredential;
import com.android.settings.R;
import com.android.settings.biometrics.BiometricEnrollBase;
import com.android.settings.biometrics.BiometricUtils;
import com.android.settings.password.ChooseLockGeneric.ChooseLockGenericFragment;
import com.android.settings.search.SearchFeatureProvider;
import com.android.settings.testutils.FakeFeatureFactory;
@@ -543,29 +544,38 @@ public class ChooseLockGenericTest {
}
@Test
public void updatePreferenceText_supportBiometrics_showFaceAndFingerprint() {
public void updatePreferenceText_supportBiometrics_setScreenLockFingerprintFace_inOrder() {
ShadowStorageManager.setIsFileEncrypted(false);
final Intent intent = new Intent().putExtra(EXTRA_KEY_FOR_BIOMETRICS, true);
initActivity(intent);
final String supportFingerprint = capitalize(mActivity.getResources().getString(
R.string.security_settings_fingerprint));
final String supportFace = capitalize(mActivity.getResources().getString(
R.string.keywords_face_settings));
String pinTitle =
// The strings of golden copy
final String pinFingerprintFace = mActivity.getText(R.string.unlock_set_unlock_pin_title)
+ BiometricUtils.SEPARATOR + supportFingerprint + BiometricUtils.SEPARATOR
+ supportFace;
final String patternFingerprintFace = mActivity.getText(
R.string.unlock_set_unlock_pattern_title) + BiometricUtils.SEPARATOR
+ supportFingerprint + BiometricUtils.SEPARATOR + supportFace;
final String passwordFingerprintFace = mActivity.getText(
R.string.unlock_set_unlock_password_title) + BiometricUtils.SEPARATOR
+ supportFingerprint + BiometricUtils.SEPARATOR + supportFace;
// The strings obtain from preferences
final String pinTitle =
(String) mFragment.findPreference(ScreenLockType.PIN.preferenceKey).getTitle();
String patternTitle =
final String patternTitle =
(String) mFragment.findPreference(ScreenLockType.PATTERN.preferenceKey).getTitle();
String passwordTitle =
final String passwordTitle =
(String) mFragment.findPreference(ScreenLockType.PASSWORD.preferenceKey).getTitle();
assertThat(pinTitle).contains(supportFingerprint);
assertThat(pinTitle).contains(supportFace);
assertThat(patternTitle).contains(supportFingerprint);
assertThat(patternTitle).contains(supportFace);
assertThat(passwordTitle).contains(supportFingerprint);
assertThat(passwordTitle).contains(supportFace);
assertThat(pinTitle).isEqualTo(pinFingerprintFace);
assertThat(patternTitle).isEqualTo(patternFingerprintFace);
assertThat(passwordTitle).isEqualTo(passwordFingerprintFace);
}
@Test