Refactor new tether settings to remove SharedPreferences

Bluetooth, USB and Wifi Disable tether preferences will turn on/off that
type of tethering interface instantly without storing it into
SharedPreferences. They are listening to TetherEnabler to update their
state.
Refactored to remove dependancy on SharedPreferences.

Bug: 151367756
Test: TetherEnablerTest; BluetoothTetherPreferenceControllerTest;
UsbTetherPreferenceControllerTest;
WifiTetherDisablePreferenceControllerTest; AllInOneSettingsTest;
AllInOneTetherPreferenceControllerTest

Change-Id: Ia6cc60bc4de8f08413beb6d41552a18f6fa6a55b

src/com/android/settings/network/UsbTetherPreferenceController.java

@@ -20,60 +20,52 @@ import android.content.BroadcastReceiver;
 import android.content.Context;
 import android.content.Intent;
 import android.content.IntentFilter;
-import android.content.SharedPreferences;
 import android.hardware.usb.UsbManager;
-import android.net.ConnectivityManager;
+import android.net.TetheringManager;
 import android.os.Environment;
 import android.text.TextUtils;
-import android.util.Log;
 
+import androidx.annotation.VisibleForTesting;
 import androidx.lifecycle.Lifecycle;
 import androidx.lifecycle.LifecycleObserver;
 import androidx.lifecycle.OnLifecycleEvent;
 import androidx.preference.Preference;
-import androidx.preference.PreferenceScreen;
 
-import com.android.internal.annotations.VisibleForTesting;
 import com.android.settings.Utils;
-import com.android.settings.core.TogglePreferenceController;
 
 /**
  * This controller helps to manage the switch state and visibility of USB tether switch
  * preference. It stores preference values when preference changed.
  *
  */
-public final class UsbTetherPreferenceController extends TogglePreferenceController implements
-        LifecycleObserver, SharedPreferences.OnSharedPreferenceChangeListener {
+public final class UsbTetherPreferenceController extends TetherBasePreferenceController implements
+        LifecycleObserver {
 
     private static final String TAG = "UsbTetherPrefController";
-    private static final boolean DEBUG = Log.isLoggable(TAG, Log.DEBUG);
 
-    private final ConnectivityManager mCm;
     private boolean mUsbConnected;
     private boolean mMassStorageActive;
-    private Preference mPreference;
-    private final SharedPreferences mSharedPreferences;
+    private boolean mUsbTethering;
 
     public UsbTetherPreferenceController(Context context, String prefKey) {
         super(context, prefKey);
-        mCm = (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
-        mSharedPreferences =
-                context.getSharedPreferences(TetherEnabler.SHARED_PREF, Context.MODE_PRIVATE);
     }
 
     @Override
     public boolean isChecked() {
-        return mSharedPreferences.getBoolean(mPreferenceKey, false);
+        return mUsbTethering;
     }
 
     @Override
     public boolean setChecked(boolean isChecked) {
-        if (DEBUG) {
-            Log.d(TAG, "preference changing to " + isChecked);
+        if (mTetherEnabler == null) {
+            return false;
+        }
+        if (isChecked) {
+            mTetherEnabler.startTethering(TetheringManager.TETHERING_USB);
+        } else {
+            mTetherEnabler.stopTethering(TetheringManager.TETHERING_USB);
         }
-        final SharedPreferences.Editor editor = mSharedPreferences.edit();
-        editor.putBoolean(mPreferenceKey, isChecked);
-        editor.apply();
         return true;
     }
 
@@ -86,17 +78,6 @@ public final class UsbTetherPreferenceController extends TogglePreferenceControl
         mContext.registerReceiver(mUsbChangeReceiver, filter);
     }
 
-
-    @OnLifecycleEvent(Lifecycle.Event.ON_RESUME)
-    public void onResume() {
-        mSharedPreferences.registerOnSharedPreferenceChangeListener(this);
-    }
-
-    @OnLifecycleEvent(Lifecycle.Event.ON_PAUSE)
-    public void onPause() {
-        mSharedPreferences.unregisterOnSharedPreferenceChangeListener(this);
-    }
-
     @OnLifecycleEvent(Lifecycle.Event.ON_STOP)
     public void onStop() {
         mContext.unregisterReceiver(mUsbChangeReceiver);
@@ -112,12 +93,6 @@ public final class UsbTetherPreferenceController extends TogglePreferenceControl
         }
     }
 
-    @Override
-    public void displayPreference(PreferenceScreen screen) {
-        super.displayPreference(screen);
-        mPreference = screen.findPreference(mPreferenceKey);
-    }
-
     @Override
     public void updateState(Preference preference) {
         super.updateState(preference);
@@ -126,6 +101,12 @@ public final class UsbTetherPreferenceController extends TogglePreferenceControl
         }
     }
 
+    @Override
+    public void onTetherStateUpdated(int state) {
+        mUsbTethering = TetherEnabler.isUsbTethering(state);
+        updateState(mPreference);
+    }
+
     @VisibleForTesting
     final BroadcastReceiver mUsbChangeReceiver = new BroadcastReceiver() {
         @Override
@@ -141,11 +122,4 @@ public final class UsbTetherPreferenceController extends TogglePreferenceControl
             updateState(mPreference);
         }
     };
-
-    @Override
-    public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key) {
-        if (TextUtils.equals(mPreferenceKey, key)) {
-            updateState(mPreference);
-        }
-    }
 }