From 7f1ff1b796ee92df2d79b6823811537b23fb348c Mon Sep 17 00:00:00 2001 From: Jason Chiu Date: Thu, 9 Jun 2022 07:18:07 +0000 Subject: [PATCH] Revert "Do not show the redundant RemoveAccountFailureDialog" This reverts commit e5f1d24913e4925a329c107d8dce38abec490358. Reason for revert: "Remove account" does nothing and shows no errors Fix: 232819214 Change-Id: I4a4e5084cde87ea2a9e5be1ff3ca6709e11ebc3d --- .../settings/accounts/RemoveAccountPreferenceController.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/accounts/RemoveAccountPreferenceController.java b/src/com/android/settings/accounts/RemoveAccountPreferenceController.java index 60faab932f9..7003eed252b 100644 --- a/src/com/android/settings/accounts/RemoveAccountPreferenceController.java +++ b/src/com/android/settings/accounts/RemoveAccountPreferenceController.java @@ -180,10 +180,11 @@ public class RemoveAccountPreferenceController extends AbstractPreferenceControl | AuthenticatorException e) { // handled below Log.w(TAG, "Remove account error: " + e); - RemoveAccountFailureDialog.show(getTargetFragment()); } Log.i(TAG, "failed: " + failed); - if (!failed) { + if (failed) { + RemoveAccountFailureDialog.show(getTargetFragment()); + } else { targetActivity.finish(); } }, null, mUserHandle);