PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move a line into try block

Browse Source 
Currently, NumberFormatException is never handled as
Integer.parseInt() is called outside try block.
This moves that line inside try block.

Change-Id: I54544f5a665ca0f821de5351001755cb965078dc
Signed-off-by: Shuhrat Dehkanov <k@efir.uz>
This commit is contained in:
Shuhrat Dehkanov
2013-11-01 17:39:44 +09:00
parent 10fdcab424
commit 7e77699895
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/com/android/settings/DisplaySettings.java
View File

@@ -71,7 +71,7 @@ public class DisplaySettings extends SettingsPreferenceFragment implements
private CheckBoxPreference mNotificationPulse; private CheckBoxPreference mNotificationPulse;
private final Configuration mCurConfig = new Configuration(); private final Configuration mCurConfig = new Configuration();
private ListPreference mScreenTimeoutPreference; private ListPreference mScreenTimeoutPreference;
private Preference mScreenSaverPreference; private Preference mScreenSaverPreference;
@@ -107,7 +107,7 @@ public class DisplaySettings extends SettingsPreferenceFragment implements
com.android.internal.R.bool.config_dreamsSupported) == false) { com.android.internal.R.bool.config_dreamsSupported) == false) {
getPreferenceScreen().removePreference(mScreenSaverPreference); getPreferenceScreen().removePreference(mScreenSaverPreference);
} }
mScreenTimeoutPreference = (ListPreference) findPreference(KEY_SCREEN_TIMEOUT); mScreenTimeoutPreference = (ListPreference) findPreference(KEY_SCREEN_TIMEOUT);
final long currentTimeout = Settings.System.getLong(resolver, SCREEN_OFF_TIMEOUT, final long currentTimeout = Settings.System.getLong(resolver, SCREEN_OFF_TIMEOUT,
FALLBACK_SCREEN_TIMEOUT_VALUE); FALLBACK_SCREEN_TIMEOUT_VALUE);
@@ -219,7 +219,7 @@ public class DisplaySettings extends SettingsPreferenceFragment implements
} }
return indices.length-1; return indices.length-1;
} }
public void readFontSizePreference(ListPreference pref) { public void readFontSizePreference(ListPreference pref) {
try { try {
mCurConfig.updateFrom(ActivityManagerNative.getDefault().getConfiguration()); mCurConfig.updateFrom(ActivityManagerNative.getDefault().getConfiguration());
@@ -237,7 +237,7 @@ public class DisplaySettings extends SettingsPreferenceFragment implements
pref.setSummary(String.format(res.getString(R.string.summary_font_size), pref.setSummary(String.format(res.getString(R.string.summary_font_size),
fontSizeNames[index])); fontSizeNames[index]));
} }
@Override @Override
public void onResume() { public void onResume() {
super.onResume(); super.onResume();
@@ -343,8 +343,8 @@ public class DisplaySettings extends SettingsPreferenceFragment implements
public boolean onPreferenceChange(Preference preference, Object objValue) { public boolean onPreferenceChange(Preference preference, Object objValue) {
final String key = preference.getKey(); final String key = preference.getKey();
if (KEY_SCREEN_TIMEOUT.equals(key)) { if (KEY_SCREEN_TIMEOUT.equals(key)) {
int value = Integer.parseInt((String) objValue);
try { try {
int value = Integer.parseInt((String) objValue);
Settings.System.putInt(getContentResolver(), SCREEN_OFF_TIMEOUT, value); Settings.System.putInt(getContentResolver(), SCREEN_OFF_TIMEOUT, value);
updateTimeoutPreferenceDescription(value); updateTimeoutPreferenceDescription(value);
} catch (NumberFormatException e) { } catch (NumberFormatException e) {