Merge "Fix bug #13440372 More option is displayed with Email/Gmail icon after... scrolling through settings options"

This commit is contained in:
Fabrice Di Meglio
2014-03-13 21:17:21 +00:00
committed by Android (Google) Code Review

View File

@@ -1580,9 +1580,6 @@ public class SettingsActivity extends Activity
view.findViewById(com.android.internal.R.id.summary); view.findViewById(com.android.internal.R.id.summary);
break; break;
} }
if (holder.mIcon != null) {
holder.mIcon.setBackgroundResource(R.color.background_drawer_icon);
}
view.setTag(holder); view.setTag(holder);
} else { } else {
view = convertView; view = convertView;
@@ -1650,7 +1647,18 @@ public class SettingsActivity extends Activity
Drawable icon = mAuthHelper.getDrawableForType(getContext(), accType); Drawable icon = mAuthHelper.getDrawableForType(getContext(), accType);
setHeaderIcon(holder, icon); setHeaderIcon(holder, icon);
} else { } else {
holder.mIcon.setImageResource(header.iconRes); if (header.iconRes > 0) {
holder.mIcon.setImageResource(header.iconRes);
} else {
holder.mIcon.setImageDrawable(null);
}
}
if (holder.mIcon != null) {
if (header.iconRes > 0) {
holder.mIcon.setBackgroundResource(R.color.background_drawer_icon);
} else {
holder.mIcon.setBackground(null);
}
} }
holder.mTitle.setText(header.getTitle(getContext().getResources())); holder.mTitle.setText(header.getTitle(getContext().getResources()));
CharSequence summary = header.getSummary(getContext().getResources()); CharSequence summary = header.getSummary(getContext().getResources());