Mass clean up: don't cast class when not needed.

Bug: none
Test: rebuild
Change-Id: Ie3f58a3d5ae99ade28a33dcac80c18de90d4d5b2
This commit is contained in:
Fan Zhang
2019-02-14 12:25:29 -08:00
parent 09285d72bd
commit 7db118e367
77 changed files with 153 additions and 152 deletions

View File

@@ -65,7 +65,7 @@ public abstract class AbstractBluetoothA2dpPreferenceController extends
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (ListPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
// Set a default value because BluetoothCodecConfig is null initially.
mPreference.setValue(mListValues[getDefaultIndex()]);
@@ -177,7 +177,7 @@ public abstract class AbstractBluetoothA2dpPreferenceController extends
@VisibleForTesting
void setCodecConfigPreference(BluetoothDevice device,
BluetoothCodecConfig config) {
BluetoothCodecConfig config) {
mBluetoothA2dp.setCodecConfigPreference(device, config);
}

View File

@@ -77,7 +77,7 @@ public class OemUnlockPreferenceController extends DeveloperOptionsPreferenceCon
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (RestrictedSwitchPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
}
@Override

View File

@@ -41,7 +41,6 @@ import com.android.settingslib.development.DeveloperOptionsPreferenceController;
import java.util.ArrayList;
import java.util.Comparator;
import java.util.List;
import java.util.Optional;
/**
* Preference controller to allow users to choose an overlay from a list for a given category.
@@ -91,7 +90,7 @@ public class OverlayCategoryPreferenceController extends DeveloperOptionsPrefere
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
setPreference((ListPreference) screen.findPreference(getPreferenceKey()));
setPreference(screen.findPreference(getPreferenceKey()));
}
@VisibleForTesting
@@ -124,7 +123,8 @@ public class OverlayCategoryPreferenceController extends DeveloperOptionsPrefere
if (PACKAGE_DEVICE_DEFAULT.equals(packageName)) {
return mOverlayManager.setEnabled(currentPackageName, false, USER_SYSTEM);
} else {
return mOverlayManager.setEnabledExclusiveInCategory(packageName, USER_SYSTEM);
return mOverlayManager.setEnabledExclusiveInCategory(packageName,
USER_SYSTEM);
}
} catch (RemoteException re) {
Log.w(TAG, "Error enabling overlay.", re);

View File

@@ -56,7 +56,7 @@ public class PictureColorModePreferenceController extends DeveloperOptionsPrefer
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (ColorModePreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
if (mPreference != null) {
mPreference.updateCurrentAndSupported();
}

View File

@@ -40,7 +40,7 @@ import com.android.settingslib.development.DeveloperOptionsPreferenceController;
public class StayAwakePreferenceController extends DeveloperOptionsPreferenceController
implements Preference.OnPreferenceChangeListener, LifecycleObserver, OnResume, OnPause,
implements Preference.OnPreferenceChangeListener, LifecycleObserver, OnResume, OnPause,
PreferenceControllerMixin {
private static final String TAG = "StayAwakeCtrl";
@@ -72,7 +72,7 @@ public class StayAwakePreferenceController extends DeveloperOptionsPreferenceCon
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (RestrictedSwitchPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
}
@Override

View File

@@ -45,7 +45,7 @@ public class FeatureFlagsPreferenceController extends BasePreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mGroup = (PreferenceGroup) screen.findPreference(getPreferenceKey());
mGroup = screen.findPreference(getPreferenceKey());
}
@Override
@@ -60,6 +60,6 @@ public class FeatureFlagsPreferenceController extends BasePreferenceController
mGroup.removeAll();
final Context prefContext = mGroup.getContext();
featureMap.keySet().stream().sorted().forEach(feature ->
mGroup.addPreference(new FeatureFlagPreference(prefContext, feature)));
mGroup.addPreference(new FeatureFlagPreference(prefContext, feature)));
}
}

View File

@@ -55,8 +55,8 @@ import java.util.Set;
*/
public class GameDriverAppPreferenceController extends BasePreferenceController
implements Preference.OnPreferenceChangeListener,
GameDriverContentObserver.OnGameDriverContentChangedListener, LifecycleObserver,
OnStart, OnStop {
GameDriverContentObserver.OnGameDriverContentChangedListener, LifecycleObserver,
OnStart, OnStop {
private final Context mContext;
private final ContentResolver mContentResolver;
@@ -103,9 +103,9 @@ public class GameDriverAppPreferenceController extends BasePreferenceController
@Override
public int getAvailabilityStatus() {
return DevelopmentSettingsEnabler.isDevelopmentSettingsEnabled(mContext)
&& (Settings.Global.getInt(mContentResolver,
Settings.Global.GAME_DRIVER_ALL_APPS, GAME_DRIVER_DEFAULT)
!= GAME_DRIVER_OFF)
&& (Settings.Global.getInt(mContentResolver,
Settings.Global.GAME_DRIVER_ALL_APPS, GAME_DRIVER_DEFAULT)
!= GAME_DRIVER_OFF)
? AVAILABLE
: CONDITIONALLY_UNAVAILABLE;
}
@@ -113,7 +113,7 @@ public class GameDriverAppPreferenceController extends BasePreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreferenceGroup = (PreferenceGroup) screen.findPreference(getPreferenceKey());
mPreferenceGroup = screen.findPreference(getPreferenceKey());
final Context context = mPreferenceGroup.getContext();
for (AppInfo appInfo : mAppInfos) {
@@ -179,6 +179,7 @@ public class GameDriverAppPreferenceController extends BasePreferenceController
info = applicationInfo;
label = packageManager.getApplicationLabel(applicationInfo).toString();
}
final ApplicationInfo info;
final String label;
}