PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Mass clean up: don't cast class when not needed.

Browse Source 
Bug: none
Test: rebuild
Change-Id: Ie3f58a3d5ae99ade28a33dcac80c18de90d4d5b2
This commit is contained in:
Fan Zhang
2019-02-14 12:25:29 -08:00
parent 09285d72bd
commit 7db118e367
77 changed files with 153 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/com/android/settings/connecteddevice/AddDevicePreferenceController.java
View File

@@ -68,7 +68,7 @@ public class AddDevicePreferenceController extends BasePreferenceController
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
if (isAvailable()) {
mPreference = (Preference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
}
}

4
src/com/android/settings/connecteddevice/AvailableMediaDeviceGroupController.java
View File

@@ -84,7 +84,7 @@ public class AvailableMediaDeviceGroupController extends BasePreferenceControlle
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
if (isAvailable()) {
mPreferenceGroup = (PreferenceGroup) screen.findPreference(KEY);
mPreferenceGroup = screen.findPreference(KEY);
mPreferenceGroup.setVisible(false);
updateTitle();
mBluetoothDeviceUpdater.setPrefContext(screen.getContext());
@@ -127,7 +127,7 @@ public class AvailableMediaDeviceGroupController extends BasePreferenceControlle
@VisibleForTesting
public void setBluetoothDeviceUpdater(BluetoothDeviceUpdater bluetoothDeviceUpdater) {
mBluetoothDeviceUpdater = bluetoothDeviceUpdater;
mBluetoothDeviceUpdater = bluetoothDeviceUpdater;
}
@Override

2
src/com/android/settings/connecteddevice/ConnectedDeviceGroupController.java
View File

@@ -74,7 +74,7 @@ public class ConnectedDeviceGroupController extends BasePreferenceController
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
if (isAvailable()) {
mPreferenceGroup = (PreferenceGroup) screen.findPreference(KEY);
mPreferenceGroup = screen.findPreference(KEY);
mPreferenceGroup.setVisible(false);
final Context context = screen.getContext();

4
src/com/android/settings/connecteddevice/PreviouslyConnectedDevicePreferenceController.java
View File

@@ -47,7 +47,7 @@ public class PreviouslyConnectedDevicePreferenceController extends BasePreferenc
super(context, preferenceKey);
mSavedDockUpdater = FeatureFactory.getFactory(
context).getDockUpdaterFeatureProvider().getSavedDockUpdater(context, this);
context).getDockUpdaterFeatureProvider().getSavedDockUpdater(context, this);
}
@Override
@@ -60,7 +60,7 @@ public class PreviouslyConnectedDevicePreferenceController extends BasePreferenc
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreferenceGroup = (PreferenceGroup) screen.findPreference(getPreferenceKey());
mPreferenceGroup = screen.findPreference(getPreferenceKey());
mPreferenceGroup.setVisible(false);
if (isAvailable()) {

2
src/com/android/settings/connecteddevice/SavedDeviceGroupController.java
View File

@@ -74,7 +74,7 @@ public class SavedDeviceGroupController extends BasePreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
if (isAvailable()) {
mPreferenceGroup = (PreferenceGroup) screen.findPreference(KEY);
mPreferenceGroup = screen.findPreference(KEY);
mPreferenceGroup.setVisible(false);
final Context context = screen.getContext();

4
src/com/android/settings/connecteddevice/usb/UsbDetailsDataRoleController.java
View File

@@ -57,7 +57,7 @@ public class UsbDetailsDataRoleController extends UsbDetailsController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreferenceCategory = (PreferenceCategory) screen.findPreference(getPreferenceKey());
mPreferenceCategory = screen.findPreference(getPreferenceKey());
mHostPref = makeRadioPreference(UsbBackend.dataRoleToString(DATA_ROLE_HOST),
R.string.usb_control_host);
mDevicePref = makeRadioPreference(UsbBackend.dataRoleToString(DATA_ROLE_DEVICE),
@@ -74,7 +74,7 @@ public class UsbDetailsDataRoleController extends UsbDetailsController
mDevicePref.setChecked(false);
mHostPref.setChecked(true);
mPreferenceCategory.setEnabled(true);
} else if (!connected || dataRole == DATA_ROLE_NONE){
} else if (!connected || dataRole == DATA_ROLE_NONE) {
mPreferenceCategory.setEnabled(false);
if (mNextRolePref == null) {
// Disconnected with no operation pending, so clear subtexts

4
src/com/android/settings/connecteddevice/usb/UsbDetailsFunctionsController.java
View File

@@ -68,14 +68,14 @@ public class UsbDetailsFunctionsController extends UsbDetailsController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mProfilesContainer = (PreferenceCategory) screen.findPreference(getPreferenceKey());
mProfilesContainer = screen.findPreference(getPreferenceKey());
}
/**
* Gets a switch preference for the particular option, creating it if needed.
*/
private RadioButtonPreference getProfilePreference(String key, int titleId) {
RadioButtonPreference pref = (RadioButtonPreference) mProfilesContainer.findPreference(key);
RadioButtonPreference pref = mProfilesContainer.findPreference(key);
if (pref == null) {
pref = new RadioButtonPreference(mProfilesContainer.getContext());
pref.setKey(key);

3
src/com/android/settings/connecteddevice/usb/UsbDetailsHeaderController.java
View File

@@ -40,8 +40,7 @@ public class UsbDetailsHeaderController extends UsbDetailsController {
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
final LayoutPreference headerPreference =
(LayoutPreference) screen.findPreference(KEY_DEVICE_HEADER);
final LayoutPreference headerPreference = screen.findPreference(KEY_DEVICE_HEADER);
mHeaderController = EntityHeaderController.newInstance(mFragment.getActivity(), mFragment,
headerPreference.findViewById(R.id.entity_header));
}

6
src/com/android/settings/connecteddevice/usb/UsbDetailsPowerRoleController.java
View File

@@ -58,7 +58,7 @@ public class UsbDetailsPowerRoleController extends UsbDetailsController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreferenceCategory = (PreferenceCategory) screen.findPreference(getPreferenceKey());
mPreferenceCategory = screen.findPreference(getPreferenceKey());
mSwitchPreference = new SwitchPreference(mPreferenceCategory.getContext());
mSwitchPreference.setTitle(R.string.usb_use_power_only);
mSwitchPreference.setOnPreferenceClickListener(this);
@@ -70,7 +70,7 @@ public class UsbDetailsPowerRoleController extends UsbDetailsController
// Hide this option if this is not a PD compatible connection
if (connected && !mUsbBackend.areAllRolesSupported()) {
mFragment.getPreferenceScreen().removePreference(mPreferenceCategory);
} else if (connected && mUsbBackend.areAllRolesSupported()){
} else if (connected && mUsbBackend.areAllRolesSupported()) {
mFragment.getPreferenceScreen().addPreference(mPreferenceCategory);
}
if (powerRole == POWER_ROLE_SOURCE) {
@@ -79,7 +79,7 @@ public class UsbDetailsPowerRoleController extends UsbDetailsController
} else if (powerRole == POWER_ROLE_SINK) {
mSwitchPreference.setChecked(false);
mPreferenceCategory.setEnabled(true);
} else if (!connected || powerRole == POWER_ROLE_NONE){
} else if (!connected || powerRole == POWER_ROLE_NONE) {
mPreferenceCategory.setEnabled(false);
if (mNextPowerRole == POWER_ROLE_NONE) {
mSwitchPreference.setSummary("");